From 2dc5864f447d0429f7101526a518529e9919b067 Mon Sep 17 00:00:00 2001 From: shuv0id <110290476+shuv0id@users.noreply.github.com> Date: Tue, 18 Nov 2025 22:25:34 +0530 Subject: [PATCH] fix: add missing context to debug logs Adds chart name to dependency logs, namespace to resource waiting logs, and confirmation message when all resources are ready. Addresses #31520 Signed-off-by: shuv0id <110290476+shuv0id@users.noreply.github.com> --- pkg/chart/common/util/jsonschema.go | 2 +- pkg/kube/statuswait.go | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/pkg/chart/common/util/jsonschema.go b/pkg/chart/common/util/jsonschema.go index 649bbecac..6d7f32604 100644 --- a/pkg/chart/common/util/jsonschema.go +++ b/pkg/chart/common/util/jsonschema.go @@ -87,7 +87,7 @@ func ValidateAgainstSchema(ch chart.Charter, values map[string]interface{}) erro sb.WriteString(err.Error()) } } - slog.Debug("number of dependencies in the chart", "dependencies", len(chrt.Dependencies())) + slog.Debug("number of dependencies in the chart", "chart", chrt.Name(), "dependencies", len(chrt.Dependencies())) // For each dependency, recursively call this function with the coalesced values for _, subchart := range chrt.Dependencies() { sub, err := chart.NewAccessor(subchart) diff --git a/pkg/kube/statuswait.go b/pkg/kube/statuswait.go index 225321f6e..6077af165 100644 --- a/pkg/kube/statuswait.go +++ b/pkg/kube/statuswait.go @@ -231,6 +231,7 @@ func statusObserver(cancel context.CancelFunc, desired status.Status) collector. } if aggregator.AggregateStatus(rss, desired) == desired { + slog.Debug("all resources achieved desired status", "desiredStatus", desired, "resourceCount", len(rss)) cancel() return } @@ -241,7 +242,7 @@ func statusObserver(cancel context.CancelFunc, desired status.Status) collector. return nonDesiredResources[i].Identifier.Name < nonDesiredResources[j].Identifier.Name }) first := nonDesiredResources[0] - slog.Debug("waiting for resource", "name", first.Identifier.Name, "kind", first.Identifier.GroupKind.Kind, "expectedStatus", desired, "actualStatus", first.Status) + slog.Debug("waiting for resource", "namespace", first.Identifier.Namespace, "name", first.Identifier.Name, "kind", first.Identifier.GroupKind.Kind, "expectedStatus", desired, "actualStatus", first.Status) } } }