Added a new error message which tell to use `--devel` option.
pull/10248/head
Anshul Verma 4 years ago
parent f41f46c6c6
commit e240724c7b

@ -19,7 +19,6 @@ package main
import ( import (
"fmt" "fmt"
"path/filepath" "path/filepath"
"strings"
"testing" "testing"
"helm.sh/helm/v3/pkg/repo/repotest" "helm.sh/helm/v3/pkg/repo/repotest"
@ -47,14 +46,14 @@ func TestShowPreReleaseChart(t *testing.T) {
name: "show pre-release chart", name: "show pre-release chart",
args: "test/pre-release-chart", args: "test/pre-release-chart",
fail: true, fail: true,
expectedErr: "failed to download \"test/pre-release-chart\"", expectedErr: "failed to download \"test/pre-release-chart\". Use --devel for a development version",
}, },
{ {
name: "show pre-release chart", name: "show pre-release chart",
args: "test/pre-release-chart", args: "test/pre-release-chart",
fail: true, fail: true,
flags: "--version 1.0.0", flags: "--version 1.0.0",
expectedErr: "failed to download \"test/pre-release-chart\" at version \"1.0.0\"", expectedErr: "failed to download \"test/pre-release-chart\" at version \"1.0.0\". Use --devel for a development version",
}, },
{ {
name: "show pre-release chart with 'devel' flag", name: "show pre-release chart with 'devel' flag",
@ -77,7 +76,8 @@ func TestShowPreReleaseChart(t *testing.T) {
_, _, err := executeActionCommand(cmd) _, _, err := executeActionCommand(cmd)
if err != nil { if err != nil {
if tt.fail { if tt.fail {
if !strings.Contains(err.Error(), tt.expectedErr) { //if !strings.Contains(err.Error(), tt.expectedErr) {
if err.Error() != tt.expectedErr {
t.Errorf("%q expected error: %s, got: %s", tt.name, tt.expectedErr, err.Error()) t.Errorf("%q expected error: %s, got: %s", tt.name, tt.expectedErr, err.Error())
} }
return return

@ -766,5 +766,5 @@ func (c *ChartPathOptions) LocateChart(name string, settings *cli.EnvSettings) (
atVersion = fmt.Sprintf(" at version %q", version) atVersion = fmt.Sprintf(" at version %q", version)
} }
return filename, errors.Errorf("failed to download %q%s", name, atVersion) return filename, errors.Errorf("failed to download %q%s. Use --devel for a development version", name, atVersion)
} }

Loading…
Cancel
Save