From e240724c7b70f26d13ebf935b62681f8c1bd0304 Mon Sep 17 00:00:00 2001 From: Anshul Verma Date: Tue, 19 Oct 2021 15:13:41 +0530 Subject: [PATCH] Resolve #10212 Added a new error message which tell to use `--devel` option. --- cmd/helm/show_test.go | 8 ++++---- pkg/action/install.go | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/cmd/helm/show_test.go b/cmd/helm/show_test.go index 8dba0aea4..0d0f2961c 100644 --- a/cmd/helm/show_test.go +++ b/cmd/helm/show_test.go @@ -19,7 +19,6 @@ package main import ( "fmt" "path/filepath" - "strings" "testing" "helm.sh/helm/v3/pkg/repo/repotest" @@ -47,14 +46,14 @@ func TestShowPreReleaseChart(t *testing.T) { name: "show pre-release chart", args: "test/pre-release-chart", fail: true, - expectedErr: "failed to download \"test/pre-release-chart\"", + expectedErr: "failed to download \"test/pre-release-chart\". Use --devel for a development version", }, { name: "show pre-release chart", args: "test/pre-release-chart", fail: true, flags: "--version 1.0.0", - expectedErr: "failed to download \"test/pre-release-chart\" at version \"1.0.0\"", + expectedErr: "failed to download \"test/pre-release-chart\" at version \"1.0.0\". Use --devel for a development version", }, { name: "show pre-release chart with 'devel' flag", @@ -77,7 +76,8 @@ func TestShowPreReleaseChart(t *testing.T) { _, _, err := executeActionCommand(cmd) if err != nil { if tt.fail { - if !strings.Contains(err.Error(), tt.expectedErr) { + //if !strings.Contains(err.Error(), tt.expectedErr) { + if err.Error() != tt.expectedErr { t.Errorf("%q expected error: %s, got: %s", tt.name, tt.expectedErr, err.Error()) } return diff --git a/pkg/action/install.go b/pkg/action/install.go index b84a57271..9feb34118 100644 --- a/pkg/action/install.go +++ b/pkg/action/install.go @@ -766,5 +766,5 @@ func (c *ChartPathOptions) LocateChart(name string, settings *cli.EnvSettings) ( atVersion = fmt.Sprintf(" at version %q", version) } - return filename, errors.Errorf("failed to download %q%s", name, atVersion) + return filename, errors.Errorf("failed to download %q%s. Use --devel for a development version", name, atVersion) }