Maintain backwards compatibility by introducing chartutil.CreateFromWithMetadata

Signed-off-by: Filip Krakowski <krakowski@hhu.de>

cmd/helm/create.go

@@ -105,7 +105,7 @@ func (o *createOptions) run(out io.Writer) error {
 		if filepath.IsAbs(o.starter) {
 			lstarter = o.starter
 		}
-		return chartutil.CreateFrom(chartname, filepath.Dir(chartname), lstarter, o.keepMetadata)
+		return chartutil.CreateFromWithMetadata(chartname, filepath.Dir(chartname), lstarter, o.keepMetadata)
 	}
 
 	chartutil.Stderr = out

pkg/chartutil/create.go

@@ -548,7 +548,15 @@ spec:
 var Stderr io.Writer = os.Stderr
 
 // CreateFrom creates a new chart, but scaffolds it from the src chart.
-func CreateFrom(name, dest, src string, keepMetadata bool) error {
+// Deprecated: Use CreateFromWithMetadata
+// TODO Helm 4: Fold CreateFromWithMetadata back into CreateFrom
+func CreateFrom(chartfile *chart.Metadata, dest, src string) error {
+	return CreateFromWithMetadata(chartfile.Name, dest, src, false)
+}
+
+// CreateFromWithMetadata creates a new chart, but scaffolds it from the src chart and
+// provides the option to preserve custom metadata (Chart.yaml) files.
+func CreateFromWithMetadata(name, dest, src string, keepMetadata bool) error {
 	schart, err := loader.Load(src)
 	if err != nil {
 		return errors.Wrapf(err, "could not load %s", src)