From c45230d849d618c3c0f8580b9ee0f09186b7dab7 Mon Sep 17 00:00:00 2001 From: Filip Krakowski Date: Fri, 9 Sep 2022 00:09:56 +0200 Subject: [PATCH] Maintain backwards compatibility by introducing chartutil.CreateFromWithMetadata Signed-off-by: Filip Krakowski --- cmd/helm/create.go | 2 +- pkg/chartutil/create.go | 10 +++++++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/cmd/helm/create.go b/cmd/helm/create.go index 52acb6670..247049c67 100644 --- a/cmd/helm/create.go +++ b/cmd/helm/create.go @@ -105,7 +105,7 @@ func (o *createOptions) run(out io.Writer) error { if filepath.IsAbs(o.starter) { lstarter = o.starter } - return chartutil.CreateFrom(chartname, filepath.Dir(chartname), lstarter, o.keepMetadata) + return chartutil.CreateFromWithMetadata(chartname, filepath.Dir(chartname), lstarter, o.keepMetadata) } chartutil.Stderr = out diff --git a/pkg/chartutil/create.go b/pkg/chartutil/create.go index 6f1c65437..f4c951ec8 100644 --- a/pkg/chartutil/create.go +++ b/pkg/chartutil/create.go @@ -548,7 +548,15 @@ spec: var Stderr io.Writer = os.Stderr // CreateFrom creates a new chart, but scaffolds it from the src chart. -func CreateFrom(name, dest, src string, keepMetadata bool) error { +// Deprecated: Use CreateFromWithMetadata +// TODO Helm 4: Fold CreateFromWithMetadata back into CreateFrom +func CreateFrom(chartfile *chart.Metadata, dest, src string) error { + return CreateFromWithMetadata(chartfile.Name, dest, src, false) +} + +// CreateFromWithMetadata creates a new chart, but scaffolds it from the src chart and +// provides the option to preserve custom metadata (Chart.yaml) files. +func CreateFromWithMetadata(name, dest, src string, keepMetadata bool) error { schart, err := loader.Load(src) if err != nil { return errors.Wrapf(err, "could not load %s", src)