fix: when dep up fails, do not delete charts on error

Signed-off-by: jorgevillaverde <jorge.villaverde@toucansoft.io>
pull/9680/head
jorgevillaverde 4 years ago
parent 93631be28d
commit 7a37814cdb
No known key found for this signature in database
GPG Key ID: BD639C87888CC034

@ -385,16 +385,10 @@ func (m *Manager) downloadAll(deps []*chart.Dependency) error {
fmt.Fprintln(m.Out, "Save error occurred: ", saveError)
fmt.Fprintln(m.Out, "Deleting newly downloaded charts, restoring pre-update state")
for _, dep := range deps {
if err := m.safeDeleteDep(dep.Name, destPath); err != nil {
if err := m.safeDeleteDep(dep.Name, tmpPath); err != nil {
return err
}
}
if err := os.RemoveAll(destPath); err != nil {
return errors.Wrapf(err, "failed to remove %v", destPath)
}
if err := fs.RenameWithFallback(tmpPath, destPath); err != nil {
return errors.Wrap(err, "unable to move current charts to tmp dir")
}
return saveError
}
return nil

Loading…
Cancel
Save