From 7a37814cdb851b78ecd375e65564da5dae39c74a Mon Sep 17 00:00:00 2001 From: jorgevillaverde Date: Tue, 1 Jun 2021 19:33:22 -0300 Subject: [PATCH] fix: when dep up fails, do not delete charts on error Signed-off-by: jorgevillaverde --- pkg/downloader/manager.go | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/pkg/downloader/manager.go b/pkg/downloader/manager.go index 2656be7bd..34c49472f 100644 --- a/pkg/downloader/manager.go +++ b/pkg/downloader/manager.go @@ -385,16 +385,10 @@ func (m *Manager) downloadAll(deps []*chart.Dependency) error { fmt.Fprintln(m.Out, "Save error occurred: ", saveError) fmt.Fprintln(m.Out, "Deleting newly downloaded charts, restoring pre-update state") for _, dep := range deps { - if err := m.safeDeleteDep(dep.Name, destPath); err != nil { + if err := m.safeDeleteDep(dep.Name, tmpPath); err != nil { return err } } - if err := os.RemoveAll(destPath); err != nil { - return errors.Wrapf(err, "failed to remove %v", destPath) - } - if err := fs.RenameWithFallback(tmpPath, destPath); err != nil { - return errors.Wrap(err, "unable to move current charts to tmp dir") - } return saveError } return nil