Merge pull request #31561 from atombrella/feature/nilness_cleanup

Remove two redundant if-checks.

pkg/downloader/chart_downloader.go

@@ -227,13 +227,10 @@ func (c *ChartDownloader) DownloadToCache(ref, version string) (string, *provena
 	// Check the cache for the file
 	digest, err := hex.DecodeString(digestString)
 	if err != nil {
-		return "", nil, err
+		return "", nil, fmt.Errorf("unable to decode digest: %w", err)
 	}
 	var digest32 [32]byte
 	copy(digest32[:], digest)
-	if err != nil {
-		return "", nil, fmt.Errorf("unable to decode digest: %w", err)
-	}
 
 	var pth string
 	// only fetch from the cache if we have a digest

pkg/repo/v1/index_test.go

@@ -708,9 +708,7 @@ func TestLoadIndex_DuplicateChartDeps(t *testing.T) {
 			}
 			cvs := idx.Entries["nginx"]
 			if cvs == nil {
-				if err != nil {
+				t.Error("expected one chart version not to be filtered out")
-					t.Error("expected one chart version not to be filtered out")
-				}
 			}
 			for _, v := range cvs {
 				if v.Name == "alpine" {