From 380abe2b1643e1a8eec9cd575d1d5c0521cf1c31 Mon Sep 17 00:00:00 2001 From: Mads Jensen Date: Sat, 22 Nov 2025 10:05:18 +0100 Subject: [PATCH] Remove two redundant if-checks. These were found with the nilness checker. Signed-off-by: Mads Jensen --- pkg/downloader/chart_downloader.go | 5 +---- pkg/repo/v1/index_test.go | 4 +--- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/pkg/downloader/chart_downloader.go b/pkg/downloader/chart_downloader.go index 00c8c56e8..190aaebf9 100644 --- a/pkg/downloader/chart_downloader.go +++ b/pkg/downloader/chart_downloader.go @@ -227,13 +227,10 @@ func (c *ChartDownloader) DownloadToCache(ref, version string) (string, *provena // Check the cache for the file digest, err := hex.DecodeString(digestString) if err != nil { - return "", nil, err + return "", nil, fmt.Errorf("unable to decode digest: %w", err) } var digest32 [32]byte copy(digest32[:], digest) - if err != nil { - return "", nil, fmt.Errorf("unable to decode digest: %w", err) - } var pth string // only fetch from the cache if we have a digest diff --git a/pkg/repo/v1/index_test.go b/pkg/repo/v1/index_test.go index a8aadadec..517457dc4 100644 --- a/pkg/repo/v1/index_test.go +++ b/pkg/repo/v1/index_test.go @@ -708,9 +708,7 @@ func TestLoadIndex_DuplicateChartDeps(t *testing.T) { } cvs := idx.Entries["nginx"] if cvs == nil { - if err != nil { - t.Error("expected one chart version not to be filtered out") - } + t.Error("expected one chart version not to be filtered out") } for _, v := range cvs { if v.Name == "alpine" {