Merge pull request #3543 from adshmh/fix-left-over-repotest-dirs-from-tests

Clean up temporary "helm-repotest-*" directories left behind by tests under cmd/helm

cmd/helm/repo_add_test.go

@@ -36,7 +36,7 @@ func TestRepoAddCmd(t *testing.T) {
 	cleanup := resetEnv()
 	defer func() {
 		srv.Stop()
-		os.Remove(thome.String())
+		os.RemoveAll(thome.String())
 		cleanup()
 	}()
 	if err := ensureTestHome(thome, t); err != nil {
@@ -72,7 +72,7 @@ func TestRepoAdd(t *testing.T) {
 	hh := thome
 	defer func() {
 		ts.Stop()
-		os.Remove(thome.String())
+		os.RemoveAll(thome.String())
 		cleanup()
 	}()
 	if err := ensureTestHome(hh, t); err != nil {

cmd/helm/repo_remove_test.go

@@ -37,7 +37,7 @@ func TestRepoRemove(t *testing.T) {
 	cleanup := resetEnv()
 	defer func() {
 		ts.Stop()
-		os.Remove(thome.String())
+		os.RemoveAll(thome.String())
 		cleanup()
 	}()
 	if err := ensureTestHome(hh, t); err != nil {

cmd/helm/repo_update_test.go

@@ -75,7 +75,7 @@ func TestUpdateCharts(t *testing.T) {
 	cleanup := resetEnv()
 	defer func() {
 		ts.Stop()
-		os.Remove(thome.String())
+		os.RemoveAll(thome.String())
 		cleanup()
 	}()
 	if err := ensureTestHome(hh, t); err != nil {