From 55cc23cb0168d527ba60de359e38c5717cf2577d Mon Sep 17 00:00:00 2001 From: Arash Deshmeh Date: Tue, 20 Feb 2018 11:45:46 -0500 Subject: [PATCH] fix(helm): fix the bug in tests under cmd/helm that leaves behind temporary directories named "repo-test-*" during build. Signed-off-by: Arash Deshmeh --- cmd/helm/repo_add_test.go | 4 ++-- cmd/helm/repo_remove_test.go | 2 +- cmd/helm/repo_update_test.go | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/cmd/helm/repo_add_test.go b/cmd/helm/repo_add_test.go index 2e36decbf..1f49e45ea 100644 --- a/cmd/helm/repo_add_test.go +++ b/cmd/helm/repo_add_test.go @@ -36,7 +36,7 @@ func TestRepoAddCmd(t *testing.T) { cleanup := resetEnv() defer func() { srv.Stop() - os.Remove(thome.String()) + os.RemoveAll(thome.String()) cleanup() }() if err := ensureTestHome(thome, t); err != nil { @@ -72,7 +72,7 @@ func TestRepoAdd(t *testing.T) { hh := thome defer func() { ts.Stop() - os.Remove(thome.String()) + os.RemoveAll(thome.String()) cleanup() }() if err := ensureTestHome(hh, t); err != nil { diff --git a/cmd/helm/repo_remove_test.go b/cmd/helm/repo_remove_test.go index 84244ae98..63082b42e 100644 --- a/cmd/helm/repo_remove_test.go +++ b/cmd/helm/repo_remove_test.go @@ -37,7 +37,7 @@ func TestRepoRemove(t *testing.T) { cleanup := resetEnv() defer func() { ts.Stop() - os.Remove(thome.String()) + os.RemoveAll(thome.String()) cleanup() }() if err := ensureTestHome(hh, t); err != nil { diff --git a/cmd/helm/repo_update_test.go b/cmd/helm/repo_update_test.go index 0d0a31350..e6f2af32f 100644 --- a/cmd/helm/repo_update_test.go +++ b/cmd/helm/repo_update_test.go @@ -75,7 +75,7 @@ func TestUpdateCharts(t *testing.T) { cleanup := resetEnv() defer func() { ts.Stop() - os.Remove(thome.String()) + os.RemoveAll(thome.String()) cleanup() }() if err := ensureTestHome(hh, t); err != nil {