the last revert commit still was making an undesired change

Signed-off-by: Jeff Knurek <knurek.stuff@gmail.com>
pull/8516/head
Jeff Knurek 5 years ago
parent cd90fb4319
commit 5c9ff04da4

@ -130,7 +130,7 @@ func TestHelmCreateChart(t *testing.T) {
return return
} }
m := All(createdChart, values, namespace, strict).Messages m := All(createdChart, values, namespace, true).Messages
if ll := len(m); ll != 1 { if ll := len(m); ll != 1 {
t.Errorf("All should have had exactly 1 error. Got %d", ll) t.Errorf("All should have had exactly 1 error. Got %d", ll)
} else if msg := m[0].Err.Error(); !strings.Contains(msg, "icon is recommended") { } else if msg := m[0].Err.Error(); !strings.Contains(msg, "icon is recommended") {

@ -112,7 +112,6 @@ data:
myval1: {{default "val" .Values.mymap.key1 }} myval1: {{default "val" .Values.mymap.key1 }}
myval2: {{default "val" .Values.mymap.key2 }} myval2: {{default "val" .Values.mymap.key2 }}
` `
var ingoredStrict = true
ch := chart.Chart{ ch := chart.Chart{
Metadata: &chart.Metadata{ Metadata: &chart.Metadata{
Name: "regression.6705", Name: "regression.6705",
@ -133,7 +132,7 @@ data:
linter := &support.Linter{ linter := &support.Linter{
ChartDir: filepath.Join(dir, ch.Metadata.Name), ChartDir: filepath.Join(dir, ch.Metadata.Name),
} }
Templates(linter, vals, namespace, ingoredStrict) Templates(linter, vals, namespace, true)
if len(linter.Messages) != 0 { if len(linter.Messages) != 0 {
t.Errorf("expected zero messages, got %d", len(linter.Messages)) t.Errorf("expected zero messages, got %d", len(linter.Messages))
for i, msg := range linter.Messages { for i, msg := range linter.Messages {

Loading…
Cancel
Save