From 5c9ff04da4bc5b685977e761f527a13832a65654 Mon Sep 17 00:00:00 2001 From: Jeff Knurek Date: Fri, 7 Aug 2020 13:09:11 +0200 Subject: [PATCH] the last revert commit still was making an undesired change Signed-off-by: Jeff Knurek --- pkg/lint/lint_test.go | 2 +- pkg/lint/rules/template_test.go | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/pkg/lint/lint_test.go b/pkg/lint/lint_test.go index 2c050fa21..acd67adac 100644 --- a/pkg/lint/lint_test.go +++ b/pkg/lint/lint_test.go @@ -130,7 +130,7 @@ func TestHelmCreateChart(t *testing.T) { return } - m := All(createdChart, values, namespace, strict).Messages + m := All(createdChart, values, namespace, true).Messages if ll := len(m); ll != 1 { t.Errorf("All should have had exactly 1 error. Got %d", ll) } else if msg := m[0].Err.Error(); !strings.Contains(msg, "icon is recommended") { diff --git a/pkg/lint/rules/template_test.go b/pkg/lint/rules/template_test.go index 5e2913138..548a52edb 100644 --- a/pkg/lint/rules/template_test.go +++ b/pkg/lint/rules/template_test.go @@ -112,7 +112,6 @@ data: myval1: {{default "val" .Values.mymap.key1 }} myval2: {{default "val" .Values.mymap.key2 }} ` - var ingoredStrict = true ch := chart.Chart{ Metadata: &chart.Metadata{ Name: "regression.6705", @@ -133,7 +132,7 @@ data: linter := &support.Linter{ ChartDir: filepath.Join(dir, ch.Metadata.Name), } - Templates(linter, vals, namespace, ingoredStrict) + Templates(linter, vals, namespace, true) if len(linter.Messages) != 0 { t.Errorf("expected zero messages, got %d", len(linter.Messages)) for i, msg := range linter.Messages {