Fix: --values not working when using helm upgrade --install

Signed-off-by: Song Shukun <song.shukun@fujitsu.com>
pull/7673/head
Song Shukun 6 years ago
parent ec2e77cded
commit 506b02f656

@ -80,11 +80,6 @@ func newUpgradeCmd(cfg *action.Configuration, out io.Writer) *cobra.Command {
client.Version = ">0.0.0-0" client.Version = ">0.0.0-0"
} }
vals, err := valueOpts.MergeValues(getter.All(settings))
if err != nil {
return err
}
chartPath, err := client.ChartPathOptions.LocateChart(args[1], settings) chartPath, err := client.ChartPathOptions.LocateChart(args[1], settings)
if err != nil { if err != nil {
return err return err
@ -136,6 +131,11 @@ func newUpgradeCmd(cfg *action.Configuration, out io.Writer) *cobra.Command {
fmt.Fprintln(out, "WARNING: This chart is deprecated") fmt.Fprintln(out, "WARNING: This chart is deprecated")
} }
vals, err := valueOpts.MergeValues(getter.All(settings))
if err != nil {
return err
}
rel, err := client.Run(args[0], ch, vals) rel, err := client.Run(args[0], ch, vals)
if err != nil { if err != nil {
return errors.Wrap(err, "UPGRADE FAILED") return errors.Wrap(err, "UPGRADE FAILED")

Loading…
Cancel
Save