From 506b02f6561ad6ab0e2577b9e396238eb16cd2db Mon Sep 17 00:00:00 2001 From: Song Shukun Date: Tue, 25 Feb 2020 15:13:47 +0900 Subject: [PATCH] Fix: --values not working when using helm upgrade --install Signed-off-by: Song Shukun --- cmd/helm/upgrade.go | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/cmd/helm/upgrade.go b/cmd/helm/upgrade.go index dea866e4d..327073b16 100644 --- a/cmd/helm/upgrade.go +++ b/cmd/helm/upgrade.go @@ -80,11 +80,6 @@ func newUpgradeCmd(cfg *action.Configuration, out io.Writer) *cobra.Command { client.Version = ">0.0.0-0" } - vals, err := valueOpts.MergeValues(getter.All(settings)) - if err != nil { - return err - } - chartPath, err := client.ChartPathOptions.LocateChart(args[1], settings) if err != nil { return err @@ -136,6 +131,11 @@ func newUpgradeCmd(cfg *action.Configuration, out io.Writer) *cobra.Command { fmt.Fprintln(out, "WARNING: This chart is deprecated") } + vals, err := valueOpts.MergeValues(getter.All(settings)) + if err != nil { + return err + } + rel, err := client.Run(args[0], ch, vals) if err != nil { return errors.Wrap(err, "UPGRADE FAILED")