refactor: keep carbon ads async

pull/176/head
Eduardo San Martin Morote 5 years ago
parent 618d97fb9e
commit 67e80c97c1

@ -36,12 +36,16 @@
<Page v-else> <Page v-else>
<template #top> <template #top>
<slot name="page-top-ads"> <slot name="page-top-ads">
<CarbonAds <div
id="ads-container"
v-if="theme.carbonAds && theme.carbonAds.carbon" v-if="theme.carbonAds && theme.carbonAds.carbon"
:key="'carbon' + page.relativePath" >
:code="theme.carbonAds.carbon" <CarbonAds
:placement="theme.carbonAds.placement" :key="'carbon' + page.relativePath"
/> :code="theme.carbonAds.carbon"
:placement="theme.carbonAds.placement"
/>
</div>
</slot> </slot>
<slot name="page-top" /> <slot name="page-top" />
</template> </template>
@ -150,3 +154,34 @@ const pageClasses = computed(() => {
] ]
}) })
</script> </script>
<style>
#ads-container {
margin: 0 auto;
}
@media (min-width: 420px) {
#ads-container {
position: relative;
right: 0;
float: right;
margin: -8px -8px 24px 24px;
width: 146px;
}
}
@media (max-width: 420px) {
#ads-container {
/* Avoid layout shift */
height: 105px;
}
}
@media (min-width: 1400px) {
#ads-container {
position: fixed;
right: 8px;
bottom: 8px;
}
}
</style>

@ -38,30 +38,17 @@ onMounted(() => {
@media (min-width: 420px) { @media (min-width: 420px) {
.carbon-ads { .carbon-ads {
position: relative;
right: -8px;
z-index: 1; z-index: 1;
float: right; float: right;
margin: -8px -8px 24px 24px; margin: -8px -8px 24px 24px;
padding: 8px; padding: 8px;
width: 146px; width: 146px;
max-width: 100%;
}
}
@media (max-width: 420px) {
.carbon-ads {
/* Avoid layout shift */
height: 105px;
} }
} }
@media (min-width: 1400px) { @media (min-width: 1400px) {
.carbon-ads { .carbon-ads {
position: fixed;
top: auto;
right: 8px; right: 8px;
bottom: 8px;
float: none; float: none;
margin: 0; margin: 0;
} }

Loading…
Cancel
Save