msb-public
/
tech-interview-handbook
mirror of https://github.com/yangshun/tech-interview-handbook
2
1
Code Issues Projects Releases Wiki Activity

Merge branch 'main' of github.com:yangshun/tech-interview-handbook

Browse Source 
* 'main' of github.com:yangshun/tech-interview-handbook:
  [resumes][feat] use overflow-auto instead
  [resumes][fix] invalidate fetch query on submit
  [resumes][fix] fix reply comments ()
pull/413/head
Bryann Yeap Kok Keong 3 years ago
parent b345ae0c8f 2414deb624
commit f8d22632ec
3 changed files with 14 additions and 10 deletions

18
apps/portal/src/components/resumes/comments/ResumeCommentListItem.tsx
Unescape View File

@ -96,15 +96,17 @@ export default function ResumeCommentListItem({
<div className="flex flex-row space-x-1 pt-1 align-middle"> <div className="flex flex-row space-x-1 pt-1 align-middle">
<ResumeCommentVoteButtons commentId={comment.id} userId={userId} /> <ResumeCommentVoteButtons commentId={comment.id} userId={userId} />
{/* Action buttons; only present when not editing/replying */} {/* Action buttons; only present for authenticated user when not editing/replying */}
{isCommentOwner && !isEditingComment && !isReplyingComment && ( {userId && !isEditingComment && !isReplyingComment && (
<> <>
<button {isCommentOwner && (
className="px-1 text-xs text-indigo-800 hover:text-indigo-400" <button
type="button" className="px-1 text-xs text-indigo-800 hover:text-indigo-400"
onClick={() => setIsEditingComment(true)}> type="button"
Edit onClick={() => setIsEditingComment(true)}>
</button> Edit
</button>
)}
{!comment.parentId && ( {!comment.parentId && (
<button <button

2
apps/portal/src/pages/resumes/browse.tsx
Unescape View File

@ -361,7 +361,7 @@ export default function ResumeHomePage() {
</Transition.Root> </Transition.Root>
</div> </div>
<main className="h-[calc(100vh-4rem)] flex-1 overflow-y-scroll"> <main className="h-[calc(100vh-4rem)] flex-1 overflow-y-auto">
<div className="ml-4 py-4"> <div className="ml-4 py-4">
<ResumeReviewsTitle /> <ResumeReviewsTitle />
</div> </div>

4
apps/portal/src/pages/resumes/submit.tsx
Unescape View File

@ -80,6 +80,7 @@ export default function SubmitResumeForm({
const { data: session, status } = useSession(); const { data: session, status } = useSession();
const router = useRouter(); const router = useRouter();
const trpcContext = trpc.useContext();
const resumeUpsertMutation = trpc.useMutation('resumes.resume.user.upsert'); const resumeUpsertMutation = trpc.useMutation('resumes.resume.user.upsert');
const isNewForm = initFormDetails == null; const isNewForm = initFormDetails == null;
@ -170,6 +171,7 @@ export default function SubmitResumeForm({
}, },
onSuccess() { onSuccess() {
if (isNewForm) { if (isNewForm) {
trpcContext.invalidateQueries('resumes.resume.findAll');
router.push('/resumes/browse'); router.push('/resumes/browse');
} else { } else {
onClose(); onClose();
@ -228,7 +230,7 @@ export default function SubmitResumeForm({
<Head> <Head>
<title>Upload a Resume</title> <title>Upload a Resume</title>
</Head> </Head>
<main className="h-[calc(100vh-4rem)] flex-1 overflow-y-scroll"> <main className="h-[calc(100vh-4rem)] flex-1 overflow-y-auto">
<section <section
aria-labelledby="primary-heading" aria-labelledby="primary-heading"
className="flex h-full min-w-0 flex-1 flex-col lg:order-last"> className="flex h-full min-w-0 flex-1 flex-col lg:order-last">

Write Preview
Loading…
Cancel
Save