[questions][ui] Minor UI cleanup (#470)

* [questions][ui] fix no more questions overlap

* [questions][ui] remove redundent horizontal div

* [questions][ui] reduce gap

apps/portal/src/components/questions/ContributeQuestionDialog.tsx

@@ -35,13 +35,7 @@ export default function ContributeQuestionDialog({
   return (
     <div>
       <Transition.Root as={Fragment} show={show}>
-        <Dialog
+        <Dialog as="div" className="relative z-10" onClose={onCancel}>
-          as="div"
-          className="relative z-10"
-          onClose={() => {
-            // Todo: save state
-            onCancel();
-          }}>
           <Transition.Child
             as={Fragment}
             enter="ease-out duration-300"

apps/portal/src/components/questions/forms/ContributeQuestionForm.tsx

@@ -115,7 +115,6 @@ export default function ContributeQuestionForm({
           rows={5}
           {...register('questionContent')}
         />
-        <HorizontalDivider />
         <h2 className="text-md text-primary-800 font-semibold">
           Additional information
         </h2>

apps/portal/src/pages/questions/browse.tsx

@@ -486,7 +486,7 @@ export default function QuestionsBrowsePage() {
       <main className="flex flex-1 flex-col items-stretch">
         <div className="flex h-full flex-1">
           <section className="flex min-h-0 flex-1 flex-col items-center overflow-auto">
-            <div className="m-4 flex max-w-3xl flex-1 flex-col items-stretch justify-start gap-8">
+            <div className="m-4 flex max-w-3xl flex-1 flex-col items-stretch justify-start gap-6">
               <ContributeQuestionCard
                 onSubmit={(data) => {
                   const { cityId, countryId, stateId } = data.location;
@@ -502,6 +502,7 @@ export default function QuestionsBrowsePage() {
                   });
                 }}
               />
+              <div className="flex flex-col items-stretch gap-4">
                 <div className="sticky top-0 border-b border-slate-300 bg-slate-50 py-4">
                   <QuestionSearchBar
                     sortOrderValue={sortOrder}
@@ -548,7 +549,9 @@ export default function QuestionsBrowsePage() {
                         );
                       }),
                   )}
+                  {questionCount !== 0 && (
                     <PaginationLoadMoreButton query={questionsInfiniteQuery} />
+                  )}
                   {questionCount === 0 && (
                     <div className="flex w-full items-center justify-center gap-2 rounded-md border border-slate-300 bg-slate-200 p-4 text-slate-600">
                       <NoSymbolIcon className="h-6 w-6" />
@@ -558,6 +561,7 @@ export default function QuestionsBrowsePage() {
                   )}
                 </div>
               </div>
+            </div>
           </section>
           <aside className="hidden w-[300px] overflow-y-auto border-l bg-white py-4 lg:block">
             <h2 className="px-4 text-xl font-semibold">Filter by</h2>