[ui][button] Add rel and target properties to button (#505)

* [ui][button] Add rel and target properties to button

* [ui][fix] Remove undefined
pull/507/head
Ai Ling 2 years ago committed by GitHub
parent ed4b438d33
commit 39c96f86da
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -1,5 +1,6 @@
import clsx from 'clsx';
import Link from 'next/link';
import type { HTMLAttributeAnchorTarget } from 'react';
import type { UrlObject } from 'url';
import { Spinner } from '../';
@ -30,7 +31,9 @@ type Props = Readonly<{
isLoading?: boolean;
label: string;
onClick?: (event: React.MouseEvent<HTMLElement>) => void;
rel?: string;
size?: ButtonSize;
target?: HTMLAttributeAnchorTarget;
type?: ButtonType;
variant: ButtonVariant;
}>;
@ -115,6 +118,8 @@ export default function Button({
type = 'button',
variant,
onClick,
rel,
target,
}: Props) {
const iconSpacingClass = (() => {
if (!isLabelHidden && addonPosition === 'start') {
@ -166,6 +171,6 @@ export default function Button({
return (
// TODO: Allow passing in of Link component.
<Link href={href} {...commonProps} />
<Link href={href} rel={rel} target={target} {...commonProps} />
);
}

Loading…
Cancel
Save