svelte

Commit Graph

Author	SHA1	Message	Date
Paolo Ricciuti	e3ecd2a80b	Merge branch 'main' into failing-test-derived-fork	1 day ago
github-actions[bot]	3b4b0adcd5	Version Packages (#17178 ) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	2 days ago
Simon H	3604fdac6b	fix: avoid other batches running with queued root effects of main batch (#17145 ) * fix: avoid other batches running with queued root effects of main batch When `#traverse_effect_tree` runs, it can execute block effects, which in turn can create effects which are scheduled, which means `queued_root_effects` is now filled again. We didn't take that into account and assumed that in `#commit` we would have no queued root effects. As a result another batch could wrongfully run with the queued root effects of the main batch. That in turn can mean that `skipped_effects` is different on the other batch, leading to some branches not getting traversed into. As a result part of the tree is marked clean while further below batches are still not marked clean. That then breaks reactivity as soon as you schedule an effect in this still-not-clean sub tree, as it will not bubble all the way up to the root, since it comes across a not-clean branch, assuming something was already scheduled. The fix is simple: Stash the queued root effects before rebasing branches. Fixes #17118 * add note to self --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	2 days ago
Rich Harris	fe50e58f34	chore: fix types of binding.blocker (#17177 )	2 days ago
github-actions[bot]	b94289d23b	Version Packages (#17168 ) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	2 days ago
paoloricciuti	b671b6679e	fix: only set `derived.v` outside a fork	2 days ago
Simon H	99e670f632	fix: ensure eager effects don't break reactions chain (#17138 ) Execution of eager effects didn't set `is_updating_effect`, which meant the logic in `get` would wrongfully prevent dependencies being added to `reactions` of sources/deriveds. Fixes #17133	2 days ago
Simon H	a7a6d898d5	fix: correctly handle functions when determining async blockers (#17137 ) * fix: correctly handle functions when determining async blockers We didn't properly handle functions (function declarations/expressions/arrow functions) when calculating what is a blocker. More specifically - we did defer assignment of variable declarations even for arrow functions and function expressions, which is unnecessary and causes bugs when they're then referenced eagerly further below - we did not compute blockers for functions. They could reference blockers themselves, as such other code referencing them should wait on the related blockers Fixes #17129 * put into its own function * fix: take blockers into account when creating `#await` blocks The unrelated-but-in-the-same-issue-referenced-bug * oops * fix * minimize compiled output changes * no idea why editor showed these as unused	2 days ago
Rich Harris	e0501ede03	chore: only skip effects when deferring (#17169 ) * chore: only skip effects when deferring * more	2 days ago
Simon H	686720070b	fix: keep deriveds reactive after their original parent effect was destroyed (#17171 ) Use case: Remote queries that are created on one screen, then are used again on another screen. Original parent effect is destroyed in that case but derived should still be reactive. It wasn't prior to this fix because inside `get` the `destroyed` variable would be true and so deps would not properly be recorded. Fixes https://github.com/sveltejs/kit/issues/14814	2 days ago
Simon H	7fd2d8660f	fix: parallelize async `@const`s in the template (#17165 ) * fix: parallelize async `@const`s in the template This fixes #17075 by solving the TODO of #17038 to add out of order rendering for async `@const` declarations in the template. It's implemented by a new field on the component state which is set as soon as we come across an async const. All async const declarations and those after it will be added to that field, and the existing blockers mechanism is then used to line up the async work correctly. After processing a fragment a `run` command is created from the collected consts. * fix * tweak --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	2 days ago
paoloricciuti	abf408b4ab	fix: skip no async	2 days ago
paoloricciuti	4eea2b01dd	fix: don't set derived values during time travel	2 days ago
paoloricciuti	fc6aedd14e	chore: failing test for derived + fork + block	3 days ago
github-actions[bot]	b9c7e45408	Version Packages (#17161 ) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	3 days ago
Rich Harris	c02ad03bfd	fix: overhaul `each` blocks (#17150 ) * state.items -> state.onscreen * offscreen_items -> state.offscreen * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * always push * fix * note to self * tweak/fix * tidy up * simplify * unused * clarity * note to self * simplify * one test to go * holy shit i think it works * unused * reduce number of bitwise checks * revert * small tweak * better comment * update note to self * fix: each block losing reactivity when items removed while promise pending (#17151) Co-authored-by: dylan <dylanbradshaw107@hotmail.com> Co-authored-by: Rich Harris <rich.harris@vercel.com> * add commented-out test, todo investigate --------- Co-authored-by: dylan1951 <58990501+dylan1951@users.noreply.github.com> Co-authored-by: dylan <dylanbradshaw107@hotmail.com> Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>	3 days ago
github-actions[bot]	1e0c8c544c	Version Packages (#17159 ) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	4 days ago
Simon H	6e571dc909	fix: ensure deferred effects can be rescheduled later on (#17147 ) When deferring effects we didn't unmark the deriveds that lead to those effects. This means that they might not be reached in subsequent runs of `mark_reactions`. Fixes https://github.com/sveltejs/svelte/issues/17118#issuecomment-3521488865	4 days ago
Simon H	a7a7d1e014	fix: take blockers of components into account (#17153 ) Fixes #17122	4 days ago
Simon H	a0c7c3b327	fix: properly defer document title until async work is complete (#17158 ) #17061 didn't properly handle the case where the title is sync but reactive and async work outside is pending. Handle this by creating a proper effect for the document title, and make sure to wait on it and flush it once ready. Fixes #17114	4 days ago
github-actions[bot]	e238e6611e	Version Packages (#17135 ) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	1 week ago
Simon H	14b0926008	fix: don't deactivate other batches (#17132 ) There's a possibility of a race condition where `batch.deactivate()` is called while `current_batch !== batch`, and so it would deactivate another batch, which can lead to zombie batches that are never flushed, subsequently leading to wrong `batch_values`. This fixes that by checking if the current batch is the own batch. Fixes #17109	1 week ago
github-actions[bot]	554202ecf4	Version Packages (#17127 ) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	2 weeks ago
Simon H	68d4f9c3b6	fix: wait on dependencies of async bindings (#17120 ) * fix: wait on dependencies of async bindings Correctly takes into account blockers for bindings. Also ensures it works for functional bindings. During that I also noticed a bug in our `nodes_end` assignment logic, which the added test also regresses against. Fixes #17092 Fixes #17090 * ensure async static props/attributes are awaited * wait on blockers in binding validation * await dependencies of style directives * tidy	2 weeks ago
github-actions[bot]	3a4dc7d83d	Version Packages (#17119 ) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	2 weeks ago
Rich Harris	46e9d2d357	chore: remove `UNOWNED` flag (#17105 ) Fixes #17024 Fixes #17049 (comment) (and therefore everything that was still buggy in that issue I think) * chore: remove unowned check when calling `e.effect_in_unowned_derived` * WIP * all non-unit tests passing * tidy * WIP * WIP * WIP * note to self * fix * fix * hmm maybe not * try this * simplify * remove skip_reaction * docs * add changeset, in case this results in changed behaviour * Update packages/svelte/src/internal/client/reactivity/effects.js Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> * fix #17024 * fix comment * revert * fix * dry * changeset * fix WAS_MARKED logic * failing test (that uncovered other unrelated bug) + fix * fix: delete from batch_values on updates (#17115) * fix: delete from batch_values on updates This fixes a bug where a derived would still show its old value even after it was indirectly updated again within the same batch. This can for example happen by reading a derived on an effect, then writing to a source in that same effect that makes the derived update, and then read the derived value in a sibling effect - it still shows the old value without the fix. The fix is to _delete_ the value from batch_values, as it's now the newest value across all batches. In order to not prevent breakage on other batches we have to leave the status of deriveds as-is, i.e. within is_dirty and update_derived we cannot update its status. That might be a bit more inefficient as you now have to traverse the graph for each `get` of that derived (it's a bit like they are all disconnected) but we can always optimize that later if need be. Another advantage of this fix is that we can get rid of duplicate logic we had to add about unmarking and reconnecting deriveds, because that logic was only needed for the case where deriveds are read after they are updated, which now no longer hits that if-branch * keep derived cache, but clear it in mark_reactions (#17116) --------- Co-authored-by: Rich Harris <rich.harris@vercel.com> Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>	2 weeks ago
github-actions[bot]	7a2435471c	Version Packages (#17087 ) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	2 weeks ago
Simon H	eea8a18cf2	fix: ensure fork always accesses correct values (#17098 ) Not all batches will flush right after being activated, some will be activated and then `get` is called on a signal. In that case the value was wrong because we did not apply the changes of that batch. By doing `this.apply()` during `activate()` we ensure we do, which fixes (among other things, likely) a forking bug where old values where sneaking in. Fixes #17079	2 weeks ago
7nik	b7625fd42c	fix: do not spread non-enumerable symbols (#17097 )	2 weeks ago
Rich Harris	8ebbb3c7bc	fix: preserve symbols when creating derived rest properties (#17096 ) fixes #17094	3 weeks ago
Simon H	0e709e3fec	fix: change title only after any pending work has completed (#17061 ) * fix: change title only after any pending work has completed We have to use an effect - not a render effect - for updating the title, and always. That way we change the title only after any pending work has completed. Fixes #17060 * fix	3 weeks ago
github-actions[bot]	723c421fbb	Version Packages (#17078 ) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	3 weeks ago
Rich Harris	a791e9178b	fix: treat each blocks with async dependencies as uncontrolled (#17077 )	3 weeks ago
github-actions[bot]	8ebc3b1337	Version Packages (#17076 ) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	3 weeks ago
Simon H	9477f18b77	fix: transform `$bindable` after `await` expressions (#17066 ) Fixes #17064	3 weeks ago
github-actions[bot]	70d020bd91	Version Packages (#17055 ) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	3 weeks ago
Alejandro Torres	83746adcf7	Fix spelling in code comments (#17059 )	3 weeks ago
Rich Harris	1126ef3186	feat: out of order rendering (#17038 ) * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * revert * note to self * unused * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * deprecate * update tests * lint * lint * WIP * WIP * fix * WIP * unused * deopt to ensure state is ready * fix * DRY * reduce diff * reduce diff * reduce diff * handle blocked attributes * WIP * pre-transform * tidy up * fix * WIP * WIP * fix: handle `<svelte:head>` rendered asynchronously * fix tests * fix * delay resolve * Revert "fix" This reverts commit `2e56cd7575`. * add error * simplify/fix hydration restoration * fix * use $state.eager mechanism for $effect.pending - way simpler and more robust * disable these warnings for now, too many false positives * fix * changeset was already merged * changeset * oops * lint * docs + tidy * prettier * robustify: logic inside memoizer and outside could get out of sync, introducing bugs. use equality comparison instead * oops * uncomment * use finally * use is_async --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>	3 weeks ago
Rich Harris	90a8a03988	fix: settle batch after DOM updates (#17054 )	3 weeks ago
github-actions[bot]	1b2f7b068e	Version Packages (#17053 ) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	3 weeks ago
Simon H	d2f453f8b0	fix: don't restore batch in `#await` (#17051 ) #16977 had one slight regression which might contribute to #16990: The batch from earlier was restored, but that doesn't make sense in this situations since this has nothing to do with our new async logic of batches suspending until pending work is done. As a result you could end up with a batch being created, and then the restore then instead reverting to an earlier batch that was already done, which means a ghost-batch ends up in the set of batches, subsequently triggering time traveling when it shouldn't. This may help with #16990 No test because basically impossible to do so	3 weeks ago
Rich Harris	cc0143c904	fix: handle `<svelte:head>` rendered asynchronously (#17052 ) * fix: handle `<svelte:head>` rendered asynchronously * fix tests	3 weeks ago
github-actions[bot]	da00abe116	Version Packages (#17037 ) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	4 weeks ago
Rich Harris	b5e23a6d13	chore: tweak memoizer logic (#17042 )	4 weeks ago
Rich Harris	fc181cf611	chore: move `$effect` visitors (#17041 )	4 weeks ago
Rich Harris	9096680c2e	chore: use ESTree namespace imports (#17040 )	4 weeks ago
Rich Harris	b01647455c	chore: create_expression_metadata -> ExpressionMetadata (#17039 ) * chore: create_expression_metadata -> ExpressionMetadata * err whatever	4 weeks ago
Paolo Ricciuti	8368a4beb9	fix: better error message for global variable assignments (#17036 )	4 weeks ago
github-actions[bot]	e33f774877	Version Packages (#17035 ) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	4 weeks ago
Rich Harris	657ec89caa	fix: ignore fork `discard()` after `commit()` (#17034 ) * fix: ignore fork `discard()` after `commit()` * fix message	4 weeks ago

1 2 3 4 5 ...

10720 Commits (e3ecd2a80b1156b7afa7fed0581ce5c38ae5501a) All Branches Search

10720 Commits (e3ecd2a80b1156b7afa7fed0581ce5c38ae5501a)

All Branches