svelte

Commit Graph

Author	SHA1	Message	Date
paoloricciuti	df42e4babd	fix: add validations for `svelte:dom` elements	3 months ago
paoloricciuti	098cdebe95	fix: disallow css injected with custom renderer	3 months ago
paoloricciuti	100fbbf05f	fix: conditional invocation	3 months ago
paoloricciuti	c189bdcfe3	chore: make option accept a function	3 months ago
paoloricciuti	b4cf3d0a71	chore: move option under experimental	3 months ago
paoloricciuti	f91c2fd6d8	fix: use operations functions everywhere	3 months ago
paoloricciuti	ff5e835bf0	fix: handle autofocus and muted	3 months ago
paoloricciuti	2dc8fd19a3	chore: add full object in output	3 months ago
paoloricciuti	a0d0f013da	fix: un-special case customizable-select	4 months ago
paoloricciuti	6830052254	fix: style and class special case	4 months ago
paoloricciuti	37bd61d3f1	fix: attributes dom access	4 months ago
paoloricciuti	7dca98564a	chore: add each reactive and key tests	4 months ago
paoloricciuti	5456125bab	Merge remote-tracking branch 'origin/main' into svelte-custom-renderer	4 months ago
paoloricciuti	beddf45690	chore: render into a fragment in tests	4 months ago
paoloricciuti	0f44733183	chore: boundary test	4 months ago
paoloricciuti	f828ea3c6a	chore: better test renderer	4 months ago
paoloricciuti	e86da84c79	fix: handle compiled `nodeValue`/`textContent`	4 months ago
paoloricciuti	ecffd81c22	fix: types	4 months ago
paoloricciuti	49cff549c7	chore: initial test suite	4 months ago
paoloricciuti	bd70ab621c	fix: events dom access	4 months ago
paoloricciuti	cf874c0ab9	fix: generate types	4 months ago
paoloricciuti	c459824a88	fix: don't clone node if a renderer is available	4 months ago
paoloricciuti	9ae3faa09a	chore: centralize methods in `operations.js`	4 months ago
paoloricciuti	432c0235c9	fix: push and pop renderer when needed	4 months ago
paoloricciuti	a59efbf610	fix: wrap component in boundary in `render`	4 months ago
github-actions[bot]	37ab33c0a3	Version Packages (#18006 ) This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## svelte@5.55.1 ### Patch Changes - fix: correctly handle bindings on the server ([#18009](https://github.com/sveltejs/svelte/pull/18009)) - fix: prevent hydration error on async `{@html ...}` ([#17999](https://github.com/sveltejs/svelte/pull/17999)) - fix: cleanup `superTypeParameters` in `ClassDeclarations`/`ClassExpression` ([#18015](https://github.com/sveltejs/svelte/pull/18015)) - fix: improve duplicate module import error message ([#18016](https://github.com/sveltejs/svelte/pull/18016)) - fix: reschedule new effects in prior batches ([#18021](https://github.com/sveltejs/svelte/pull/18021)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	4 months ago
Rohit Nair P	4879f9da99	fix: improve duplicate module import error message (#18016 ) ## Description While investigating the compiler analysis phase for errors or missing lines, I located an explicit `TODO fix the message here` comment in the source code (`packages/svelte/src/compiler/phases/2-analyze/visitors/shared/utils.js`). ### Triggering Code ```svelte <script module> import { foo } from './somewhere.js'; </script> <script> let foo = 'conflict'; // Triggers the duplicate module import error </script> ``` ## The Bug When a component author creates a local `let` declaration in the instance `<script>` block that shadows a variable imported in the `<script module>` block, the compiler emits a `declaration_duplicate_module_import` error. However, the error message text was misleading. It stated: ```diff - Cannot declare a variable with the same name as an import inside `<script module>` + Cannot declare a variable with the same name as an import from `<script module>` ``` This incorrectly implies that the duplicate declaration itself is happening inside the module script block, rather than colliding with an import from that block. ## Changes Made \| Action \| Target (File / Function) \| Description \| \| :--- \| :--- \| :--- \| \| Template Fix \| `packages/svelte/messages/compile-errors/script.md` \| Changed "inside" to "from" to accurately reflect the nature of the shadow collision. \| \| Regenerated Errors \| `packages/svelte/src/compiler/errors.js` \| Ran `pnpm generate` to apply the updated markdown template into the dictionary list. \| \| Removed TODO \| `ensure_no_module_import_conflict` function \| Removed the original `// TODO fix the message here` notation from the validator. \| \| Test Adjustments \| `illegal-variable-declaration/errors.json` \| Updated the validator test suite snapshots to assert against the correct error message format. \| ## Validation Results * The error correctly throws when a user replicates this component structure. * Vitest suite `tests/validator/test.ts` successfully asserts the new, clearer message. --- ### Before submitting the PR, please make sure you do the following - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`. - [x] This message body should clearly illustrate what problems it solves. - [x] Ideally, include a test that fails without this PR but passes with it. - [x] If this PR changes code within `packages/svelte/src`, add a changeset (`npx changeset`). ### Tests and linting - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint` # THANK YOU	4 months ago
Simon H	04eadbc8a9	fix: correctly handle bindings on the server (#18009 ) `item.subsume(item)` did nothing, honestly kinda weird how this only turned up now Fixes #17981	4 months ago
Paolo Ricciuti	957f2755fa	fix: cleanup `superTypeParameters` in `ClassDeclarations`/`ClassExpression` (#18015 ) Closes #18012 We were removing `superTypeArguments` but the AST showed `superTypeParameters`. Luckily, I was able to pinpoint `esrap@2.2.4` as the cause... I've only bumped `esrap` and that made the test fail (so that I could fix it) And of course it was that...there's literally a commit that explicitly print them lol `f9137c4101`	4 months ago
paoloricciuti	6d13e5a1d0	fix: store current renderer in effect and push it before executing it	4 months ago
paoloricciuti	4eb2c0bd80	fix: import correctly	4 months ago
paoloricciuti	0a0212c86e	chore: new operations functions to replace direct DOM access	4 months ago
paoloricciuti	ac40179686	chore: remove getter	4 months ago
paoloricciuti	101d1cebdc	chore: better types and more complete interface	4 months ago
Simon H	a9d8439ad1	fix: reschedule new effects in prior batches (#18021 ) If a batch creates a new branch (e.g. through an if block becoming true) the previous batches so far do not know about the new effects created through that. This can lead to stale values being shown. We therefore schedule those new effects on prior batches if they are touched by a `current` value of that batch Fixes #17099 extracted from #17971	4 months ago
paoloricciuti	2145510951	Merge remote-tracking branch 'origin/main' into svelte-custom-renderer	4 months ago
paoloricciuti	23e52db4e0	chore: better types	4 months ago
Simon H	669f6b45a3	fix: prevent hydration error on async `{@html ...}` (#17999 ) Fixes #17981	4 months ago
Rich Harris	54ba176d2c	docs: 'open in playground' links (#17983 ) This takes advantage of https://github.com/sveltejs/svelte.dev/pull/1879 and https://github.com/sveltejs/svelte.dev/pull/1880 to replace some of the hardcoded playground links in the docs with ones that are generated automatically from the code. This is a better user experience, and easier to maintain. Not every playground link is suitable for replacement, as in many cases we gloss over implementation details. For now I'm just starting with some easy ones	4 months ago
Simon H	5e8662fb23	chore: lots of async tests (#17997 ) extracting this from #17971 because even if that PR is not merged these tests show that there's still a lot of cases where we're buggy, particularly around forking and new branches	4 months ago
github-actions[bot]	6e52f40d41	Version Packages (#17984 ) This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## svelte@5.55.0 ### Minor Changes - feat: export TweenOptions, SpringOptions, SpringUpdateOptions and Updater from svelte/motion ([#17967](https://github.com/sveltejs/svelte/pull/17967)) ### Patch Changes - fix: ensure HMR wrapper forwards correct start/end nodes to active effect ([#17985](https://github.com/sveltejs/svelte/pull/17985)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	4 months ago
Simon H	1773cb5b59	fix: ensure HMR wrapper forwards correct start/end nodes to active effect (#17985 ) Fixes #17982 (two issues reported there) Adding the start/end statically at the end once does not work because it's going to be stale when there's a HMR reload of the wrapped component. For reasons not completely clear to me it also fails in another case. So instead of wrapping the HMR with comments we just forward the nodes of the inner effect to the outer active effect, pretending the wrapper isn't there from a "remove dom nodes"-perspective.	4 months ago
Razin Shafayet	b90a5dfb61	docs: clarify `$derived` `await` behavior and dependency tracking (#17696 ) Closes #17660 ### Before submitting the PR, please make sure you do the following - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`. - [x] This message body should clearly illustrate what problems it solves. - [ ] Ideally, include a test that fails without this PR but passes with it. - [ ] If this PR changes code within `packages/svelte/src`, add a changeset (`npx changeset`). ### Tests and linting - [ ] Run the tests with `pnpm test` and lint the project with `pnpm lint` --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	4 months ago
moaaz	a94924b677	fix: export TweenOptions, SpringOptions, SpringUpdateOptions and Updater from svelte/motion (#17967 ) Exports `TweenedOptions`, `SpringOpts`, `SpringUpdateOpts`, and `Updater` from `svelte/motion`. These types are required for the public method signatures of `spring` and `tweened` (e.g., as parameters for `.set()` and `.update()`). This PR makes them accessible to TypeScript users, following the established pattern in modules like `svelte/store` and `svelte/transition`. Internal implementation details like `TickContext` remain private as they do not appear in any public-facing signatures. Fixes #16151 ### Before submitting the PR, please make sure you do the following - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`. - [x] This message body should clearly illustrate what problems it solves. - [x] Ideally, include a test that fails without this PR but passes with it. - [x] If this PR changes code within `packages/svelte/src`, add a changeset (`npx changeset`). ### Tests and linting - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint` --------- Co-authored-by: Rich Harris <rich.harris@vercel.com> Co-authored-by: Rich Harris <hello@rich-harris.dev>	4 months ago
吴杨帆	0c669d9bc9	docs: recommend createContext as the primary method for context (#17959 ) ### Before submitting the PR, please make sure you do the following - [ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [ ] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`. - [ ] This message body should clearly illustrate what problems it solves. - [ ] Ideally, include a test that fails without this PR but passes with it. - [ ] If this PR changes code within `packages/svelte/src`, add a changeset (`npx changeset`). ### Tests and linting - [ ] Run the tests with `pnpm test` and lint the project with `pnpm lint` --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	4 months ago
github-actions[bot]	db69b7e345	Version Packages (#17965 ) This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## svelte@5.54.1 ### Patch Changes - fix: hydration comments during hmr ([#17975](https://github.com/sveltejs/svelte/pull/17975)) - fix: null out `effect.b` in `destroy_effect` ([#17980](https://github.com/sveltejs/svelte/pull/17980)) - fix: group sync statements ([#17977](https://github.com/sveltejs/svelte/pull/17977)) - fix: defer batch resolution until earlier intersecting batches have committed ([#17162](https://github.com/sveltejs/svelte/pull/17162)) - fix: properly invoke `iterator.return()` during reactivity loss check ([#17966](https://github.com/sveltejs/svelte/pull/17966)) - fix: remove trailing semicolon from {@const} tag printer ([#17962](https://github.com/sveltejs/svelte/pull/17962)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	4 months ago
Abishek Raj R R	7123bf3a13	fix: remove trailing semicolon from {@const} tag printer (#17962 ) Fixes #17720 ## Problem The `{@const}` tag was being printed with a trailing semicolon, producing invalid Svelte syntax like: {@const a = 1;} This happened because the `ConstTag` visitor in the printer was delegating to esrap's `VariableDeclaration` handler, which always appends a semicolon (correct for JS, but wrong for Svelte template syntax). ## Solution Instead of delegating to `VariableDeclaration`, the `ConstTag` visitor now manually prints the tag by: - Writing `{@const ` directly - Iterating through declarators and visiting each one - Separating multiple declarations with commas - Closing with `}` — no trailing semicolon ## Before {@const a = 1;} {@const a = 1, b = 2;} ## After {@const a = 1} {@const a = 1, b = 2} ## Changes - `packages/svelte/src/compiler/print/index.js` — fixed `ConstTag` visitor - `packages/svelte/tests/print/samples/const-tag/output.svelte` — updated expected test output --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Rich Harris <hello@rich-harris.dev> Co-authored-by: Rich Harris <rich.harris@vercel.com>	4 months ago
Nitin Sahu	8e4de9b145	fix: null out effect.b in destroy_effect to prevent memory leak (#17980 ) ## Fix: #17881 ### Root Cause When a dynamic component switches (e.g. `<Component />`), branch effects are destroyed via `destroy_effect()`. However, the `effect.b` (Boundary reference) field was not cleared alongside other references (`next`, `prev`, `ctx`, `deps`, `fn`, `nodes`, `ac`). As a result, destroyed effects retained a reference to the `Boundary` instance, which holds references to component state and child effects. This prevented destroyed component subtrees from being garbage collected, causing memory usage to grow during repeated component switching. ### Solution Clear the boundary reference during effect destruction. ```diff effect.next = effect.prev = effect.teardown = effect.ctx = effect.deps = effect.fn = effect.nodes = effect.ac = + effect.b = null; ``` ### Test Plan * All existing tests pass: * runtime-runes: 2,459 * runtime-legacy: 3,294 * signals: 96 * Total: 5,849 tests * Added a dynamic component switching test that toggles components repeatedly and verifies correct DOM output. ### Validation Reproduced the issue using the example from #17881. After applying the fix: * Memory usage stabilizes during repeated component switching * Destroyed components are properly reclaimed by the garbage collector * No behavioral regressions observed ### Impact * Fixes memory leak in dynamic component switching * Minimal, safe change * No API or behavior changes --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	4 months ago
Simon H	6b33dd2a1e	fix: group sync statements (#17977 ) We were just putting each statement into its own promise. Besides this being bad for perf, it also introduces subtle timing issues - the execution order of the code could change in bad ways. Fixes #17940	4 months ago
Paolo Ricciuti	425fba33fe	fix: hydration comments during hmr (#17975 ) Closes #17972 Claude found this fix I had a look and I think it makes sense (we are injecting a new comment which messes up the marching during hydration). I'm slightly confused why this only applied to `css_props` but I guess that's because there's an "hidden" element there which makes it special. I don't super-like the `if` situation, but I guess it is what it is. Also the test was using `hmr` without `dev` and this brought to my attention that we were just assuming components return something while it's not the case...I guess it doesn't really matter unless you are using `hmr` in prod which is not a thing but fixing this is simple so we might just as well doing it	4 months ago

1 2 3 4 5 ...

11133 Commits (df42e4babd326dfff382d59f6afdfbec1aef9cf9) All Branches Search

11133 Commits (df42e4babd326dfff382d59f6afdfbec1aef9cf9)

All Branches