svelte

Commit Graph

Author	SHA1	Message	Date
paoloricciuti	bf7a4e6883	chore: pass renderer in test mount	2 months ago
paoloricciuti	131709236c	fix: pass parent renderer in `mount`	2 months ago
paoloricciuti	7a2bcd7895	Merge remote-tracking branch 'origin/svelte-custom-renderer' into fix-interleaving	2 months ago
Paolo Ricciuti	4116e9f25e	Merge branch 'main' into svelte-custom-renderer	2 months ago
Rich Harris	2084125c0f	Unified `mount` API for components with custom renderers (#18317 ) Targets #18042. Am opening this so I can start a discussion over on that PR (https://github.com/sveltejs/svelte/pull/18042#issuecomment-4567867958) --------- Co-authored-by: paoloricciuti <ricciutipaolo@gmail.com>	2 months ago
paoloricciuti	3bf1037afe	fix: types in renderers tests	2 months ago
paoloricciuti	6ce5481b4e	fix: hydrate types	2 months ago
paoloricciuti	13348cb5d5	fix: prettier	2 months ago
paoloricciuti	8db65afbce	chore: add tests	2 months ago
paoloricciuti	b63accbb03	chore: regenerate types	2 months ago
paoloricciuti	f79f84acec	chore: add ability to hydrate dom custom renderers samples	2 months ago
paoloricciuti	372421ec16	fix: update test renderer to output actual dom nodes when interleaving	2 months ago
paoloricciuti	a4f0ce17ce	feat: accept `foreign` object in custom renderer to determine how to interleave custom renderers	2 months ago
paoloricciuti	030c665a6f	fix: store `segments` and use them to remove nodes when interleaving is happening	2 months ago
paoloricciuti	fe31c69943	chore: create error for missing foreign	2 months ago
paoloricciuti	235fb213cb	fix: push renderer before executing a snippet	2 months ago
paoloricciuti	36ccbe289e	fix: wrap implicit children snippets in `renderer_snippet`	2 months ago
paoloricciuti	2945f67653	fix: set null renderer for snippets created by DOM components	2 months ago
paoloricciuti	4accea6377	fix: make sure pop renderer is always before `return`	2 months ago
paoloricciuti	9489461319	fix: always validate snippets if custom renderer is enabled	2 months ago
github-actions[bot]	a9f48540e2	Version Packages (#18389 ) This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## svelte@5.56.3 ### Patch Changes - fix: ignore errors that occur in destroyed effects ([#18384](https://github.com/sveltejs/svelte/pull/18384)) - fix: type BigInts in `$state.snapshot(...)` return values ([#18388](https://github.com/sveltejs/svelte/pull/18388)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	2 months ago
sijie-Z	71a6515bd6	fix: check boundary exists before calling error handler in async derived (#18384 ) fixes #18383 I traced the issue to `packages/svelte/src/internal/client/error-handling.js`, specifically the `invoke_error_boundary` function. The problem is at line 56 where `effect.b.error(error)` is called without checking if `effect.b` exists. What happens is: when an async `$derived` rejects inside a `<svelte:boundary>`, the error is handled correctly the first time. But if the boundary is destroyed before the rejection fully settles (e.g. component unmounts), a subsequent settle tries to call `effect.b.error()` on a destroyed boundary where `effect.b` is `null`, causing a `TypeError`. The fix adds a null check for `effect.b` before calling `error()`. If the boundary has been destroyed, we skip it and continue bubbling up to the parent boundary. This way the error still gets handled properly instead of crashing. This could also be tested by creating a component with an async `$derived` that rejects after the component unmounts, but I wanted to get the fix up first for review. --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	2 months ago
sijie-Z	3d83c9abe6	fix: add bigint to Primitive type for $state.snapshot (#18388 ) Fixes #18385 ## Problem `$state.snapshot` infers BigInt properties as `never` because `bigint` is missing from the `Primitive` type definition. BigInt is a valid JavaScript primitive and is supported by `structuredClone`. ## Solution Added `bigint` to the `Primitive` type in both `packages/svelte/src/ambient.d.ts` and `packages/svelte/types/index.d.ts`. ## Before ```ts const object = $state({ number: 1n }); const snapshot = $state.snapshot(object); // snapshot.number is inferred as never ❌ After const object = $state({ number: 1n }); const snapshot = $state.snapshot(object); // snapshot.number is correctly inferred as bigint ✅ Tests and linting - [x] This is a type-only change, no runtime behavior affected --------- Co-authored-by: Rich Harris <hello@rich-harris.dev>	2 months ago
paoloricciuti	3eb795c80f	fix: store and restore parent renderer in effect	2 months ago
github-actions[bot]	51baf1c1af	Version Packages (#18357 ) This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## svelte@5.56.2 ### Patch Changes - fix: properly track effect end node for async sibling component ([#18371](https://github.com/sveltejs/svelte/pull/18371)) - fix: prevent false-positive reactivity loss warning ([#18373](https://github.com/sveltejs/svelte/pull/18373)) - chore: bump esrap dependency ([#18372](https://github.com/sveltejs/svelte/pull/18372)) - fix: ignore declaration tags for animation directive ([#18366](https://github.com/sveltejs/svelte/pull/18366)) - fix: reject pending async deriveds on discard ([#18308](https://github.com/sveltejs/svelte/pull/18308)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	2 months ago
paoloricciuti	7e58da3433	fix: skip single node optimization in custom renderer	2 months ago
Paolo Ricciuti	f915aa39cf	Merge branch 'main' into svelte-custom-renderer	2 months ago
paoloricciuti	cd5e2ee6a5	fix: wrap implicit children into `renderer_snippet`	2 months ago
Simon H	3d5c4ab620	fix: prevent false-positive reactivity loss warning (#18373 ) By checking that current/previous batch are null we filter out false positives. `reactivity_loss_tracker` is only reset after a microtask, so if a flush happens before that, we get warnings for things we shouldn't warn on. Fixes #18370 --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	2 months ago
Simon H	bdb1a0f847	fix: ensure async block assigns correct nodes to effect (#18371 ) If a block has a sole component child, we apply an optimization to not need a template. But if that sole child is wrapped in `$.async`, it can happens that the block's effect is assigned the wrong end node. In the reproduction this happens because we have two components inside a Child which is rendered only after an async block resolves. In `$.append` we have logic to not reassign nodes when the active effect didn't already run, which it has by the time we come across it (because the async work had to resolve first; we added this in https://github.com/sveltejs/svelte/pull/17120 to prevent the opposite, nodes being "rewinded" to an earlier position) and so the second sibling component's `$.append` will not set its end node to the effect. As a result the end node is wrong (too early). To fix this we assign the nodes in `$.async`. We could also use `compareDocumentPosition` in `$.append` to only ever go forward, but that feels a bit heavier performance-wise. --------- Co-authored-by: paoloricciuti <ricciutipaolo@gmail.com> Co-authored-by: Rich Harris <rich.harris@vercel.com>	2 months ago
Simon H	e4bfc5f45a	chore: bump esrap dependency (#18372 ) Avoid installing the broken 2.2.10 version Closes #18369	2 months ago
paoloricciuti	ee2f74ebf3	fix: lint	2 months ago
paoloricciuti	0490721eef	fix: lint and check	2 months ago
Paolo Ricciuti	114be1c593	Merge branch 'main' into svelte-custom-renderer	2 months ago
Paolo Ricciuti	56856f0b10	fix: `customRenderer` as a global option and remove `without_renderer` (#18359 ) Co-authored-by: Rich Harris <rich.harris@vercel.com> Co-authored-by: Rich Harris <hello@rich-harris.dev>	2 months ago
Minh Lê	94bd27953e	docs: fix invalid `rows` CSS property in {#each} chess-board example (#18367 ) ## Problem The `{#each}` docs page has a runnable "chess board" example whose `<style>` block uses an invalid CSS property: ```css .chess-board { display: grid; grid-template-columns: repeat(8, 1fr); rows: repeat(8, 1fr); /* ← not a real CSS property */ ... } ``` There is no `rows` shorthand or longhand in CSS, so this line is silently dropped by every browser. The example clearly intends an 8×8 grid (note the matching `grid-template-columns` line directly above). ## Fix `rows` → `grid-template-rows`. One line, in `documentation/docs/03-template-syntax/03-each.md`. No prose changes.	2 months ago
Simon H	1b4c43b8e5	fix: ignore declaration tags for animation directive (#18366 ) Fixes #18365	2 months ago
Mathias Picker	85dcb91f7c	chore: upgrade to vitest v4 (#18265 ) ## Summary Bumps `vitest` and `@vitest/coverage-v8` from `^2.1.9` to `^4.1.7` (two major versions). Three small test-harness updates compensate for vitest 4 behavior changes; all 7569 tests still pass. - `packages/svelte/tests/runtime-browser/test.ts` — vitest 4 removed the deprecated `describe(name, fn, opts)` signature. Pass options as the second argument. - `packages/svelte/tests/runtime-legacy/shared.ts` — vitest 4's jsdom env binds `virtualConsole` to the original `globalThis.console` reference before vitest wraps the console, so inline-`<script>` logs and `jsdomError` events no longer reach per-test `console.{log,error}` overrides. Restore vitest 2's behavior by re-routing the virtual console through the live `console` in `beforeAll`. Also promote the window-error listener to a named function and remove it in `finally` — previously leaked listeners from earlier tests kept writing to module-level `unhandled_rejection`, polluting later tests. - `vitest.config.js` — bump `testTimeout` to 10s. The 5s default trips a handful of dev-mode tests that exercise `effect_update_depth_exceeded`, whose ~1000 Error-stack captures per flush are slower under vitest 4's deeper async stacks. ## Test plan - [x] `pnpm test` — 7569 passed, 63 skipped, 0 failed --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Co-authored-by: Rich Harris <rich.harris@vercel.com>	2 months ago
Simon H	a81f96549d	fix: reject pending async deriveds on discard (#18308 ) The rejects all async deriveds of a batch as `OBSOLETE`, so they don't hang around and bail early without triggering the batch. If we don't do this, an async derived can trigger the already done batch, which schedules an effect that is never flushed. Because it is never flushed the branches it touched on its way up are never cleared, and so anything else in that subtree is now unreactive.	2 months ago
github-actions[bot]	3ef761b87b	Version Packages (#18346 ) This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## svelte@5.56.1 ### Patch Changes - fix: error at compile time on duplicate snippet/declaration tag definitions ([#18351](https://github.com/sveltejs/svelte/pull/18351)) - fix: parse declaration tag contents more robustly ([#18353](https://github.com/sveltejs/svelte/pull/18353)) - fix: correctly transform references to earlier declarators in a declaration tag (e.g. `{let a = $state(0), b = $derived(a * 2)}`) ([#18348](https://github.com/sveltejs/svelte/pull/18348)) - fix: avoid spurious `state_referenced_locally` warnings for `$derived` declarations in declaration tags ([#18348](https://github.com/sveltejs/svelte/pull/18348)) - fix: tolerate whitespace before `let`/`const` in declaration tags ([#18348](https://github.com/sveltejs/svelte/pull/18348)) - fix: prevent infinite loop when a tag's expression ends with a trailing `/` at the end of the input ([#18350](https://github.com/sveltejs/svelte/pull/18350)) - fix: more robust parsing of declaration tags with regards to `type` ([#18330](https://github.com/sveltejs/svelte/pull/18330)) - fix: preserve newlines in spread input values when the `type` attribute is applied after `value` ([#18345](https://github.com/sveltejs/svelte/pull/18345)) - fix: update `SvelteURLSearchParams` when setting duplicate keys to the same joined value ([#18336](https://github.com/sveltejs/svelte/pull/18336)) - fix: check references for blockers on server, too ([#18352](https://github.com/sveltejs/svelte/pull/18352)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	2 months ago
Simon H	5b8db1be35	fix: error at compile time on duplicate snippet/declaration tag definitions (#18351 )	2 months ago
Simon H	56013a2c01	fix: check references for blockers on server, too (#18352 ) We forgot the server in #18309 Fixes #18344	2 months ago
hjaber	2afb895ffa	fix: parse declaration tags with a division operator in the initializer (#18353 ) Mimic what `parseExpressionAt` does --------- Co-authored-by: hjaber <hjaber@users.noreply.github.com> Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>	2 months ago
paoloricciuti	e5beb7297d	fix: push renderer in effects even if it's `null` This is needed because effects record the renderer they were created with. But if we interlieve a DOM renderer with a Custom one, current_renderer could be a custom one when the effect reruns and if we don't push `null` it will use the custom_renderer methods instead of the DOM ones.	2 months ago
paoloricciuti	131fae3c2d	fix: update snapshot	2 months ago
paoloricciuti	f781fe485c	chore: fix type	2 months ago
paoloricciuti	a72c3650c9	Merge remote-tracking branch 'origin/main' into svelte-custom-renderer	2 months ago
paoloricciuti	c58c5565c0	fix: noop on the server for custom renderer components	2 months ago
Yuichiro Yamashita	b471c15e61	fix: don't hang on a tag whose expression ends with a trailing slash (#18350 ) close https://github.com/sveltejs/svelte/issues/18349	2 months ago
Yuichiro Yamashita	c74f44fff9	fix: don't mistake `type` identifier expressions for TS `type` declarations in tags (#18330 ) Detect TypeScript `type` declarations by actually parsing instead of by character-class blacklists, so that expressions like `{type === 'all' ? a : b}` or `{type instanceof Foo}` aren't misclassified as malformed declarations. Closes #18328 --------- Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com> Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>	2 months ago

1 2 3 4 5 ...

11420 Commits (bf7a4e6883f14033a369c3cd7a48bc3b620c8740) All Branches Search

11420 Commits (bf7a4e6883f14033a369c3cd7a48bc3b620c8740)

All Branches