11458 Commits (b92bc88d96ec8f075d4e4743a56cc8ff7554cbbe)

 

All Branches   

Search

Author	SHA1	Message	Date
Rich Harris	b92bc88d96	note possible future simplification (simon, feel free to revert if this is actually nonsense)	11 hours ago
Rich Harris	39aa80d492	define folding	12 hours ago
Rich Harris	f9f01bd2ab	turn references into crosslinks	12 hours ago
Simon Holthausen	fd71c0cce3	tmp: commit md file	14 hours ago
Simon Holthausen	06f7ec0e8a	bring over tests that pass unchanged	14 hours ago
Simon Holthausen	6d3317f972	simplify/comments	14 hours ago
Simon Holthausen	508b1908bd	merge dirty_reactions into unprocessed, comments	15 hours ago
Simon Holthausen	a996f4072b	simplify/fix	15 hours ago
Simon Holthausen	ab9863cebb	fix	19 hours ago
Simon Holthausen	0a1b1c264f	tweak implementation, reduce concepts a bit	21 hours ago
Simon Holthausen	4a2278164f	speed up / reduce code size a bit / fix error bug	22 hours ago
Simon Holthausen	d28ea11509	wip	2 days ago
Rich Harris	40bb08482f	chore: more passing async tests (#19014) ... a handful more tests from #18880 that already pass on `main`, including some existing tests that were previously skipped	2 days ago
Rich Harris	a841a29407	chore: bring over passing async-eager tests (#19011) ... more tests from #18880 that already pass on `main`. On that branch, there are four new tests that use `$state.eager`: 1. async-eager-batch-no-merge 2. async-eager-new-in-earlier-batch 3. async-eager-read-new-dependency 4. async-state-eager-not-connected 1 describes undesirable behaviour (see https://github.com/sveltejs/svelte/pull/18880#discussion_r4271899616). The other three already pass on `main` — the changes to the implementation on #18880 (the `is_eager` stuff) are counteracting other things that changed on that branch. Of those, this brings over 2 and 4. 3 is unnecessary — the `$state.eager` in 3 isn't doing anything (`show` doesn't have any async dependents).	2 days ago
Rich Harris	4473857264	chore: bring over more tests that already pass on main (#19007) ... from #18988	2 days ago
Rich Harris	34079beb4a	chore: add more async fork tests (#19004) ... These tests from #18881 already pass on `main` and describe the correct behaviour, so we can merge them straight in and shrink the other PR	3 days ago
Rich Harris	522f832aec	chore: fix test timeouts (#19005) ... I've seen tests time out on Windows a few times recently, which seems outrageous but I think the runners are somewhat underpowered. This _should_ fix it, I think	3 days ago
Conduitry	79e7c3bd34	fix: `devalue` link in `hydratable_serialization_failed` error (#18999)	3 days ago
Rich Harris	86eb09b76e	chore: even more async tests (#18990) ... extracting some tests from #18983 — these pass on `main`, `pt-1`, `pt-2` and `pt-3`. The others in that PR don't pass on `main`, so will be dealt with separately	4 days ago
Rich Harris	4d2ad8a189	chore: add async-merge-blocking-pending test from #18983 (#18989) ... #18983 adds two new tests. One of them passes on `main`, so we can merge it independently. The other only passes on `pt-1`, so I'll add it to that branch	4 days ago
Rich Harris	d9acd2da90	test: add async tests that already pass on main, unskip async-overlap-multiple-2 (#18981) ... These tests from #18880 already pass on `main`. Moving them out of that PR makes it clearer what behaviour is actually changing over there	4 days ago
Rich Harris	6480a9737f	chore: make Batch prev/next/started public (#18982) ... converts some private fields to public ones, because on #18880 they are used outside the class. breaking the change out removes some diff noise	4 days ago
Rich Harris	e22a67c432	chore: tidy up comments and types in batch.js and sources.js (#18980) ... couple of trivial tidy-ups, ref #18880	4 days ago
Rich Harris	0c61f1bb76	chore: merge #dirty_effects and #maybe_dirty_effects into #dirty_reactions (#18979) ... yoinking a minor change out of #18880	5 days ago
Serghei	707c28146b	fix: keep creating state sources for property checks during component init (#18949)	1 week ago
svelte-triage-bot[bot]	c85120fb9f	fix: track missing proxy keys in unowned deriveds (#18944) ... Co-authored-by: svelte-triage-bot <team@svelte.com>	1 week ago
github-actions[bot]	10fdca7d70	Version Packages (#18858) ... This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## svelte@5.57.2 ### Patch Changes - fix: don't create async deriveds for a component destroyed while waiting for its top-level `await` ([#18931](https://github.com/sveltejs/svelte/pull/18931)) - fix: prevent untracked derived reads from retaining disconnected dependencies ([#18829](https://github.com/sveltejs/svelte/pull/18829)) - fix: error if `{:else}` is followed by another `{:else}` or `{:else if ...}` ([#18900](https://github.com/sveltejs/svelte/pull/18900)) - fix: avoid tracking SvelteURLSearchParams during URL updates ([#18791](https://github.com/sveltejs/svelte/pull/18791)) - fix: restore hydration state when custom element attribute updates throw ([#18467](https://github.com/sveltejs/svelte/pull/18467)) - fix: attach event handlers that are assigned after a top-level `await` in production ([#18933](https://github.com/sveltejs/svelte/pull/18933)) - fix: flush anything pending before invoking flushSync callback function ([#18878](https://github.com/sveltejs/svelte/pull/18878)) - fix: preserve location information for `await` wrappers ([#18859](https://github.com/sveltejs/svelte/pull/18859)) - fix: keep a reactive assignment with no dependencies when `migrate` cannot turn it into a declaration ([#18817](https://github.com/sveltejs/svelte/pull/18817)) - fix: don't hang `migrate` on a declaration that shares a line with its script tag ([#18816](https://github.com/sveltejs/svelte/pull/18816)) - fix: prevent duplicate subscriptions when reconnecting deriveds ([#18899](https://github.com/sveltejs/svelte/pull/18899)) - fix: recover when an unexpected node replaces a nested boundary comment during hydration ([#18925](https://github.com/sveltejs/svelte/pull/18925)) - fix: print `{#await}` blocks that only have a pending branch ([#18908](https://github.com/sveltejs/svelte/pull/18908)) - fix: don't warn about a redundant `link` role on `<area>` elements without an `href` ([#18872](https://github.com/sveltejs/svelte/pull/18872)) - fix: don't throw `state_unsafe_mutation` when the focused element is removed while `bind:activeElement` is used ([#18921](https://github.com/sveltejs/svelte/pull/18921)) - fix: don't overwrite an unchanged spread `value`, preserving incomplete number input ([#18864](https://github.com/sveltejs/svelte/pull/18864)) - fix: read batch-local array on each-block commit ([#18879](https://github.com/sveltejs/svelte/pull/18879)) - fix: error at compile time when a declaration in a snippet redeclares one of its parameters ([#18842](https://github.com/sveltejs/svelte/pull/18842)) - fix: error when using `let:` directives on a component with a `children` snippet ([#18873](https://github.com/sveltejs/svelte/pull/18873)) - fix: ignore stale boundary reset callbacks ([#18886](https://github.com/sveltejs/svelte/pull/18886)) - fix: handle deferred transitions aborted before initialization ([#18776](https://github.com/sveltejs/svelte/pull/18776)) - fix: prevent hydration mismatch recovery from being intercepted by error boundaries ([#18841](https://github.com/sveltejs/svelte/pull/18841)) - fix: preserve dynamic element connections during hydration ([#18855](https://github.com/sveltejs/svelte/pull/18855)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	2 weeks ago
svelte-triage-bot[bot]	c580b381f7	fix: prevent duplicate derived subscriptions on reconnect (#18899) ... - A dirty disconnected derived registered newly reached dependencies during evaluation, then `reconnect()` registered them again and retained disposed graphs. - The connection model from [#17105](https://github.com/sveltejs/svelte/pull/17105) and reconnection added in [#17362](https://github.com/sveltejs/svelte/pull/17362) restore skipped old dependencies; recursive unfreezing from [#17682](https://github.com/sveltejs/svelte/pull/17682) requires preserving that lifecycle. - Made reconnection idempotent instead of skipping or moving it, preserving unchanged subscriptions and frozen-effect ordering. - Covered direct and nested derived graphs, existing and newly reached dependencies, and complete teardown across client rendering modes. Fixes https://github.com/sveltejs/svelte/issues/18898 --------- Co-authored-by: svelte-triage-bot <team@svelte.com>	2 weeks ago
911RS	3f885e3016	fix: don't throw state_unsafe_mutation when the focused element is removed with bind:activeElement (#18921) ... Fixes #15742 With `<svelte:document bind:activeElement />`, clicking a button that removes itself throws `state_unsafe_mutation`. Removing the focused element makes the browser fire `focusout` while the `{#if}` block effect is running, and the binding's listener sets the state from inside that effect. `bind_active_element` now calls `update` inside `without_reactive_context`, like event handlers created with `create_event` and `bind_window_scroll` already do.	2 weeks ago
Maksim Romanov	fe4fb460b1	fix: error if `{:else}` is followed by another `{:else}` or `{:else if ...}` (#18900) ... Fixes #18202	2 weeks ago
jarrednorris	179f66b297	fix: don't create async deriveds for a component destroyed while waiting for its top-level `await` (#18931) ... Fixes #18930 --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>	2 weeks ago
jarrednorris	79a0c0d4d8	fix: attach event handlers that are assigned after a top-level `await` in production (#18933) ... Fixes #18932	2 weeks ago
Fatih Çakır	14136f88fc	fix: print `{#await}` blocks that only have a pending branch (#18908)	2 weeks ago
Abhinav Prakash	f382705328	docs: link svelte/transition module to transition directive (#18918)	2 weeks ago
nimbly1	5cbdd34374	fix: recover when an unexpected node replaces a nested boundary comment (#18925) ... Fixes #18924 --------- Co-authored-by: nimbly1 <258366730+nimbly1@users.noreply.github.com> Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>	2 weeks ago
Satvik Mishra	e5169f26c5	docs: note that a pending snippet skips SSR of boundary content (#18922) ... also remove an outdated note about needing a pending snippet for await --------- Co-authored-by: Satvik Mishra <satvikmishra08@gmail.com> Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>	2 weeks ago
cui fliter	7e83327400	fix: avoid tracking SvelteURLSearchParams during URL updates (#18791) ... ### Before submitting the PR, please make sure you do the following - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`. - [ ] This message body should clearly illustrate what problems it solves. - [ ] Ideally, include a test that fails without this PR but passes with it. - [ ] If this PR changes code within `packages/svelte/src`, add a changeset (`npx changeset`). ### Tests and linting - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint` --- Avoids creating an unintended reactive dependency when `SvelteURLSearchParams` synchronizes its owning `SvelteURL`. `#update_url()` now uses `super.toString()` instead of the reactive `toString()` method. URL synchronization only needs native serialization and should not subscribe the current reaction to the params version signal. Before this change, code such as: ```js render_effect(() => { url.searchParams.set('foo', 'bar'); }); ``` could cause the effect to run twice: 1. set() calls #update_url() 2. #update_url() calls reactive toString() 3. toString() subscribes the effect to #version 4. set() increments #version 5. The effect is scheduled again Signed-off-by: cuishuang <imcusg@gmail.com>	2 weeks ago
Paolo Ricciuti	7c2fcdae6a	docs: add note about `#key` in best-practices (#18851) ... We had this discussion with @teemingc about Astra using a key block as a way to re-render the whole component, which is very inefficient. When you think about it, a key block is actually almost never the right solution unless you want, for example, to rerun the animations. I propose to add this line here in the best practices skill/doc, which, in my opinion, makes sense. We should probably also add the same suggestions whenever we encounter a key block in the MCP Auto Fixer. What do you think about it? --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	2 weeks ago
Paolo Ricciuti	4c884722f8	docs: fix mention of svelte config in best practices (#18917) ... Closes https://github.com/sveltejs/ai-tools/issues/279	2 weeks ago
Minh Vu	020242d6be	fix: ensure hydration state restoration for custom element attribute updates (#18467) ... ### Problem While hydrating custom elements, set_attributes temporarily disables global hydration state via set_hydrating(false) and restores it only at the end. If a prop setter or attribute operation throws partway through, hydration mode can remain disabled globally. ### Fix Wrap the temporary hydration-state override in a try/finally block in set_attributes so set_hydrating(true) always runs when is_hydrating_custom_element is true. --------- Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>	3 weeks ago
Nic Polumeyv	28b99aa8e6	fix: error at compile time when a declaration in a snippet redeclares one of its parameters (#18842) ... `{const item = 1}` inside `{#snippet row(item)}` compiles, and the output declares `item` twice in one function, so it does not parse: ```js const row = ($$anchor, item = $.noop) => { const item = 1; ``` `{let}`, `{@const}` and a nested snippet with the parameter's name do the same. In `phases/scope.js`, `EachBlock` visits its body's children in the item's own scope, so a tag that reuses the item name is a `declaration_duplicate`. `SnippetBlock` calls `context.next({ scope: child_scope })`, the `Fragment` visitor opens another scope for the body, and the tag never meets the parameter. After visiting the body, `SnippetBlock` now reports any name in the body's scope that `child_scope` also declares. A declaration in a nested block or element still shadows the parameter. --------- Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>	3 weeks ago
Nic Polumeyv	5b44f26bc2	fix: keep a reactive assignment with no dependencies when `migrate` cannot turn it into a declaration (#18817) ... `migrate()` dropped a reactive assignment that has no dependencies and put nothing in its place: ```svelte $: count = 7; → (gone, `{count}` now undeclared) $: obj.x = 1; → (gone) ``` A binding the statement declares now always gets its `let`, and the statement is only removed once every target has one; otherwise it becomes `run()`: ```svelte let count = $state(7); run(() => { obj.x = 1; }); ```	3 weeks ago
Nic Polumeyv	8ef693e94e	fix: don't hang `migrate` on a declaration that shares a line with its script tag (#18816) ... `migrate()` never returned when a declaration shared a line with its `<script>` tag: ```svelte <script>export let answer</script> ``` The scan that removes a migrated `export let` line looked for a newline in both directions with no bound. It now stops at the script's edges.	3 weeks ago
Rich Harris	688a4e49b8	fix: preserve location information for `await` wrappers (#18859) ... Helps with code coverage tools: https://github.com/sveltejs/esrap/pull/124	3 weeks ago
svelte-triage-bot[bot]	7fe14a508a	fix: ignore stale boundary resets after destruction (#18886) ... - `destroy_effect` cleared a boundary's component context while retained reset callbacks and queued error work could still re-enter its run path. - Reset handling is intentionally shared with hydration by [#18556](https://github.com/sveltejs/svelte/pull/18556), while `onerror` is deferred for safe state mutation by [#17561](https://github.com/sveltejs/svelte/pull/17561); neither path checked the boundary lifetime. - Make retained and deferred boundary continuations inert during destruction instead of masking null contexts in `bind:this` or `#run`, which would still let dead effects and callbacks restart. - Cover resets from `onerror` and failed snippets, cleanup ordering, delayed error transforms, DOM rendering, and hydration. Fixes https://github.com/sveltejs/svelte/issues/18885	3 weeks ago
svelte-triage-bot[bot]	7fb397e78f	fix: handle deferred transitions aborted before initialization (#18776) ... - make deferred transition facade methods safe before the inner animation initializes - report the transition's initial position from the facade until initialization - add a runtime regression test for an out-only `crossfade` branch restored in the same update Fixes https://github.com/sveltejs/svelte/issues/18773 --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>	3 weeks ago
svelte-triage-bot[bot]	f908535659	fix: prevent untracked derived reads from retaining dependencies (#18829) ... Fixes https://github.com/sveltejs/svelte/issues/18827. A disconnected derived re-evaluated through `untrack` inside an effect could connect descendant deriveds because `is_updating_effect` was true, even though the active derived reader was not connected. Those descendants registered on long-lived dependencies without gaining a reaction that could later trigger their disconnect cascade. This changes `get()` to connect a derived only when its active reader is itself `CONNECTED`. Effects already carry that flag, and deriveds reached through connected readers receive it before evaluation, so tracked behavior remains intact. The now-unused `is_updating_effect` state is removed.	3 weeks ago
waltu	a956c2bd1f	fix: error when using `let:` directives on a component with a `children` snippet (#18873) ... Closes #13864 A `let:` directive on a component only applies to the default slot content. If the content is an explicit `{#snippet children()}` block, the value is never provided, so code like this compiles but fails at runtime with "value is not defined": ```svelte <Child let:value> {#snippet children()}Value is: {value}{/snippet} </Child> ``` This adds a compile error on the directive that points to snippet parameters instead (`{#snippet children({ value })}`, or `{ item: x }` for `let:item={x}`). Components with a `slot` attribute are not affected, since there the directive applies to the component itself. An unused `let:` next to a `children` snippet is also flagged now, but it never had any effect. ### Before submitting the PR, please make sure you do the following - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`. - [x] This message body should clearly illustrate what problems it solves. - [x] Ideally, include a test that fails without this PR but passes with it. - [x] If this PR changes code within `packages/svelte/src`, add a changeset (`npx changeset`). ### Tests and linting - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint` Co-authored-by: waltu <182410443+waltuov@users.noreply.github.com>	3 weeks ago
G	75aa6ba38d	fix: don't warn about redundant `link` role on `<area>` without `href` (#18872) ... Since #11737, `<a role="link">` without an `href` no longer triggers `a11y_no_redundant_roles`, but `<area role="link">` without an `href` still does. Per [ARIA in HTML](https://www.w3.org/TR/html-aria/#el-area-no-href), an `<area>` without `href` has the implicit role `generic` and `link` is one of its allowed roles, so the role isn't redundant. This applies the existing `<a>` exception to `<area>` and adds test cases for `<area>` with and without `href`. Closes #9261. The `<a>` example in that issue was already fixed by #11737, but the issue was left open. ### Before submitting the PR, please make sure you do the following - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`. - [x] This message body should clearly illustrate what problems it solves. - [x] Ideally, include a test that fails without this PR but passes with it. - [x] If this PR changes code within `packages/svelte/src`, add a changeset (`npx changeset`). ### Tests and linting - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint`	3 weeks ago
Dex	f7ca0a44a5	chore: fix typos in code comments (#18860) ... Fixes four typos in code comments (no behavioral change): - `packages/svelte/src/index-client.js`: `noone` -> `no one` - `packages/svelte/src/internal/client/dom/css.js`: `Therfore` -> `Therefore` - `packages/svelte/src/internal/client/runtime.js`: `loosing` -> `losing` - `packages/svelte/src/internal/server/index.js`: `aswell` -> `as well` Checklist: title prefixed with `chore:`; comment-only change so no changeset and no behavior affected. Co-authored-by: Dextheking1 <Dextheking1@users.noreply.github.com>	3 weeks ago