3624a4c2a0
feat: allow modifiying derived props ( #10080 )
...
It's an unnecessary restruction because it can be worked around (hide it behind a getter/setter), already works for bind:x and prevents valid use cases
1 year ago
1ff9c0f2b9
fix: support destructurings containing await ( #9962 )
...
Adds a traversion mechanism to found out if destructured expressions contain await
Fixes #9686
Fixes #9312
Fixes #9982
1 year ago
d16f17c306
fix: improve signal consumer tracking behavior ( #10121 )
1 year ago
092370b43f
Version Packages (next) ( #10112 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
527d099a09
fix: transform `{@render ...}` expression ( #10116 )
...
fixes #10059
1 year ago
05789daff9
fix: allow transition undefined payload + microtask queue handling ( #10117 )
...
* fix: allow transition undefined payload
* cleanup
* cleanup
* add microtask queue handling
1 year ago
b3d185da29
fix: correctly call exported state ( #10114 )
...
fixes #10104
also cleans up related code and adds support for destructuring `$state.frozen`
1 year ago
92408e1506
fix: get spread + bind working ( #10091 )
...
fixes #10033
1 year ago
6acf7f3fc3
fix: apply key animations on proxied arrays ( #10113 )
...
* fix: apply key animations on proxed arrays
* fix: apply key animations on proxed arrays
* fix: apply key animations on proxed arrays
1 year ago
ebbb5dd655
fix: improve internal signal dependency checking logic ( #10111 )
1 year ago
0c58524d23
Version Packages (next) ( #10070 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
ddd7926240
fix: improve key block reactivity detection ( #10092 )
1 year ago
86eae7e77d
fix: loosen input in button error ( #10083 )
...
The validation exists to error on html that would result in the browser repairing it, causing hydration errors. input is never moved, so we can remove it from the array
---------
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
1 year ago
94aab90bd1
fix: improve text node output ( #10081 )
...
* fix: improve text node output
* revert
1 year ago
3c6977add3
fix: improve style parser whitespace handling ( #10077 )
...
allow whitespace, allow comments
fixes #10073
1 year ago
570884eabd
fix: spread attributes reactivity improvements ( #10071 )
...
- the objects could contain getters with reactive values, so we play it safe and assume they're always reactive - fixes #10065
- isolate spreads with call expression similar to how we do it with other effects -fixes #10013
1 year ago
877ff1ee7d
fix: provide `unstate` in server environment
...
fixes #10016
1 year ago
2133d7d67a
fix: support TS satisfies operator ( #10068 )
...
fixes #9606
1 year ago
fa8aa2d481
Version Packages (next) ( #10052 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
5f3fcaf88a
fix: bail-out event handler referencing each index ( #10063 )
...
* fix: bail-out event handler referencing each index
* lint
* ts
* types
1 year ago
15d6308d60
fix: catch delegated events from elements moved outside the container ( #10060 )
...
fixes #9777
1 year ago
8a8505928e
fix: deeply unstate objects passed to inspect ( #10056 )
...
When doing `$inspect({ x, y })`, both `x` and `y` are now unstated if they are signals, compared to before where `unstate` was only called on the top level object, leaving the proxies in place which results in a worse debugging experience.
Also improved typings which makes it easier to find related code paths.
1 year ago
e46a71e8a3
fix: handle pseudo class elements with content ( #10055 )
...
closes #9398 (the other things in that issue are already addressed)
closes #10019
1 year ago
6d65b2f8ad
fix: improve parsing of `:nth-of-type(xn+b)` ( #9970 )
...
closes #9969
this also fixes the following along the way:
the + in nth-of-type(+xn-b) would be parsed as a combinator.
invalid cases like these are not allowed anymore:
b(+/-)b
-ax
-ax-b
-b
1 year ago
1e33ed5bb9
fix: ensure if block is executed in correct order ( #10053 )
...
* fix: ensure if block is executed in correct order
* alternative approach
* improve algo
* optimize
* lint
1 year ago
98a72f5068
chore: check in types ( #9863 )
...
To ensure that changes to code/types doesn't result in unwanted changes in type generation, or that bumps to dts-buddy don't cause unwanted regressions, we're checking in the generated types. Types should be committed as-is (don't format it with prettier!). CI is enhanced to check that git sees no changed files after generating the types, which would mean types have changed.
1 year ago
abc126630a
fix: add types for popover attributes and events ( #10041 )
...
closes #10036 , this also moves the HTMLDetailsElement toggle event to its interface as it was conflicting with HTMLElement popover toggle event.
---------
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
1 year ago
d56223b162
fix: improve script `lang` attribute detection ( #10046 )
...
closes #10038
1 year ago
346041f454
chore: skip generating $.proxy() calls for more expressions ( #9979 )
...
* chore: skip emitting $.proxy() calls for more expressions
* Update pretty-ties-help.md
---------
Co-authored-by: Dominic Gannaway <trueadm@users.noreply.github.com>
1 year ago
6307a3322c
Version Packages (next) ( #10005 )
...
* Version Packages (next)
* Apply suggestions from code review
---------
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Rich Harris <richard.a.harris@gmail.com>
1 year ago
69f2840e28
#9985 , but simpler ( #10009 )
...
* #9985 , but simpler
* oops
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
2ad5e53d53
remove unnecessary test ( #10008 )
...
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
8a013c4cc6
fix: transition parameters are not reactive ( #9836 )
...
* test: add tests of transitions in new runtime
* fix: move evaluation of props
* format
* add changeset
1 year ago
180b3322b2
feat: minor type improvements ( #9989 )
1 year ago
c0a357c262
fix: support hydrating around `<noscript>` ( #9953 )
...
* add test
* fix: support hydrating around `<noscript>`
* changeset
1 year ago
bd34367660
fix: Add some tests to avoid regression on #8559 ( #9956 )
...
* Add some tests to avoid regression
* Add runes test and remove extra tests
1 year ago
b31946eb08
fix: Backtick now displays with templates ( #9973 )
...
* Add a test for backtick in template
* Put sanitize_template_string and use it everywhere
* Prettier
* Add changeset
1 year ago
5dffe715d3
fix: issue with assiging prop values as defaults of other props ( #9985 )
...
* Fix issue on assiging prop values as defaults of other props
* Prettier
* Add changeset
1 year ago
547ab932a8
fix: props with dash #9964 ( #9993 )
...
* fix member call
* format
1 year ago
2b8440c1e9
fix typo in release notes ( #10003 )
1 year ago
75cd1e825c
feat: add $state.frozen rune ( #9851 )
...
* feat: add $state.raw rune
fix typo
fix typo
* add more tests, fix example
* add other test
* change to $state.readonly
* fix readme
* fix validation
* fix more
* improve types
* improve REPL
* switch to $state.frozen
* update docs
* update docs
* update docs
* Update .changeset/dry-clocks-grow.md
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
* Update packages/svelte/src/internal/client/runtime.js
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
* Update packages/svelte/src/internal/client/runtime.js
* docs
* Update sites/svelte-5-preview/src/routes/docs/content/01-api/02-runes.md
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
---------
Co-authored-by: Rich Harris <richard.a.harris@gmail.com>
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
eab690d31a
Version Packages (next) ( #9922 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
b8f3c49e5f
fix: improve event delegation handler hoisting ( #9929 )
...
* fix: improve event delegation handler hoisting
* fixes
1 year ago
59c7487f36
fix: better handle array property deletion reactivity ( #9921 )
1 year ago
b779e72eb6
Version Packages (next) ( #9913 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
2608e621d6
add test ( #9917 )
1 year ago
b1efd8c4cd
fix: improve each block fallback handling ( #9914 )
1 year ago
3a4a09102c
fix: improve whitespace handling ( #9912 )
...
revert
1 year ago
f2d111264c
Version Packages (next) ( #9899 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
55656f520d
feat: add support for {@const} inside snippet block ( #9904 )
...
* check for snippet block
* change the error msg
* edit tests
* changeset
* test
1 year ago
b0511a5966
fix: improve attribute directive reactivity detection ( #9907 )
1 year ago
4e61db7201
chore: improve readonly prop messaging ( #9901 )
1 year ago
436a6c3dc4
fix: improve $inspect batching ( #9902 )
...
* fix: improve $inspect batching
* fix dev bug
* simplify
* simplify
1 year ago
a9a5b11c78
fix: improve props aliasing ( #9900 )
1 year ago
0236cf87e7
fix: better support for top-level snippet declarations ( #9898 )
1 year ago
a8e5cc83cd
Version Packages (next) ( #9856 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
56de55bb77
fix: improve unstate type definition ( #9895 )
...
* fix: improve unstate type definition
* tweak
* tweak
1 year ago
daa19173b1
fix: improve html tag svg behaviour ( #9894 )
1 year ago
2ca3c87d18
fix: correctly reflect readonly proxy marker ( #9893 )
1 year ago
7238e1d3ce
fix: improve each block index handling ( #9889 )
1 year ago
bdd63c8187
fix: ensure class constructor values are proxied ( #9888 )
...
* fix: ensure class constructor values are proxied
* debugger
1 year ago
6a89a8f482
chore: optimize `get_amount_class_specificity_increased` ( #9853 )
...
* Optimaze
* pnpm format
---------
Co-authored-by: Mike <prince-poley@yandex.ru>
1 year ago
acf73104b5
feat: add GamepadEventHandler type ( #9861 )
...
Add GamepadEventHandler type for window.addEventListener `gamepadconnected` and `gamepaddisconnected`
1 year ago
cb529fc666
chore: improve each block fast-path heuristic ( #9855 )
...
* chore: improve each block fast-path heuristic
* chore: improve each block fast-path heuristic
1 year ago
b90b14645b
Version Packages (next) ( #9847 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
56d8c0fd3a
fix: ensure action function returns object ( #9848 )
1 year ago
4717d2ad23
fix: handle event hoisting props referencing ( #9846 )
...
* fix: handle event hoisting props referencing
1 year ago
fd78acfec9
fix: support dynamic transition functions ( #9844 )
...
* fix: support dynamic transition functions
* add test
* lint
* load dynamic code lazily
load dynamic code lazily
load dynamic code lazily
1 year ago
ab21253073
Version Packages (next) ( #9833 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
df5105ef2e
breaking: change `$inspect` API ( #9838 )
...
* breaking: change `$inspect` API
`$inspect` now takes 1-n arguments, and inspections modification happens through `.with(..)`
closes #9737
* lint
1 year ago
26c6d6f95d
chore: avoid creating unnecessary thunks ( #9841 )
...
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
8dfb2894b4
fix: improve each key animations ( #9842 )
1 year ago
08d93a2f5f
fix: improve each block with animate ( #9839 )
1 year ago
388e3e68fc
fix: improve signal consumer removal logic ( #9837 )
1 year ago
e2dcdc2887
fix: ensure computed props are wrapped in derived ( #9835 )
1 year ago
d9c250a4bf
fix: better handle unowned derived signals ( #9832 )
...
* fix: better handle unowned derived signals
* format
---------
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
1 year ago
b20b4617c0
chore: rethink props ( #9826 )
...
Cleaned up prop_source and renamed it to prop. Updated tests accordingly
1 year ago
c9c2bde5e7
chore: do not emit invalidate_effect for select synchronization ( #9830 )
...
in runes mode
1 year ago
384e3a42b3
Version Packages (next) ( #9807 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
fb853106a9
chore: skip READONLY_SYBOL check in prod ( #9825 )
...
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
481df0e64a
fix: correctly apply scope on component children ( #9824 )
...
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
5797bb34ce
fix: reuse proxy between objects ( #9821 )
...
* chore: reuse proxy between objects
* lint
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
3fb917dc6d
chore: remove unused check ( #9817 )
...
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
548ffdd3bd
chore: code golf text_effect a bit ( #9814 )
...
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
c0150b0bd3
chore: tweak readonly error message ( #9816 )
...
* tweak readonly error message
* update tests
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
1e4af19404
chore: use `$$props` directly where possible ( #9813 )
...
* use $$props directly in runes mode
* this makes no sense
* use $$props directly in runes mode
* tidy up
* typo
* remove unreachable code
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
074615d7fd
fix: prevent infinite loops stemming from invalidation method ( #9811 )
...
* fix: prevent infinite loops stemming from invalidation method
The logic was flawed: the captured signals where always added to the previous captured no matter what, which meant a) memory leak b) that when another one runs afterwards, it will falsely contain the signals from the previous run
fixes #9788
* fix lint
1 year ago
edc569e73b
chore: refactor is_promise function ( #9794 )
...
* Refactor is_promise function
* Update packages/svelte/src/internal/common.js
---------
Co-authored-by: Mike <prince-poley@yandex.ru>
Co-authored-by: Rich Harris <hello@rich-harris.dev>
1 year ago
dcdd645480
fix: adjust children snippet default type
...
Needs to be void so that zero args are passed to it
fixes #9744
1 year ago
5667785903
fix: better readonly checks for proxies ( #9808 )
...
- Expect the thing that's checked to be wrapped with the proxy already, so that we can just check for the state symbol
- Make error message more descriptive
1 year ago
d5167e75b9
fix: improve non state referenced warning ( #9809 )
...
* fix: improve non state referenced warning
* add test
1 year ago
d793d570e2
fix: improve consistency issues around binding invalidation ( #9810 )
...
* co
* Add comment
1 year ago
01a2117330
chore: use proxy instead of signal in createRoot ( #9799 )
...
* use proxy instead of signal in createRoot
* DRY
* remove for now
* lint
* chore: use proxies instead of signals for spread/rest props (#9801 )
* use proxies instead of signals for spread/rest
* fix some spread attribute stuff
* remove is_signal calls
* simplify some more
* more
* remove some unnecessary unwrapping
* another
* simplify
* simplify
* simplify
* remove another MaybeSignal
* more
* remove more unwraps
* code-golf, docs
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>
* add missing jsdoc annotation
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>
1 year ago
3c2e656187
fix: tweak css nth regex ( #9806 )
...
fixes #9795
1 year ago
4b76c6998b
chore: simplify await blocks ( #9802 )
...
We never pass a signal to await blocks currently, so the "is_signal" check is unnecessary
1 year ago
f552a4b2ea
Version Packages (next) ( #9771 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
e6b5ccd29a
fix: tweak invalid dollar prefix rules around function args ( #9792 )
1 year ago
62c9292947
feat: make fallback prop values readonly ( #9789 )
...
* WIP
* update tests
* only make readonly in runes mode
* remove this for now
* changeset
* ugh
* add reassignment test
* tweak message
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
bd8f7db754
check runtime errors ( #9791 )
...
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
3b15e32a91
fix: ensure generate guards against keywords ( #9790 )
...
* fix: ensure generate guards against keywords
* changeset
* lint
* Update .changeset/old-flies-jog.md
---------
Co-authored-by: Rich Harris <richard.a.harris@gmail.com>
1 year ago
9c3516dd3d
feat: runes globals error ( #9773 )
...
* feat: runes globals error
throw descriptive error for using runes globals outside of Svelte-compiled files
* less hacky/more future-proof treeshaking check
* tweak
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
24777c335a
feat: disallow fallback values with bindings in runes mode ( #9784 )
...
* disallow fallback values with bindings in runes mode
* on second thoughts
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
c7e626ebbb
feat: add unstate utility function ( #9776 )
...
* feat: add unstate utility function
* Update packages/svelte/src/internal/client/proxy/proxy.js
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
* update docs
* add class support
* oops
* lint
* fix docs
* remove symbol and class support
---------
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
Co-authored-by: Rich Harris <richard.a.harris@gmail.com>
1 year ago
f1954d034b
fix: ensure proxied array length is updated ( #9782 )
...
* fix: ensure proxied array length is updated
* fix: ensure proxied array length is updated
* add test
* lint
1 year ago
10aacfa603
chore: remove `exposable` ( #9783 )
...
* use flags for prop_source, this will be useful later
* remove exposable/expose stuff
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
25abca78b2
fix: ensure transitions properly cancel on completion ( #9778 )
1 year ago
ef158ff729
fix: apply event attribute validation to elements only ( #9772 )
...
fixes #9755
1 year ago
ede5dab230
chore: fix compiler-errors test suite ( #9754 )
...
- fix compiler-errors test suite
- handle css nth-selector syntax (fixes #9765 )
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>
1 year ago
fd4a52c894
add missing changelog entry
1 year ago
e4056107f0
Version Packages (next) ( #9753 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
75fc09a79e
Proxied state ( #9739 )
...
* magic objects
* read length eagerly — triggers reconciliation
* nested magic
* tests
* more tests
* fix array memory leak
* skipped, partially passing array test
* Fix each
revert bad changes
* more 1337
* eliminate closures
* maybe this is unnecessary?
* only create sources for own properties
* more
* rename stuff
* shuffle things around
* emit $.proxy
* remove proxy helper from public API
* only create sources for writable properties
* update test
* get tests passing
* fix
* remove state-not-mutated warning, which is no longer valid
* track reassignments separately from mutations
* update test - effects no longer fire on mutations unnecessarily
* move util into utils file
* move each logic into its own module; breathe sigh of relief
* tweaks
* more tweaks
* improve runtime
* fix mistake
* ensure we proxy when assigning to state
* fix test
* handle frozen
* create sources when reading proxy properties inside deriveds
* only mutate in legacy mode
* add immutable to transform state
* remove unused second argument to derived
* remove unused second argument to source, and runtime immutable option to createRoot (not sure what that was doing there?)
* oops, backwards
* dedicated binding.kind for legacy reactive imports
* avoid using prop_source in more cases. bit hacky, could be tidier, but it works
* distinguish between source and mutable_source
* remove immutable option from mount
* remove unused apparatus around immutable option
* deprecate immutable
* fix
* tweak
* better default value handling
* remove unnecessary exports
* whitespace is free
* remove obsolete symbol from proxy
* cleanup ts
* improve runtime perf by removing version reads in has()
* add missing proxy call
* tune perf of has() more
* ensure we only create sources in effect_active()
* fix proxy of computed fields
* simplify and fix issue with indexed each blocks
* fix compiler errors around exported state
* only create source for state that is reassigned
* temporary fix, we should come up with something better than this
* readonly props
* fix test
* add test for bind:
* make readonly dev-only
* docs
* forbid setPrototypeOf
* lol whoops
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
Co-authored-by: Dominic Gannaway <dg@domgan.com>
1 year ago
f0c47c31bc
fix: allow duplicate snippet declaration names ( #9759 )
...
Fixes #9756
1 year ago
ef5bcfe542
fix: ensure event handlers containing arguments are not hoisted ( #9758 )
...
* fix: ensure event handlers containing arguments are not hoisted
* add test
* handle rest arguments
1 year ago
2017af407d
fix: ensure computed props are cached with derived ( #9757 )
...
Fixes #9751
1 year ago
aaa1797ed8
fix: css parser fix
...
when inside a pseudo-class, only `)` is a valid end, and when outside, only `{` is - reflect that in the logic
1 year ago
402a322317
chore: more validation errors ( #9723 )
...
* invalid directive on component
* duplicate animation
* invalid animation
* no const assignment
* expected token
* invalid-attribute-name
* fixes
* invalid event modifier
* component name
* slot validation
* fix test
* const validation + fix double declaration bug
* omg this validation is skipped in svelte 4, remove it entirely then
* gah
* unskip
* contenteditable
* invalid css selector
* css global selector + css parser fixes
* export default
* dynamic element
* each block
* html tag
* logic block
* reactive declaration
* duplicate script
* namespace
* module context
* slot
* svelte fragment
* textarea
* title
* transition
* window bindings
* changeset
* svelte head, let directive, tweaks
1 year ago
d19e622e90
docs: update `create` -> `createRoot` ( #9750 )
1 year ago
61e5e53eee
Version Packages (next) ( #9736 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
765d01d76c
correctly inspect derived values ( #9731 )
...
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
1108587f1b
Version Packages (next) ( #9707 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
2fa06447cf
fix: improve template text node serialization ( #9722 )
...
fix: improve template text node serialization
1 year ago
7eba35b9d1
fix: improve infinite loop capturing ( #9721 )
1 year ago
8266229c42
fix repl ( #9720 )
1 year ago
cb1ea1f2db
fix: ensure `$$slots` exists in runes mode ( #9718 )
...
fixes #9683
1 year ago
4a8f0bc7e7
fix: keep fallback value after spread update not setting that prop ( #9717 )
...
fixes #9716
1 year ago
65fa717ccd
fix: port over props that were set prior to initialization ( #9704 )
...
Svelte 5 version of #9701
1 year ago
2e461eb314
chore: remove redundant hydration code ( #9698 )
1 year ago
e3dc185a4c
fix: tweak const tag parsing ( #9715 )
...
fixes #9711
1 year ago
f88895e955
fix: allow `bind:this` with dynamic type on inputs ( #9713 )
...
fixes #9709
1 year ago
1fe0152dd4
fix: delegate events on elements with bind-this ( #9696 )
...
fixes #9688
1 year ago
2416587215
fix: ensure implicit children snippet renders correctly ( #9706 )
...
place anchors around render tags, not snippet tags
fixes #9678
1 year ago
bde42d5676
`$inspect` rune ( #9705 )
...
* feat: add $log rune
* fix issues
* fix issues
* tune
* avoid static state reference validation
* work around unfortunate browser behavior
* call it ExpectedError
* cleanup
* Fix docs
* tweaks
* tweaks
* lint
* repl, dev: true
* repl dev mode
* Update sites/svelte-5-preview/src/lib/Repl.svelte
* squelch static-state-reference warning
* simplify
* remove redundant code
* Update packages/svelte/src/main/ambient.d.ts
Co-authored-by: Rich Harris <richard.a.harris@gmail.com>
* Update packages/svelte/src/main/ambient.d.ts
Co-authored-by: Rich Harris <richard.a.harris@gmail.com>
* Update packages/svelte/src/main/ambient.d.ts
Co-authored-by: Rich Harris <richard.a.harris@gmail.com>
* only pause/trace on change
* Update packages/svelte/src/main/ambient.d.ts
* Update .changeset/chatty-hotels-grin.md
* Update sites/svelte-5-preview/src/routes/docs/content/01-api/02-runes.md
Co-authored-by: Rich Harris <richard.a.harris@gmail.com>
* $log.break and $log.trace no-op during SSR
* Update sites/svelte-5-preview/src/routes/docs/content/01-api/02-runes.md
Co-authored-by: Rich Harris <richard.a.harris@gmail.com>
* update test
* improve break experience
* fix ts
* remove unnecessary if (DEV) checks - log runes are removed in prod
* ensure hoisting doesnt mess up source maps
* check visited for cyclical values
* rename $log to $inspect, remove children
* custom inspect function
* implement custom inspect functions
* changeset
* update docs
* only fire on change
* lint
* make inspect take a single argument
* ugh eslint
* document console.trace trick
* demos
* fix site
---------
Co-authored-by: Dominic Gannaway <dg@domgan.com>
Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>
Co-authored-by: Rich Harris <rich.harris@vercel.com>
Co-authored-by: Dominic Gannaway <trueadm@users.noreply.github.com>
1 year ago
3e3ae925f3
Version Packages (next) ( #9692 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
75295ac79f
docs: enhance breaking change section ( #9674 )
...
* docs: enhance breaking change section
- mention createRoot first, explain difference to mount
- mentiond bind:this change
- sub headings
- adjust createRoot type that missed the events property
* Update packages/svelte/src/internal/client/render.js
Co-authored-by: Conduitry <git@chor.date>
* clarify
---------
Co-authored-by: Conduitry <git@chor.date>
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
dd4061bc38
rename dev script, update contributor guide and readme ( #9673 )
...
* rename dev script, update contributor guide and readme
* turns out we can do this!
* increase accuracy
* justify FILTER
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
f9ba528265
fix: add children to element typings ( #9679 )
...
* fix: add children to element typings
Add this here so that libraries doing `props$<HTMLButtonAttributes>()` don't need a separate interface
fixes #https://github.com/sveltejs/language-tools/issues/2218
* typo
1 year ago
aabab263ee
fix: handle ts expressions when dealing with runes ( #9681 )
...
* fix: handle ts expressions when dealing with runes
related to #9639
* docs, more tests
* simplify
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
a31b2e1b8e
Version Packages (next) ( #9650 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
81d3e47d1c
feat: add $effect.root rune ( #9638 )
...
* feat: effect-root-rune
feat: add $effect.root rune
update doc
update doc
fix validation
* cleanup logic
* Update sites/svelte-5-preview/src/routes/docs/content/01-api/02-runes.md
* address feedback
---------
Co-authored-by: Rich Harris <richard.a.harris@gmail.com>
1 year ago
48e78e420f
chore: remove static value handling ( #9571 )
...
The deleted code ensured that a static variable wouldn't update when it's in the same text expression as a reactive variable. We solved this through emitting a warning about this instead, marking it as undefined behavior.
1 year ago
5836c1cdbd
chore: improve output for `<svelte:element>` ( #9648 )
...
- doesn't add spread_dynamic_element_attributes when there are no attributes — Unnecessary spread_dynamic_element_attributes call #9646
- skips the child render function altogether if there is nothing to do
1 year ago
6e863e617c
feat: warn on referenced mutated nonstate ( #9669 )
...
Walk the path and warn if this is a mutated normal variable that's referenced inside a function scope
1 year ago
9c44fd7854
feat: ignore href when hydrating ( #9662 )
...
* ignore href when hydrating
* remove unused export keyword
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
da1aa7c4a8
feat: support type annotations in `{@const ...}` tag ( #9609 )
...
* support type for const tag
* use expression directly
* lint
* format
* format
* revert
* legacy mode
* format
* revert and update .prettierignore
1 year ago
617d63dd90
fix: take event attributes into account when checking a11y ( #9664 )
...
also adjusted the warning messages slightly so they make sense for both variants of event handlers
fixes #9654
1 year ago
83fd001157
fix: prevent reactive snippet from reinitializing unnecessarily ( #9665 )
...
untrack the invocation itself, only track the snippet function
fixes #9652
1 year ago
405e9da4ff
chore: bump esrap ( #9649 )
...
* bump esrap
* changeset
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
66d540d3c5
Version Packages (next) ( #9642 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
7f237c2e41
fix: omit this bind this arg if we know it's not a signal ( #9635 )
...
fixes #9629
Co-authored-by: Dominic Gannaway <dg@domgan.com>
1 year ago
dee5bed829
fix: improve each block index handling ( #9644 )
...
* fix: improve each block index handling
* format
1 year ago
02f3f42981
fix: apply keyed validation only for keyed each ( #9641 )
1 year ago
94afdc8a4b
Version Packages (next) ( #9633 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
63e5831846
fix: adjust mount and createRoot types
...
they expect the component constructor, not the instance
1 year ago
a3bc7d5698
fix: type-level back-compat for default slot and children prop
...
If someone has an existing SvelteComponent type definition and using the slot generic to type the default slot, automatically add that slot to the prop type as "children"
1 year ago
cb4b1f0a18
fix: remove constructor overload
...
The original intent was for typing generation tools like svelte2tsx to use the virtual constructor instead, but it does more harm than good. Most notably, the TS error message when props are wrong becomes completely useless. It's better for tooling to silence the deprecation message and switch over to a new virtual constructor once we remove the deprecated one.
1 year ago
b7af2ffabd
Version Packages (next) ( #9607 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
78a69acfa1
fix: dont error on stores looking like runes when runes explicitly turned off ( #9615 )
1 year ago
72d3a2a8ce
fix: better attribute casing logic ( #9626 )
...
- don't lowercase attributes on svg and custom element elements, fixes #9605
- better lowercasing + property alias checking for spreads, fixes #9305
1 year ago
ef68b66dee
fix: improve member expression mutation logic ( #9625 )
...
* fix: improve member expression mutation logic
* cleanup
* Update .changeset/moody-frogs-exist.md
---------
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
1 year ago
c7121aa38c
feat: add type of `$effect.active` ( #9624 )
1 year ago
d8d9be39d3
fix: apply correct snippet scope ( #9623 )
1 year ago
509f92d29e
fix: correctly assign bind:this with multiples ( #9617 )
...
* fix: correctly assign bind:this with multiples
* better fix
* better fix
* lint
* lint
* Update packages/svelte/src/internal/client/render.js
---------
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
1 year ago
c22ebffb00
chore: untrack keyed validation logic ( #9618 )
...
* untrack validation logic
* chore: untrack keyed validation logic
1 year ago
8118efd115
fix: handle undefined bubble events ( #9614 )
...
Fixes #9610
1 year ago
0283e50070
chore: reuse common templates ( #9601 )
...
#9589 - add comment and space as reusable templates to save a few bytes. We can definitely take this idea further, but this is a base to iterate from.
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>
1 year ago
d83bd7f7c1
Version Packages (next) ( #9576 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
88f1a8f62e
chore: better error message for not using snippet type ( #9602 )
...
language tools checks that a function passed to `{@render ..}` is returning a type that adheres to the `Snippet` return type. When it does not, the error message is pretty useless without this additional info text.
1 year ago
5f6c5ca8ae
chore: remove get_callee_name ( #9595 )
...
no longer necessary with the enhanced get_rune function
1 year ago
13c6c273c6
fix: prevent false positives when detecting runes mode ( #9599 )
...
Move references from module scope to instance scope if we determined that these references are store subscriptions
fixes #9580
1 year ago
c837771ca6
chore: better `get_rune` helper ( #9594 )
...
* chore: add $effect.active rune
* chore: add $effect.active rune
* WIP
* allow get_rune to return a keypath
* oops
---------
Co-authored-by: Dominic Gannaway <dg@domgan.com>
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
1f4ae5ef45
chore: remove some unused code ( #9593 )
...
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
cf9130613d
feat: add $effect.active rune ( #9591 )
...
* chore: add $effect.active rune
* chore: add $effect.active rune
1 year ago
13aef5245b
put nested class warning on the declaration, not the usage site ( #9592 )
...
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
fe9c0bc19d
chore: bump esrap ( #9590 )
1 year ago
eb0b4dc6e5
chore: add inline new class warning ( #9583 )
...
* chore: add inline new class warning
* Address feedback
* address feedback
* more tests
1 year ago
1003acccc4
feat: add Snippet type ( #9584 )
...
* feat: add Snippet type
related to #9447
* one more test
1 year ago
da15806136
fix: adjust event delegation heuristics ( #9581 )
...
Fixes #9561
1 year ago
46c572a14d
chore: deduplicate
1 year ago
c011db178b
fix: select enabled option with null value when it matches bound value ( #9550 )
...
Fix select binding when matching enabled option has null value
Fix null option being selected when it doesn't match the bound value
Fixes #9545
1 year ago
1bc89b5eb6
fix: deconflict generated names against globals ( #9570 )
...
fixes #9559
1 year ago
945a90b56c
fix: disallow static state fields ( #9577 )
...
closes #9547
1 year ago
617df1f3c3
fix: adjust regex ( #9572 )
...
would error on non-quoted attributes with more than one character
1 year ago
b9664700b7
Version Packages (next) ( #9542 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
1c48d7cbdc
Typescript each indexed ( #9567 )
...
* failing test
* fix undefined index bug
* Update packages/svelte/src/compiler/phases/1-parse/read/context.js
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
1 year ago
225a5bfe50
set expression end to typeAnnotation end where appropriate ( #9566 )
...
* set expression end to typeAnnotation end where appropriate
* fix
* woops
* lint
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
1 year ago
459e4ff006
feat: native TypeScript support ( #9482 )
...
* add typescript support to parser
* fix
* unnecessary
* various
* transform assertions
* tweak
* prettier
* robustify
* fix
* see if this fixes the prettier stuff
* only parse ts in ts mode
* fixes
* fix
* fix
* fix
* fix
* more
* check
* changeset
* allow type annotations on all contexts
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
9926347ad9
fix: adjust static attribute regex ( #9552 )
...
Svelte 5 version of #9551
1 year ago
550cecf311
chore: shave off more bytes ( #9540 )
...
* shavings
* dro unused max safe int
* get rid of array_ref and object_ref
* extract STATUS_MASK
* fix test
* revert is_controlled change
* more run_all
1 year ago
bd2a586fea
chore: more transition code-golfing ( #9536 )
1 year ago
699c337908
Version Packages (next) ( #9535 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
5809ac6758
chore: rename internal object properties ( #9532 )
...
* chore: rename internal object properties
chore: rename internal object properties
order properties and add comments
add missing remove_in_transitions
* jsdoc
1 year ago
5458ea7735
Version Packages (next) ( #9530 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
b0588d7888
fix: address intro transition bugs ( #9528 )
...
* fix: address intro transition bugs
* fix: address intro transition bugs
1 year ago
298da65ed6
chore: more signal fine-tuning ( #9531 )
...
* chore: opt for two signal data-structures to reduce memory usage
1 year ago
bbd1a6c05a
chore: tune signals for better runtime perf ( #9529 )
1 year ago
a36dba7df0
Version Packages (next) ( #9519 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
f886bc133e
fix: handle intro global transition propagation correctly ( #9515 )
...
* fix: stop propagating global intros
* fix: stop propagating global intros
* add test
1 year ago
e0271f0fc7
Version Packages (next) ( #9492 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
3b2e6eac9a
fix: address unowned propagation signal issue ( #9510 )
...
* fix: address unowned propagation signal issue
* Add comments
1 year ago
378093941d
fix: ensure we visit assignments during compilation ( #9511 )
...
* fix: add missing visit for expressions
* fix: add missing visit for expressions
* Add test
1 year ago
4418ba6535
fix: add top level snippets to instance scope ( #9467 )
...
fixes #9460
1 year ago
1beb5e8dc9
fix: tweak script/style tag parsing/preprocessing logic ( #9502 )
...
Related to sveltejs/language-tools#2204 / sveltejs/language-tools#2039
The Svelte 5 version of #9486 and #9498
---------
Co-authored-by: Rich Harris <richard.a.harris@gmail.com>
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
c827b0c772
fix: only treat instance context exports as accessors ( #9500 )
...
* failing test for #9499
* limit export handling to instance context
* changeset
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
ede1edd314
fix: emit useful error on invalid binding to derived state ( #9497 )
...
closes #9495
1 year ago
37f249350c
allow setting files ( #9463 )
1 year ago
c823dd2efa
Version Packages (next) ( #9481 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
60c273eb76
Revert "fix: address bug in before/after update" ( #9480 )
...
* Revert "fix: address bug in before/after update (#9448 )"
This reverts commit 9eb969ddd4
1 year ago
7e94dee955
Version Packages (next) ( #9431 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
c1f6ee096d
fix: handle dynamic selects with falsy select values ( #9471 )
...
when options are added later, we need to ensure the select value still stays in sync
fixes #9412
1 year ago
19f84ca730
fix: Added missing context of `svelte.js` for validation ( #9394 )
...
* fix
* add changeset
* Update .changeset/eighty-bikes-camp.md
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
* Update .changeset/eighty-bikes-camp.md
---------
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Co-authored-by: Rich Harris <hello@rich-harris.dev>
1 year ago
555e8f845f
enforce treeshakeability ( #9430 )
...
* enforce treeshakeability
* fix
* appease the dweeby little hall monitor
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
455fa8950e
Code golf each transitions ( #9476 )
...
* chore: improve code size of transitions
* Add changeset
1 year ago
e3e1fef238
fix: stringify attribute values before comparison ( #9475 )
...
* fix: stringify attribute values before comparison
* simplify
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
d749685b0f
fix: rework directive name handling ( #9470 )
...
* move snapshot test to a runtime test
* handle dynamic cases
* huh
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
73e8820fe7
chore: make DOM operations lazily init ( #9468 )
...
* chore: make DOM operations lazyily init
* cleanup types
* cleanup types
* cleanup types
* Update packages/svelte/src/internal/client/operations.js
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
* single line annotations
* remove unnecessary coercion
* group statements by type
---------
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
9ef3424732
fix: support class exports ( #9465 )
1 year ago
6f3dc04c82
fix: allow member access on directives ( #9462 )
...
fixes #9445
1 year ago
9eb969ddd4
fix: address bug in before/after update ( #9448 )
...
* fix: address bug in before/after update
fix: address bug in before/after update
* Add changeset
* use every instead of filter - more explicit and enables early-exit from the loop
* Update logic and comment
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
f5101c0d8c
treat `slot` the same as other props - closes #9455 ( #9457 )
...
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
6f6c3a0787
fix: only escape attribute values for elements, not components ( #9456 )
...
* only escape attribute values for elements, not components - closes #9454
* changeset
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
e90ded677e
fix: allow svelte:self in snippets ( #9439 )
...
* fix: allow svelte:self in snippets
* Create funny-wombats-argue.md
1 year ago
73ae5ef5bc
fix: tighten up event attributes and hoisting logic ( #9433 )
...
- add event delegation to spread_attributes
- add event attributes to spread
- don't delegate when bindings/actions on the same element in order to preserve backwards compatibility of ordering
- don't hoist identifiers when one of them is used in an event that is not delegateable
---------
Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>
1 year ago
cf63220a0e
fix: ensure keyed fallback to indexed ( #9441 )
...
Fixes #9408 . Ensures that if we have a key that matches the index, that we fallback to using an indexed each block.
1 year ago
da37c928ef
fix: support dynamic attributes containing call expressions ( #9443 )
...
Fixes #9403 . We weren't taking into account the containment of call expressions logic before.
1 year ago
66661eff04
chore: use internal `get_descriptors` helper ( #9389 )
...
* chore: use internal get_descriptors helper
* tweak changeset
* fix bad merge
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
7ab03ae36c
fix: add missing files binding ( #9415 )
...
no two-way binding because setting it involves a `DataTransfer` workaround, so it's not really officially supported that way - if you need that, you shouldn't use that binding probably. This matches the behavior in Svelte 4.
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
9aa06bdf9e
fix: check that snippet is not rendered as a component ( #9423 )
...
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
1fd77d7494
Version Packages (next) ( #9386 )
...
* Version Packages (next)
* Update packages/svelte/CHANGELOG.md
---------
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Rich Harris <richard.a.harris@gmail.com>
1 year ago
a990e5716a
fix tsconfig.json ( #9427 )
...
* fix tsconfig.json
* prettier
* another apparently-necessary fix
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
5768df1300
chore: remove selector api ( #9426 )
...
* chore: remove selector api
1 year ago
17e6c4f834
fix: address runtime effect issues ( #9417 )
...
* Fix runtime effect issues
* Prettier
* Add changeset
* Fix operations
* Update .changeset/khaki-mails-draw.md
* more tweaks
* more tweaks
---------
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
1 year ago
8798f3b1e7
chore: split $.each into $.each_keyed/$.each_indexed ( #9422 )
...
* Split $.each into $.each_keyed/$.each_indexed
* Add changeset
* Update .changeset/quiet-camels-mate.md
* Fix typo
---------
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
1 year ago
5a6afe5463
fix: correct each block update index type ( #9425 )
...
* fix: correctly handle index within each block updates
* changeset
1 year ago
1daadc357d
chore: add missing svelte/transition functions ( #9391 )
...
* chore: add missing svelte/transition functions
* lint
1 year ago
9a99554379
breaking: remove Component type, keep using SvelteComponent instead ( #9413 )
...
I came to the conclusion that when we're making up arbitrary types, we might as well keep the old class. That way:
- one less thing to worry about (language tools and other tooling basically can continue to spit out SvelteComponent )
- we can more clearly mark $set , the constructor etc as being deprecated and no longer functioning unless you use that legacy compatibility mode
- much more ergonomic to type for the user:
- const someInstance: SvelteComponent<..> instead of const someInstance: ReturnType<typeof Component<..>>
- If you're using generics, you can do export class MyComponent<T> extends SvelteComponent<{ prop: T }> {} instead of having to type out the whole function in a way that I'm not even sure how to do with generics
1 year ago
7a84e78b4d
fix: add snippet symbol to children prop ( #9395 )
...
* add snippet symbol to children prop
* fix error message for snippet validation
* changeset
1 year ago
2aacfad9ae
fix: exclude internal props from spread attributes ( #9384 )
...
* exclude internal props from spread attributes
* changeset
* tighten up
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
51394a4834
docs: note more breaking changes
1 year ago
28b560392b
Version Packages (next) ( #9382 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
c6c934afb2
chore: cleanup ( #9381 )
...
* lets see if this works
* fix versions
* sigh
* debugging ci is sooo fun
* oh wow
* fix stuff, changelog, add back readme
* appease prettier
* format stuff
1 year ago
fe8a9ce31d
breaking: init Svelte 5
...
Co-authored-by: Rich Harris <rich.harris@vercel.com>
Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>
Co-authored-by: Dominic Gannaway <dg@domgan.com>
1 year ago
1369aa5cec
Version Packages ( #9380 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
00700621bb
fix: html tag hydration: regard empty claimed_nodes array as content mismatch ( #9184 )
...
fixes #6832
1 year ago
895612514c
fix: improve a11y-click-events-have-key-events message ( #9358 )
1 year ago
28d6b34598
chore: fix failing format linting ( #9338 )
1 year ago
590503044f
Version Packages ( #9293 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
6b9b8af050
fix: ignore comments while comparing nodes in node_match ( #9197 )
...
related to issue #9088
it doesn't solve the main problem of dependencies getting invalidated whenever value of a variable gets changed.
but it fixes the behavior difference between the code with and without comments
1 year ago
ab80d9d214
fix: add missing plaintext-only value to contenteditable type ( #9242 )
...
fixes #9181
1 year ago
16c42cb085
fix: add transform-origin to SVGAttributes ( #9326 )
...
See https://svgwg.org/svg2-draft/styling.html#PresentationAttributes
1 year ago
9900c85acf
fix: support camelCase properties on custom elements ( #9328 )
...
while attributes are case insensitive, properties are not. to not introduce a breaking change, the lowercased variant is checked first.
fixes #9325
1 year ago
4efec418c2
chore: bump jsdom to address word-wrap vulnerability ( #9046 )
...
* chore: bump jsdom to address word-wrap vulnerability
* downgrade jsdom
* fix lockfile
1 year ago
052d38158f
chore: upgrade magic-string ( #9292 )
1 year ago
acb93568b0
docs: fix typo in `Action` jsdoc ( #9254 )
1 year ago
bd5e5eef9b
Version Packages ( #9121 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
26eb2a2f89
fix: false reactive component warning ( #9094 )
...
fixes #9082
1 year ago
93b17c85f7
fix: spreading attributes on option value attribute get's replaced by option's inner text ( #9125 )
...
fixes #9107
Apart from the problem with the option the same happens with the textarea.
1 year ago
228dd4d9d7
fix: svelte:element with dynamic this and spread attributes throws error ( #9112 )
...
fixes #9092
---------
Co-authored-by: gtmnayan <50981692+gtm-nayan@users.noreply.github.com>
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
1 year ago
3191147c2a
chore: document init parameters ( #9118 )
1 year ago
6fe17eabf2
fix: This makes the indeterminate HTML attribute available for use. Fixes #9176 . ( #9180 )
...
Fixes #9176 . This adds indeterminate to the list of HTMLAttributes so that one can use it without receiving an error.
1 year ago
d5a1822428
fix: style directive not updating when style attribute is present and style directive is updated via an object prop. fixes #9185 ( #9187 )
...
fixes #9185 .
I narrowed down the issue to the bug surfacing when we use object properties to update style attributes and directives. This fix removes the size check (because a single object will be of size 1 but can affect n attributes/directives via its properties).
In addition, the order of the OR is switched as the earlier condition has some reactive assignments which are not run in the current order when style_changed_var is truthy.
1 year ago
115ea1ff4a
fix: do not add module declared variables as dependencies ( #9122 )
...
closes #5943
1 year ago
b62fc8c8fd
chore: eslint rule for naming convention ( #9208 )
1 year ago
d5839ef194
fix: head duplication when binding is present ( #9124 )
...
fixes #7879
fixes #4982
1 year ago
bd64f07e98
fix: take custom attribute name into account when reflecting property ( #9140 )
...
fixes #9134
1 year ago
3d3680cd11
chore: move playground ( #9131 )
1 year ago
d06cfe3723
chore: render head output in playground ( #9123 )
1 year ago
ba1e67844e
fix: css sourcemap generation with unicode filenames ( #9120 )
...
* fix: css sourcemap generation with unicode filenames
* format
1 year ago
50c270a54d
Version Packages ( #9096 )
...
---------
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
1 year ago
05f99d20f9
feat: move svelteHTML to load the correct svelte/element ( #9070 )
...
Make IntrinsicElements extends SvelteHTMLElements
so it can be extend with declare module
converting to module so it can extend without needing another type alias
---------
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
1 year ago
8b1cdde548
fix:change typescript url ( #9093 )
1 year ago
f4c4d99e13
fix: add test so #6009 doesn't regress ( #9075 )
...
closes #6009
1 year ago
6f73afb497
chore: refactor return statement in `_distance` function ( #9025 )
...
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
1 year ago
a08ae0f555
Version Packages ( #9037 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
99a3cc93b6
fix: allow child element with slot attribute within svelte:element ( #9038 )
...
fix #9018
1 year ago
01cbb661d0
chore: remove duplicate condition in `if` statement ( #9023 )
1 year ago
959825c7c4
chore: fix tests on Node 18.17.0 ( #9049 )
1 year ago
a71f3595a3
fix: Add data-* to svg attributes ( #9036 )
...
* Add data-* to svg attributes
* Create twelve-suits-drive.md
2 years ago
6827709373
Version Packages ( #9008 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2 years ago
a2b6401c43
fix: `svelte:component` spread props change not picked up ( #9006 )
...
fix #9003 , amend #8946 (comment)
2 years ago
5d66f96d01
Version Packages ( #8928 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2 years ago
f8283fbc77
fix: remove let variable from select binding dependencies ( #8969 )
...
Fixes #2943
The issue linked above invalidates a variable that is not defined in <script> but instead is defined as a let: variable, which does not make sense to invalidate, therefore, this PR exists.
2 years ago
cb1358cc41
fix: don't add accessor twice ( #8996 )
...
In dev mode, Svelte creates a setter to throw an error noting that you can't set that readonly prop, which resulted in the accessor getting applied twice to the custom element wrapper, causing an error
fixes #8971
2 years ago
657f11376c
feat: add ability to extend custom element class ( #8991 )
...
This should help everyone who has special needs and use cases around custom elements. Since Svelte components are wrapped and only run on connectedCallback, it makes sense to expose the custom element class for modification before that.
- fixes #8954 / closes #8955 - use extend to attach the function manually and save possible values to a prop
- closes #8473 / closes #4168 - use extend to set the proper static attribute and then call attachInternals in the constructor
- closes #8472 - use extend to attach anything custom you need
- closes #3091 - pass `this` to a prop of your choice and use it inside your component
- add some doc for #8987
2 years ago
4bbb5454e2
perf: optimize imports that are not mutated or reassigned ( #8948 )
...
this means such imports are seen as static and subsequently Svelte needs to generate way less code
2 years ago
33fd631b5f
chore: upgrade dependencies ( #8939 )
...
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
2 years ago
20dac2ae12
fix: handle patterns in destructured literals ( #8871 )
...
fixes #8863
---------
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
2 years ago
66593c62f4
fix: svelte:component evaluates props once ( #8946 )
...
Fixes #6634
2 years ago
ff7a4c07d7
chore: fix broken script for generating parser tests ( #8945 )
...
---------
Co-authored-by: gtmnayan <50981692+gtm-nayan@users.noreply.github.com>
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
2 years ago
8601195a85
docs: add a couple internal JSDocs and cleanup from TS migration ( #8940 )
2 years ago
3ff0084dc3
Version Packages ( #8925 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2 years ago
0a2732a2b0
fix: generate type definition with nullable types ( #8924 )
...
This results in `undefined` and `null` being added explicitly in places which is crucial in some situations
2 years ago
a12643cbb8
Version Packages ( #8911 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2 years ago
136aebd8eb
fix: repair invalid raw html content during hydration ( #8912 )
...
When the HTML that is coming from raw html is invalid, the browser reshuffles things. Bail in that case to try to repair more often. Should help with https://github.com/withastro/astro/issues/7557
2 years ago
35221c8811
fix: claim svg tags in raw mustache tags correctly ( #8910 )
...
fixes #8904
2 years ago
800f6c076b
Version Packages ( #8902 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2 years ago
8de9dc6144
fix: handle falsy srcset values ( #8901 )
...
fixes #8899
2 years ago
ae752c9693
Version Packages ( #8877 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2 years ago
0aa03df086
fix: reflect all custom element prop updates back to attribute ( #8898 )
...
fixes #8879
2 years ago
4b3eb72346
fix: shrink custom element baseline a bit ( #8858 )
...
- use shorter class property names as they are not minified
- reuse some dom helper methods
#8826
2 years ago
2f5e371046
chore: run tsc properly ( #8884 )
...
Runs type check as part of the CI. This needs a new path alias in the tsconfig so that TS resolves the svelte import in the ambient file directly to the correct d.ts file and doesn't load Svelte through the node_modules, at which point it would load the generated ambient type definitions and throw a duplicate definitions error.
Also removes a tgz that was accidentally added
2 years ago
d2ff04f9fe
fix: use non-destructive hydration for all `@html` tags ( #8880 )
...
html tags that could be optimized to use innerHTML in mount ignored any hydration code, which leads to everything getting unmounted and mounted again. This takes the non-optimized path for hydration, too.
fixes https://github.com/sveltejs/kit/issues/10245
2 years ago
1a3e50b6b7
fix: check srcset when hydrating to prevent needless requests ( #8868 )
...
---------
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
2 years ago
270cfce065
chore: adding default for disclose version ( #8874 )
2 years ago
1de2144dae
chore: tests for #8872
2 years ago
90860550ae
Version Packages ( #8855 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2 years ago
b0a3fa1766
fix: ensure createEventDispatcher and ActionReturn work with generic function types ( #8872 )
...
fixes #8860
This contains a small but unfortunately unavoidable breaking change: If you used `never` to type that the second parameter of `createEventDispatcher` shouldn't be set or that the action accepts no parameters (which the docs recommended for a short time), then you need to change that to `null` and `undefined` respectively
2 years ago
1cfed0bf29
fix: relax a11y "no redundant role" rule for li, ul, ol ( #8867 )
...
fixes #8854
2 years ago
876f894c64
fix: apply transition_in/out to svelte:element with local transition ( #8865 )
...
fixes #8233
2 years ago
2b9b99bd35
fix: remove tsconfig.json from published package ( #8859 )
...
fixes #8839
2 years ago
3576c7443e
fix: Make sure 'func' doesn't clash with destructured contexts ( #8840 )
...
Fixes : #8753
2 years ago
68e6336637
chore: upgrade dependencies ( #8827 )
2 years ago
abe2ee73e1
docs: fix link to changelog ( #8845 )
2 years ago
7bab2d4033
docs: fix link in changelog
2 years ago
037ac2f55a
docs: update transitions tutorial ( #8822 )
...
fixes #8820
2 years ago
140bed5386
Update CHANGELOG.md ( #8809 )
...
Fix misformatted links in 4.0.0 changelog
2 years ago
0596c4797d
Version Packages ( #8799 )
...
---------
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
2 years ago
60eee9a73f
chore: better error messages for CJS users ( #8790 )
2 years ago
8905877bab
fix: add any fallback to generic
...
was like this in Svelte 3
2 years ago
7cbd36d6b2
chore: Remove the need for `node:process` ( #8795 )
...
performance.now() exist in all envs we support now
2 years ago
82cc48390c
Version Packages (next) ( #8772 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2 years ago
ef1b98f9d9
fix: account for sourcemap in meta info ( #8778 )
...
We need to use a different method for getting the meta info because `locate` is used to help construct the source map that references the preprocessed Svelte file. If we would now add source maps to that `locate` function it would go the the original source directly which means skipping potentially intermediate source maps which we would need in other situations. Sadly we can't map the character offset because for that we would need to the original source contents which we don't have in this context.
fixes #8360
closes #8362
2 years ago
5702142d9e
feat: attach Svelte major version info to window global ( #8761 )
...
Can be opt out by setting discloseVersion to false
---------
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
2 years ago
03942162f8
chore: deindent cjs output for compiler ( #8785 )
...
makes package size a tiny bit smaller
2 years ago
f76a75b97d
chore: remove btoa fallback ( #8783 )
...
Since we're targeting NodeJS >16 we don't need any Buffer fallback as it's now built in globally from that version onwards.
2 years ago
cf32fa2497
fix(site): update tutorial links ( #8780 )
...
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
2 years ago
203490c3e4
breaking: use `CustomEvent` constructor instead of deprecated `createEvent` method ( #8775 )
...
closes #8474
2 years ago
78749101e7
fix: update/add links to website ( #8729 )
...
---------
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>
2 years ago
de8dfda049
chore: move tests to the correct place ( #8773 )
2 years ago
4d491d41cc
merge changelog for 3.59.2
2 years ago
a856128d80
merge master
2 years ago
914529fa76
feat: smaller destructor chunk ( #8763 )
...
technically a breaking change because someone with a mutation observer could rely on the order of operations
---------
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
2 years ago
88504ee90a
docs(sites): Auto-generated CompileOptions ( #8756 )
...
---------
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>
2 years ago
54f72f4545
fix: update onMount type to allow async to return any ( #8714 )
...
---------
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
2 years ago
0724261b4d
chore: update code-red ( #8719 )
...
---------
Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>
Co-authored-by: gtmnayan <gtmnayan@gmail.com>
2 years ago
752ee69e6b
chore: a11y tests cleanup ( #8759 )
...
closes #8728
Turns out all the removed previous test failures are indeed correct to be removed, according to the test adjustments in https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/pull/937
2 years ago
520a5784fb
Version Packages (next) ( #8733 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2 years ago
cc82d5ddcb
fix: expose types for all TS resolution modes, fix SvelteComponent export ( #8721 )
...
also add some legacy import paths which should be changed in usage sites ASAP
---------
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>
2 years ago
aa8cc5d26f
fix: never use html optimization for mustache tags in hydration mode ( #8744 )
...
---------
Co-authored-by: gtmnayan <gtmnayan@gmail.com>
2 years ago
bdf10f125c
merge
2 years ago
e8e9c6cc19
chore: update `locate-character` and `dts-buddy` ( #8737 )
2 years ago
62bef809b2
Merge remote-tracking branch 'origin/version-4' into sites
2 years ago
c587c8aaaa
docs: note limitations of not using shadow root ( #8734 )
...
closes #8686
2 years ago
4f1063723e
fix: Don't break in `attributeChangedCallback` if `$$component` does not exist yet ( #8701 )
...
Since the custom element class waits one tick before instantiating the `$$component` field, it's possibly undefined when `attributeChangedCallback` is called.
2 years ago
f580e2e0c8
fix: warn on boolean compilerOptions.css ( #8710 )
...
* warn on boolean compilerOptions.css
* changeset
2 years ago
20d95ddb23
merge
2 years ago
b1cafc4573
update type generation script ( #8712 )
...
* chore: playground (#8648 )
* initialize playground
* pnpm up
* tidy up git ignore
* remove fluff
* format
* rm readme
* fix jsconfig error
* add skip-worktree instructions
* reload hack
* simplify
* use rollup
* ughh
* add flag for SSR
* ...
* simplify further
* configure launch.json
* add debugger info to readme
* remove vm modules flag
* use replaceAll instead of replace
* tidy up
* fix: make it run
* add watch to launch config
* Generate type declarations with `dts-buddy` (#8702 )
* use dts-buddy
* remove debug output
* remove existing type generation script
* fix package.json
* update gitignore
* bump dts-buddy
* remove unused action entry point
* add svelte/compiler and svelte/types/compiler/preprocess modules
* bump dts-buddy
* annoying
* changeset
* bump dts-buddy
* get rid of .d.ts files
* another one
* Update packages/svelte/package.json
Co-authored-by: gtmnayan <50981692+gtm-nayan@users.noreply.github.com>
---------
Co-authored-by: Rich Harris <git@rich-harris.dev>
Co-authored-by: gtmnayan <50981692+gtm-nayan@users.noreply.github.com>
* fix: export ComponentType (#8694 )
* fix: export ComponentType
* ughh
* changeset
* fix: derived types (#8700 )
* fix: derived store types
* changeset
* Version Packages (next) (#8709 )
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* update type generation script
* remove unused stuff
* fix: changeset publish script isn't called release anymore (#8711 )
* chore: remove prepare script (#8713 )
* chore: fix release workflow (#8716 )
* More readable, Fix $$_attributes
* Fix types (#8727 )
* put comment in right place
* bump dts-buddy
---------
Co-authored-by: Rich Harris <git@rich-harris.dev>
* build types
* add svelte/compiler types
* remove prepare script
* fix
* typo
* squelch errors
* Add svelte and kit to twoslash's types field
* squelch more stuff
* Add errors to account for new types
* Remove deps
* formatting tweak
* fix linting, maybe
* the hell
* gah
* Fix types a bit
* bump dts-buddy
* pnpm generate in dev mode
* Cache again
* reduce index
* bump dts-buddy
* remove comment
---------
Co-authored-by: gtmnayan <50981692+gtm-nayan@users.noreply.github.com>
Co-authored-by: Rich Harris <git@rich-harris.dev>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Dominik G <dominik.goepel@gmx.de>
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Co-authored-by: Puru Vijay <devpuruvj@gmail.com>
2 years ago
83e91782e6
chore: upgrade aria-query and axobject-query ( #8724 )
...
Co-authored-by: gtmnayan <gtmnayan@gmail.com>
2 years ago
cc1f4bc6ff
chore: upgrade eslint config ( #8717 )
2 years ago
d6f0b7bd5b
Fix types ( #8727 )
...
* put comment in right place
* bump dts-buddy
---------
Co-authored-by: Rich Harris <git@rich-harris.dev>
2 years ago
ad9a672171
Merge version-4
2 years ago
Simon H
Nguyen Tran
Dominic Gannaway
github-actions[bot]
navorite
Simon Holthausen
Jeremy Deutsch
Rich Harris
Holger Dal Mogensen
S. Elliott Johnson
Tom
adiGuba
Dani Sandoval
Mike Tunik
Jirawat Boonkumnerd
gtmnayan
Rich Harris
Ignatius Bagus
Yuichiro Yamashita
Theodore Brown
Tee Ming
Paolo Ricciuti
Wilson Hobbs
Kelvin Soh
Ben McCann
Sina Salahshour
vhladko
Mathias Schäfer
Diego Augusto Molina
Teo
paulreece
Yeom suyun
Lyu, Wei-Da
hackape
Conduitry
L
Eric Liu
Isaiah Banks
Jimmy Wärting
Puru Vijay
GrygrFlzr
Puru Vijay
mimbrown