svelte

Commit Graph

Author	SHA1	Message	Date
Conduitry	4e29eee4b0	chore: pin aria-query@5.3.1 (#17772 ) The only change between 5.3.1 and 5.3.2 is `2106d5e872` to support versions of Node before 4, with the cost of a minuscule but pointless performance hit. This is a pretty stable library, and there have been no further changes in the ensuing year and a half, so it seems pretty safe to pin to the previous version. ### Before submitting the PR, please make sure you do the following - [ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`. - [x] This message body should clearly illustrate what problems it solves. - [ ] Ideally, include a test that fails without this PR but passes with it. - [ ] If this PR changes code within `packages/svelte/src`, add a changeset (`npx changeset`). ### Tests and linting - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint`	2 days ago
github-actions[bot]	69e6c4cdbb	Version Packages (#17768 ) This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## svelte@5.53.2 ### Patch Changes - fix: update expressions on server deriveds ([#17767](https://github.com/sveltejs/svelte/pull/17767)) - fix: further obfuscate `node:crypto` import from overzealous static analysis ([#17763](https://github.com/sveltejs/svelte/pull/17763)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	3 days ago
Conduitry	d75d1f7dbb	fix: further obfuscate `node:crypto` import from overzealous static analysis (#17763 ) Fixes #17762, hopefully	3 days ago
Paolo Ricciuti	6aa7b9c64a	fix: update expressions on server deriveds (#17767 ) Closes #17760	3 days ago
github-actions[bot]	d258f85235	Version Packages (#17755 ) This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## svelte@5.53.1 ### Patch Changes - fix: handle shadowed function names correctly ([#17753](https://github.com/sveltejs/svelte/pull/17753)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	3 days ago
Simon H	0c7f815143	fix: handle shadowed function names correctly (#17753 ) Fixes #17750 (though the change that causes the issue only surfaced this more general bug) We were not adding the correct scope to function ids. Instead it was part of the function body/params scope, which leads to bugs when the function name is shadowed within the function.	5 days ago
Simon H	7106da4dd2	chore: fix changelog (#17754 ) unescaped select made everything go boom closes #17748	5 days ago
Theodor Steiner	c98ce6945d	docs: migrate <svelte:document> to use attachment instead of action (#17749 ) ## Motivation noticed that the documentation for the `<svelte:document>` still refers to actions - probably would be better for beginners if it referred to the newer attachments instead. ### Before submitting the PR, please make sure you do the following - [ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`. - [x] This message body should clearly illustrate what problems it solves. - [ ] Ideally, include a test that fails without this PR but passes with it. - [ ] If this PR changes code within `packages/svelte/src`, add a changeset (`npx changeset`). ### Tests and linting - [ ] Run the tests with `pnpm test` and lint the project with `pnpm lint`	5 days ago
github-actions[bot]	c2fc95a467	Version Packages (#17747 ) This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## svelte@5.53.0 ### Minor Changes - feat: allow comments in tags ([#17671](https://github.com/sveltejs/svelte/pull/17671)) - feat: allow error boundaries to work on the server ([#17672](https://github.com/sveltejs/svelte/pull/17672)) ### Patch Changes - fix: use TrustedHTML to test for customizable <select> support, where necessary ([#17743](https://github.com/sveltejs/svelte/pull/17743)) - fix: ensure head effects are kept in the effect tree ([#17746](https://github.com/sveltejs/svelte/pull/17746)) - chore: deactivate current_batch by default in unset_context ([#17738](https://github.com/sveltejs/svelte/pull/17738)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	6 days ago
Rich Harris	92e2fc1209	feat: allow comments in tags (#17671 ) Alternative to #17188. I prefer this syntax, it's lighter and feels much more natural to me. For me it's less about commenting things _out_ than about just, well... commenting — I frequently want to do this sort of thing: ```svelte <button // when the user clicks the button, the thing should happen onclick={doTheThing} >click me</button> ``` One difference between this and #17188 is that this doesn't add a node to the AST, just like comments in CSS/JS. Haven't decided if that's desirable or not. I think it's more correct (it's an AST, not a CST; HTML comments are different insofar as they _can_ represent 'real' nodes) but it might be less convenient when (for example) pretty-printing. ### Before submitting the PR, please make sure you do the following - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`. - [x] This message body should clearly illustrate what problems it solves. - [x] Ideally, include a test that fails without this PR but passes with it. - [x] If this PR changes code within `packages/svelte/src`, add a changeset (`npx changeset`). ### Tests and linting - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint` --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>	6 days ago
Simon H	2661513cd3	feat: allow error boundaries to work on the server (#17672 ) This makes error boundaries run on the server if a new `onerror` handler is passed to `render`. `onerror` can either synchronously or asynchronously return a value. It should be a sanitized JSON.stringify-able value so that it can be passed to the client for hydration via a comment. `mount/hydrate` also get the `onerror` property. If no `onerror` is passed to `render` it will just throw just like before, hence this is backwards compatible. This work is important for SvelteKit to allow `+error.svelte` to make use of them and in general to make boundaries properly work during SSR (also see https://github.com/sveltejs/kit/issues/14398). closes #15370 ### Before submitting the PR, please make sure you do the following - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`. - [x] This message body should clearly illustrate what problems it solves. - [x] Ideally, include a test that fails without this PR but passes with it. - [x] If this PR changes code within `packages/svelte/src`, add a changeset (`npx changeset`). ### Tests and linting - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint` --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	6 days ago
Simon H	582e4443dc	fix: ensure head effects are kept in the effect tree (#17746 ) Fixes #17726 The problem was that the head effect had no "keep me around"-flag, which it needs because its children are not guaranteed to be present immediately - as shown in the related issue, where the child effect is only created once async work has completed. ### Before submitting the PR, please make sure you do the following - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`. - [x] This message body should clearly illustrate what problems it solves. - [x] Ideally, include a test that fails without this PR but passes with it. - [x] If this PR changes code within `packages/svelte/src`, add a changeset (`npx changeset`). ### Tests and linting - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint`	6 days ago
Rich Harris	f8bf9bb461	chore: deactivate current_batch by default in unset_context (#17738 ) Small tweak: except for `{#await ...}` blocks, which are a bit of an anomaly, I'm pretty sure we _always_ want to deactivate the current batch when unsetting context, otherwise it could incorrectly pick up unrelated state changes. There might even be some subtle bugs lurking in the system at present because we _don't_ always do this ### Before submitting the PR, please make sure you do the following - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`. - [x] This message body should clearly illustrate what problems it solves. - [ ] Ideally, include a test that fails without this PR but passes with it. - [x] If this PR changes code within `packages/svelte/src`, add a changeset (`npx changeset`). ### Tests and linting - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint`	6 days ago
Rich Harris	696d97ff3e	fix: use TrustedHTML to test for customizable <select> support, where necessary (#17743 ) https://github.com/sveltejs/svelte/pull/17701#issuecomment-3899991195 no test because jsdom	6 days ago
github-actions[bot]	cbf4e246fc	Version Packages (#17742 ) This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## svelte@5.52.0 ### Minor Changes - feat: support TrustedHTML in `{@html}` expressions ([#17701](https://github.com/sveltejs/svelte/pull/17701)) ### Patch Changes - fix: repair dynamic component truthy/falsy hydration mismatches ([#17737](https://github.com/sveltejs/svelte/pull/17737)) - fix: re-run non-render-bound deriveds on the server ([#17674](https://github.com/sveltejs/svelte/pull/17674)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	6 days ago
Rich Harris	09c4cb5084	fix: re-run non-render-bound deriveds on the server (#17674 ) I tried to bring #14977 up-to-date but it's slipped too far. Also, I wanted to try a slightly different approach. In this PR, deriveds are memoized if they're created during render — in other words if you have something like this... ```svelte <script> let thing = $derived(expensivelyComputeThing()); </script> ``` ...`thing` will only be computed once. This seems correct since the inputs should never change during render. For deriveds created _outside_ render, we re-run the derived each time it is accessed, which fixes #14954. This way, there's still _some_ overhead compared to how deriveds work in the browser (where they only recompute when their dependencies have changed), but only in the rare places where it is necessary. There is one wrinkle: writable deriveds. On `main` these are just regular old variables, which means they can be written to during render. This PR currently preserves that behaviour, but I'm not sure it's desirable. It prevents the values of non-render-bound deriveds from ever updating, and makes no sense in the context of render-bound deriveds since they shouldn't be changing during render _anyway_. So my preference would be to disallow writes to deriveds on the server, but I'm not sure if we would need to consider that a breaking change. Draft because of that question, and also because I think we might be able to tidy up some stuff around class fields. - [x] figure out if we can delete some existing code around derived class fields - [x] figure out what to do about writable deriveds - [x] add a test ### Before submitting the PR, please make sure you do the following - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`. - [x] This message body should clearly illustrate what problems it solves. - [x] Ideally, include a test that fails without this PR but passes with it. - [x] If this PR changes code within `packages/svelte/src`, add a changeset (`npx changeset`). ### Tests and linting - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint`	6 days ago
Rich Harris	be24b0dca7	feat: support TrustedHTML in {@html} expressions (#17701 ) Follow-up to #16271. ## Summary - Allow `{@html}` blocks to accept `TrustedHTML` objects (from TrustedTypes policies) without coercing them to strings - This enables usage like `{@html myPolicy.createHTML(someHTML)}` - Works in regular HTML, SVG, and MathML contexts ## Changes - `html.js`: Instead of calling `create_fragment_from_html`, create the wrapper element directly (`<template>`, `<svg>`, or `<math>` depending on context) and assign the value to `innerHTML`. This preserves `TrustedHTML` objects. - `reconciler.js`: Removed the `trusted` parameter from `create_fragment_from_html` since it's no longer used by `{@html}` and all remaining callers want trusted HTML. - `template.js` and `snippet.js`: Removed the second argument from `create_fragment_from_html` calls. ## Notes No tests added because JSDOM doesn't implement TrustedTypes.	6 days ago
Simon H	9f48e7620f	fix: repair dynamic component truthy/falsy hydration mismatches (#17737 ) Fixes #17735 Use the if/else hydration markers to know what "branch" (component or no component) was rendered, and repair if differing. ### Before submitting the PR, please make sure you do the following - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`. - [x] This message body should clearly illustrate what problems it solves. - [x] Ideally, include a test that fails without this PR but passes with it. - [x] If this PR changes code within `packages/svelte/src`, add a changeset (`npx changeset`). ### Tests and linting - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint`	6 days ago
github-actions[bot]	8ea33bf7fe	Version Packages (#17740 ) This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## svelte@5.51.5 ### Patch Changes - fix: check to make sure `svelte:element` tags are valid during SSR ([`73098bb26c6f06e7fd1b0746d817d2c5ee90755f`](`73098bb26c`)) - fix: misc option escaping and backwards compatibility ([#17741](https://github.com/sveltejs/svelte/pull/17741)) - fix: strip event handlers during SSR ([`a0c7f289156e9fafaeaf5ca14af6c06fe9b9eae5`](`a0c7f28915`)) - fix: replace usage of `for in` with `for of Object.keys` ([`f89c7ddd7eebaa1ef3cc540400bec2c9140b330c`](`f89c7ddd7e`)) - fix: always escape option body in SSR ([`f7c80da18c215e3727c2a611b0b8744cc6e504c5`](`f7c80da18c`)) - chore: upgrade `devalue` ([#17739](https://github.com/sveltejs/svelte/pull/17739)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	6 days ago
Elliott Johnson	f855a0b770	fix: misc option escaping and backwards compatibility (#17741 ) ### Before submitting the PR, please make sure you do the following - [ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [ ] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`. - [ ] This message body should clearly illustrate what problems it solves. - [ ] Ideally, include a test that fails without this PR but passes with it. - [ ] If this PR changes code within `packages/svelte/src`, add a changeset (`npx changeset`). ### Tests and linting - [ ] Run the tests with `pnpm test` and lint the project with `pnpm lint`	6 days ago
Elliott Johnson	781052eeab	chore: upgrade `devalue` (#17739 ) ### Before submitting the PR, please make sure you do the following - [ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [ ] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`. - [ ] This message body should clearly illustrate what problems it solves. - [ ] Ideally, include a test that fails without this PR but passes with it. - [ ] If this PR changes code within `packages/svelte/src`, add a changeset (`npx changeset`). ### Tests and linting - [ ] Run the tests with `pnpm test` and lint the project with `pnpm lint`	6 days ago
Paolo Ricciuti	f7c80da18c	Merge commit from fork	6 days ago
Elliott Johnson	a0c7f28915	Merge commit from fork * fix: strip event handlers during SSR * whatever conduitry you're not that cool * tweak	6 days ago
Elliott Johnson	73098bb26c	Merge commit from fork * fix: check to make sure `svelte:element` tags are valid during SSR * fix: error instead of warn * better sharing * nit	6 days ago
Elliott Johnson	f89c7ddd7e	Merge commit from fork Co-authored-by: Rich Harris <rich.harris@vercel.com>	6 days ago
github-actions[bot]	b8f2b86105	Version Packages (#17733 ) This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## svelte@5.51.4 ### Patch Changes - chore: proactively defer effects in pending boundary ([#17734](https://github.com/sveltejs/svelte/pull/17734)) - fix: detect and error on non-idempotent each block keys in dev mode ([#17732](https://github.com/sveltejs/svelte/pull/17732)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	6 days ago
Rich Harris	c83aa06d69	chore: proactively defer effects in pending boundary (#17734 ) Currently, (render/template) effects inside pending boundaries are deferred, but in an indirect manner: first we schedule them, then we `flush` the current batch, and in the course of traversing the effect tree we find any dirty effects and defer them at the level of the topmost pending boundary. This doesn't really make sense — we can just skip to the end state and skip the scheduling/traversal, since the effects don't become relevant until the boundary resolves. This PR implements that. It is a stepping stone towards a larger refactor, in which scheduling becomes batch-centric and lazier. While it shouldn't change any observable behaviour, I've added a changeset out of an abundance of caution. ### Before submitting the PR, please make sure you do the following - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`. - [x] This message body should clearly illustrate what problems it solves. - [ ] Ideally, include a test that fails without this PR but passes with it. - [x] If this PR changes code within `packages/svelte/src`, add a changeset (`npx changeset`). ### Tests and linting - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint`	7 days ago
Rich Harris	2287ad005a	fix: detect and error on non-idempotent each block keys in dev mode (#17732 ) ## Summary Fixes #17721 In dev mode, detect when a keyed each block has a key function that returns different values when called multiple times for the same item (non-idempotent). This catches the common mistake of using array literals like `[thing.group, thing.id]` as keys, which creates a new array object each time and will never match by reference. - Adds new `each_key_volatile` error with helpful message explaining the issue - Checks key idempotency in the each block loop during dev mode - Provides a clear error instead of the cryptic "Cannot read properties of undefined" that occurred previously --------- Co-authored-by: 7nik <kifiranet@gmail.com>	7 days ago
Rich Harris	3f6521df0e	chore: unify async logic (#17731 ) We have a bunch of repeated logic around incrementing/decrementing pending states. This DRYs it out to unblock some forthcoming changes around scheduling	1 week ago
Rich Harris	bd4ba56932	chore: make batch.is_deferred a private method (#17729 ) small tweak	1 week ago
github-actions[bot]	04c0368aa8	Version Packages (#17725 ) This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## svelte@5.51.3 ### Patch Changes - fix: prevent event delegation logic conflicting between svelte instances ([#17728](https://github.com/sveltejs/svelte/pull/17728)) - fix: treat CSS attribute selectors as case-insensitive for HTML enumerated attributes ([#17712](https://github.com/sveltejs/svelte/pull/17712)) - fix: locate Rollup annontaion friendly to JS downgraders ([#17724](https://github.com/sveltejs/svelte/pull/17724)) - fix: run effects in pending snippets ([#17719](https://github.com/sveltejs/svelte/pull/17719)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	1 week ago
Rich Harris	e47c747338	fix: prevent event delegation logic conflicting between svelte instances (#17728 ) Fixes https://github.com/sveltejs/svelte.dev/issues/1793. There are actually two fixes here, and either is sufficient to fix the playground, but they are complementary. First, we only add the delegated event handler _after_ the component has successfully mounted, otherwise it will never get cleaned up if an error occurs during mount. Second, instead of storing data on `event.__root` (which leaks between instances), we reuse the existing `event_symbol` to provide the necessary encapsulation. (I'll be honest I don't totally understand what this property is for anyway and can't be bothered to figure it out right now, but I'm sure it's important.) No test because I'm not really sure how you _would_ test this; it requires a fairly esoteric setup. ### Before submitting the PR, please make sure you do the following - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`. - [x] This message body should clearly illustrate what problems it solves. - [ ] Ideally, include a test that fails without this PR but passes with it. - [x] If this PR changes code within `packages/svelte/src`, add a changeset (`npx changeset`). ### Tests and linting - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint` --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>	1 week ago
Varun Chawla	60a425193c	fix: treat CSS attribute selectors as case-insensitive for HTML enumerated attributes (#17712 ) Fixes #17207 CSS attribute selectors for HTML enumerated attributes (like `method`, `type`, `dir`, etc.) are supposed to match case-insensitively per the HTML spec. Browsers handle this correctly — `form[method="get"]` matches `<form method="GET">`. But Svelte's CSS pruning was doing a strict case-sensitive comparison, which meant: 1. The selector got incorrectly flagged as unused (no `css_unused_selector` warning was shown when spreads were involved, but the selector was still pruned) 2. The scoping class wasn't applied to the matching element 3. Styles silently disappeared in production builds The fix adds a set of known HTML attributes with case-insensitive enumerated values (sourced from the HTML spec) and uses it during CSS attribute selector matching. The explicit CSS `s` flag still overrides this behavior, as expected. ### Before ```svelte <form method="GET"> <h1>Hello</h1> </form> <style> form[method="get"] h1 { color: red; } /* ^ incorrectly pruned, <h1> not styled */ </style> ``` ### After The selector correctly matches and styles are applied. ### Test plan - Added `attribute-selector-html-case-insensitive` CSS test covering `form[method]` and `input[type]` cases - All 179 existing CSS tests pass - Verified the existing `attribute-selector-case-sensitive` test (using `s` flag) still works correctly - Compiler error tests and validator tests all pass --------- Co-authored-by: Rich Harris <hello@rich-harris.dev> Co-authored-by: Rich Harris <rich.harris@vercel.com>	1 week ago
Rich Harris	6557a0a591	fix: run effects in pending snippets (#17719 ) Boundaries are buggy: if the `pending` snippet contains state, changes to that state [won't cause updates](https://svelte.dev/playground/hello-world?version=5.51.2#H4sIAAAAAAAAE22SQW-DMAyF_0qUTSpoE92uFJh223Hate0hJWaNliZRYsoqxH9fQtJW6noD-33Pz4aRKnYAWtIPkFKTQVvJSQZcIPCcPtNOSHC0XI8UTyboQsHXE_VuTOGOIDHUdszBvXqrFYJCb0Mr11phsNmoDUpAYsFpeQTrSE3W25Uv-0bXqxaFVsT0bp8dmewhJ2PobNB7OSQcOrAWuKc-rT4IB8UgcP91dsvyVZRf_IvZK8tJ3VzoInXTiCuDvVVXlYkT5u50k9DtRYfZJd11XGq8FSlKAsPOre4V-uSPDhlC9hIE1fJ6GFXtekRvrlUrRftTjzF25J5q8jrN9xOqtXDwhw14RO7jc5bIzI-3-vihyp3358yeZmFlmpENTGD8CIu0GV_kU7U0TdxmfHBKGON3MqC4UN9ZPsVDBHzOe1bjuEzaad7230j_nyD8Ii3R9jBt_RsTchCK07Jj0sH0B6hNF6aqAgAA): ```svelte <script> let resolvers = []; function push(value) { const deferred = Promise.withResolvers(); resolvers.push(() => deferred.resolve(value)); return deferred.promise; } function shift() { resolvers.shift()?.(); } let count = $state(0); </script> <button onclick={() => count += 1}> increment </button> <button onclick={shift}> shift </button> <svelte:boundary> <p>{await push('resolved')}</p> {#snippet pending()} <p>{count}</p> {/snippet} </svelte:boundary> ``` The issue is that the boundary's `this.#effect` has the `BOUNDARY_EFFECT` flag, and `this.#pending_effect` is a child thereof. Instead, `this.#main_effect` should have the flag. (It turns out `this.#failed_effect` _also_ needs the flag, because errors that occur in a `failed` snippet cause the boundary to re-render in its `failed` state, which I found somewhat confusing to be honest. Probably the right choice though.) I was able to simplify the code a bit, too. ~~(Actually now that I think about it do we need `this.#effect` at all? Will check.)~~ ### Before submitting the PR, please make sure you do the following - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`. - [x] This message body should clearly illustrate what problems it solves. - [x] Ideally, include a test that fails without this PR but passes with it. - [x] If this PR changes code within `packages/svelte/src`, add a changeset (`npx changeset`). ### Tests and linting - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint` --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>	1 week ago
7nik	ff70ab1b76	fix: locate Rollup annontaion friendly to JS downgraders (#17724 ) Closes #17722 Looks like after downgrading `?.`, `/* @__PURE__ */` may happen in an invalid location. --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>	1 week ago
github-actions[bot]	82265f1496	Version Packages (#17711 ) This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## svelte@5.51.2 ### Patch Changes - fix: take async into consideration for dev delegated handlers ([#17710](https://github.com/sveltejs/svelte/pull/17710)) - fix: emit state_referenced_locally warning for non-destructured props ([#17708](https://github.com/sveltejs/svelte/pull/17708)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	1 week ago
Copilot	dd9fc0d1ad	Warn on non-destructured `$props()` reads in runes mode (#17708 ) Non-destructured `$props()` access in runes mode silently skipped the `state_referenced_locally` warning, leading to missed guidance when users read `props` via identifiers or member expressions. - Analyzer behavior - Include `rest_prop` bindings in `state_referenced_locally` detection so reads of `$props()` identifiers warn consistently with destructured props. - Validation coverage - Add a validator fixture for `$props()` identifiers and update the `props-identifier` snapshot expectations to capture the new warnings. Example: ```svelte <script> const props = $props(); const { model } = props; // now warns const value = props.model.value; // now warns </script> ``` <!-- START COPILOT ORIGINAL PROMPT --> <details> <summary>Original prompt</summary> > > ---- > > This section details on the original issue you should resolve > > <issue_title>False negative for `state_referenced_locally` warning on not destructured `$props` access?</issue_title> > <issue_description>### Describe the bug > > I was looking for a workaround for sveltejs/svelte#17669 and thought of not destructuring the `$props` directly; to my surprise there were no warnings at all. > > > ### Reproduction > > ```js > const props = $props(); > const { model } = props; // missing warning > > const value = props.model.value; // missing warning > ``` > > [Playground](https://svelte.dev/playground/untitled?version=5.50.2#H4sIAAAAAAAACn2QT4vCQAzFv0oIe1CQ9l51YY97lj1tPYxtXAam6TAT_1H63U0HUax1j3nvJeT3OmTTEBb4w2LFUY0L3FtHEYvfDuXiB28QVL8lv7zP4pGcDNrORJrSq5aFWPQMrmIVrJfPkktROQp00LQ1OehhDR8-tD7O5ku174GjcQdSM8WyNC0hz4HOniqhGk4msOW_klf54zrPNkTwzVUbgsZuz8z1G6GzYCHhQP3iDdV47Zltwv2XMEGN6Cbgk5vIGhujAj3AXstI4WxcycvivZFn7q1OxrqT5RqLvXGR-itXywVk_AEAAA) > > ### Logs > > ```shell > > ``` > > ### System Info > > ```shell > REPL - Svelte v.5.50.2 > ``` > > ### Severity > > annoyance</issue_description> > > ## Comments on the Issue (you are @copilot in this section) > > <comments> > </comments> > </details> <!-- START COPILOT CODING AGENT SUFFIX --> - Fixes sveltejs/svelte#17685 <!-- START COPILOT CODING AGENT TIPS --> --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Rich-Harris <1162160+Rich-Harris@users.noreply.github.com> Co-authored-by: Rich Harris <rich.harris@vercel.com> Co-authored-by: Paolo Ricciuti <ricciutipaolo@gmail.com>	1 week ago
Paolo Ricciuti	01f1937a98	fix: take async into consideration for dev delegated handlers (#17710 ) Closes #17709 ### Before submitting the PR, please make sure you do the following - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`. - [x] This message body should clearly illustrate what problems it solves. - [x] Ideally, include a test that fails without this PR but passes with it. - [x] If this PR changes code within `packages/svelte/src`, add a changeset (`npx changeset`). ### Tests and linting - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint`	1 week ago
github-actions[bot]	7299ffc39f	Version Packages (#17704 ) This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## svelte@5.51.1 ### Patch Changes - fix: don't crash on undefined `document.contentType` ([#17707](https://github.com/sveltejs/svelte/pull/17707)) - fix: use symbols for encapsulated event delegation ([#17703](https://github.com/sveltejs/svelte/pull/17703)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	1 week ago
7nik	743d52a893	fix: don't crash on undefined `document.contentType` (#17707 ) closes #17706	1 week ago
Rich Harris	220b526d3a	fix: use symbols for encapsulated event delegation (#17703 ) Alternative to #17690. Closes #17057	2 weeks ago
github-actions[bot]	7b6755eaf6	Version Packages (#17693 ) This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## svelte@5.51.0 ### Minor Changes - feat: Use `TrustedTypes` for HTML handling where supported ([#16271](https://github.com/sveltejs/svelte/pull/16271)) ### Patch Changes - fix: sanitize template-literal-special-characters in SSR attribute values ([#17692](https://github.com/sveltejs/svelte/pull/17692)) - fix: follow-up formatting in `print()` — flush block-level elements into separate sequences ([#17699](https://github.com/sveltejs/svelte/pull/17699)) - fix: preserve delegated event handlers as long as one or more root components are using them ([#17695](https://github.com/sveltejs/svelte/pull/17695)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	2 weeks ago
jyc.dev	86d5522096	fix: follow-up formatting in `print()` for block-level elements (#17699 ) Follow-up to #17319. The `Fragment` visitor in `print()` only flushed sequences on `RegularElement`, causing block-level elements (`Component`, `SvelteHead`, `SvelteBoundary`, etc.) to be lumped into the same sequence as adjacent nodes. This broke tools that programmatically manipulate the AST (e.g. [sveltejs/cli#915](https://github.com/sveltejs/cli/pull/915)). The fix flushes before and after all block-level element types, ensuring they get their own sequence and proper line separation. ### Before ```svelte <svelte:head><title>Page Title</title></svelte:head><div>no space</div> <Component /><Component /> <Component><span>child</span></Component><div>after component</div> <svelte:boundary><div>boundary content</div></svelte:boundary><div>after boundary</div> <!--comment--><div>after comment</div> <div>before comment</div> <!--comment--> {#each items as item} <div>{item}</div> {/each}<div>after each</div> {@render children()}<div>after render</div> <div>before render</div> {@render children()} ``` ### After ```svelte <svelte:head><title>Page Title</title></svelte:head> <div>no space</div> <Component /> <Component /> <Component><span>child</span></Component> <div>after component</div> <svelte:boundary><div>boundary content</div></svelte:boundary> <div>after boundary</div> <!--comment--> <div>after comment</div> <div>before comment</div> <!--comment--> {#each items as item} <div>{item}</div> {/each} <div>after each</div> {@render children()} <div>after render</div> <div>before render</div> {@render children()} ```	2 weeks ago
Abdelrahman	0565dca1f7	fix: implement ref counting for mount with same target (#17695 ) ### Before submitting the PR, please make sure you do the following - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`. - [x] This message body should clearly illustrate what problems it solves. - [ ] Ideally, include a test that fails without this PR but passes with it. - [x] If this PR changes code within `packages/svelte/src`, add a changeset (`npx changeset`). ### Tests and linting - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint` Fixes #17694 Not really sure how to add a failing test here. The code was generated by Codex 5.3, but I cleaned it up and manually reviewed it myself. Not sure if this is the best approach to solving the issue, though. It does add some overhead with the extra maps. --------- Co-authored-by: Rich Harris <rich.harris@vercel.com> Co-authored-by: Rich Harris <hello@rich-harris.dev>	2 weeks ago
Elliott Johnson	168702d546	chore: compensate for github's complete lack of devex (#17698 ) As far as we can tell, there's no good way to turn off deployment request notifications. This removes automatic pkg.pr.new builds for commits not pushed directly to the svelte repository, meaning forks' commits will have to be manually requested through the GitHub Actions UI. It also makes the drive-by change of deriving the PR number from the commit, which technically is a "breaking change" because there _could_ be multiple PRs associated with a commit... but let's just not do that and we'll be okay.	2 weeks ago
Rich Harris	7cdd8740c6	docs: clarify that each blocks use Array.from (#17691 ) closes #17227	2 weeks ago
Jay Harris	6c15e711e2	[fix]: Add support for TrustedTypes in Svelte (#16271 ) ### Before submitting the PR, please make sure you do the following Resolves https://github.com/sveltejs/svelte/issues/14438 Resolves https://github.com/sveltejs/svelte/issues/10826 This PR makes it possible to use Svelte on pages which require `TrustedTypes` support via their CSP by wrapping assignments to `innerHTML` in a `TrustedTypePolicy` called `svelte-trusted-html` if the `TrustedTypes` API exists. Servers can allowlist the policy by setting `require-trusted-types-for 'script'; trusted-types svelte-trusted-html` in their `Content-Security-Policy` header. - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`. - [x] This message body should clearly illustrate what problems it solves. - [ ] Ideally, include a test that fails without this PR but passes with it. - [x] If this PR changes code within `packages/svelte/src`, add a changeset (`npx changeset`). ### Tests and linting Note: I haven't run the tests since I don't have `pnpm` setup properly. I have tested that: 1. A project with a CSP fails with Tip of Tree Svelte 2. That project works when installing this revision of Svelte 3. The project (with this revision) works in Browsers with no `TrustedTypes` support (i.e. Firefox, Safari) - [ ] Run the tests with `pnpm test` and lint the project with `pnpm lint` My test project is here: https://github.com/fallaciousreasoning/svelte-tt-test/blob/master/src/routes/%2Bpage.server.js The only changes to the default project is adding the CSP in `src/routes/page.server.js` --------- Co-authored-by: 7nik <kfiiranet@gmail.com> Co-authored-by: Rich Harris <rich.harris@vercel.com> Co-authored-by: Rich Harris <hello@rich-harris.dev>	2 weeks ago
Elliott Johnson	75e1992141	fix: sanitize template-literal-special-characters in SSR attribute values (#17692 ) Fixes a minor bug where HTML entities could be decoded into significant characters in the template literal we output for SSR, leading to weird effects. Not a security issue because it has to be literally written into the svelte file you're compiling, but still wrong. --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	2 weeks ago
github-actions[bot]	c1c664df93	Version Packages (#17681 ) This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## svelte@5.50.3 ### Patch Changes - fix: take into account `nodeName` case sensitivity on XHTML pages ([#17689](https://github.com/sveltejs/svelte/pull/17689)) - fix: render `multiple` and `selected` attributes as empty strings for XHTML compliance ([#17689](https://github.com/sveltejs/svelte/pull/17689)) - fix: always lowercase HTML elements, for XHTML compliance ([#17664](https://github.com/sveltejs/svelte/pull/17664)) - fix: freeze effects-inside-deriveds when disconnecting, unfreeze on reconnect ([#17682](https://github.com/sveltejs/svelte/pull/17682)) - fix: propagate `$effect` errors to `<svelte:boundary>` ([#17684](https://github.com/sveltejs/svelte/pull/17684)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	2 weeks ago
Razin Shafayet	45a796b327	fix: propagate `$effect` errors to `<svelte:boundary>` (#17684 ) Fixes #16342. Errors thrown inside `$effect` were previously treated as subtree-creation errors when `EFFECT_RAN === 0`, which caused them to be rethrown instead of propagating to the nearest `<svelte:boundary>`. As a result, `$effect` errors bypassed boundaries and appeared as uncaught runtime errors. This change ensures that errors originating from effects (`EFFECT`) are routed through `invoke_error_boundary`, allowing them to bubble up the effect tree and be handled correctly by the closest boundary. Existing subtree-creation behavior for non-effect cases remains unchanged. --- ### Before submitting the PR, please make sure you do the following - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`. - [x] This message body should clearly illustrate what problems it solves. - [x] Ideally, include a test that fails without this PR but passes with it. - [x] If this PR changes code within `packages/svelte/src`, add a changeset (`npx changeset`). ### Tests and linting - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint` --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	2 weeks ago

1 2 3 4 5 ...

10983 Commits (4e29eee4b008588d90df36fb519a126e14529852) All Branches Search

10983 Commits (4e29eee4b008588d90df36fb519a126e14529852)

All Branches