svelte

Commit Graph

Author	SHA1	Message	Date
Simon Holthausen	5b65a637aa	chore: create separate Boundary class	6 months ago
Simon Holthausen	9d298fb54b	unnecessary	6 months ago
Simon Holthausen	f288618d5a	fix / don't swallow error (user might want to throw a different one)	6 months ago
Simon Holthausen	020bdfb602	revert this was committed by accident	6 months ago
Rich Harris	3b7f4341c4	chore: DRY out boundary compiler code (#17673 ) #17672	6 months ago
Simon Holthausen	654a207b1f	fix	6 months ago
Simon Holthausen	88c1b75979	feat: allow error boundaries to work on the server This makes error boundaries run on the server if a new `onerror` handler is passed to `render`. `onerror` can either synchronously or asynchronously return a value. It should be a sanitized JSON.stringify-able value so that it can be passed to the client for hydration via a comment. `mount/hydrate` also get the `onerror` property. If no `onerror` is passed to `render` it will just throw just like before, hence this is backwards compatible. This work is important for SvelteKit to allow `+error.svelte` to make use of them and in general to make boundaries properly work during SSR (also see https://github.com/sveltejs/kit/issues/14398). closes #15370	6 months ago
github-actions[bot]	35c845e35d	Version Packages (#17653 ) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	6 months ago
Mohit Kourav	67c4a38117	docs: add explanatory comments to empty catch blocks (#17651 ) * docs: add explanatory comments to empty catch blocks * Update equality.js * Refactor error handling in inspect.js Simplified error handling in render_effect. * Update inspect.js * Update packages/svelte/src/internal/client/dev/console-log.js --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>	6 months ago
Simon H	0a404c9863	fix: prevent async render tag hydration mismatches (#17652 ) If the render tag is wrapped in `$.async`, that `$.async` call already contains surrounding markers, so we must not add our own to avoid hydration mismatches. Related to #17641, fixes #17225	6 months ago
Rich Harris	d047bc6e2a	fix: render boolean attribute values as empty strings for XHTML compliance (#17648 )	6 months ago
7nik	9749ee869c	chore: add xhtml tests (#17597 ) * add xhtml tests * unused * tweak * more tests * tweak * we don't need to actually check the HTML - if it's malformed in SSR or mount, it will throw * same here * unused, so we can revert this * and this --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	6 months ago
github-actions[bot]	bb00d5b6e7	Version Packages (#17615 ) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	6 months ago
Andrew Aquino	863c9d6875	chore: wrap JSDoc URLs in @see and @link tags (#17617 ) * docs: wrap JSDoc URLs in @see and @link tags * fix: move curly brace to end of URL * chore: add changeset * add link text * regenerate --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	6 months ago
Rich Harris	57cb393796	fix: allow NaN in key blocks (#17642 ) * fix: allow NaN in key blocks * lol whoops * Update packages/svelte/src/internal/client/dom/blocks/key.js Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>	6 months ago
Rich Harris	bd7b8aa108	chore: fix broken css test (#17644 )	6 months ago
Artyom Alekseevich	f71a6813b7	fix: treat menu element like ul/ol for a11y role checks (#17638 ) * treat menu element like ul/ol for a11y role checks The <menu> element has the same implicit role (list) as <ul> and <ol>, so it should receive the same treatment in a11y checks: - Allow <menu role="list"> without redundant role warning (CSS list-style:none can remove semantics, role restores them) - Allow <menu> with interactive roles like menu, menubar, radiogroup, tablist, tree, treegrid (same exceptions as ul/ol) Fixes #8529 * changeset --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>	6 months ago
Artyom Alekseevich	4453e4895d	fix: fix spelling errors in media-query and test file (#17628 ) - media-query.js: parentehesis -> parenthesis - error-boundary-12/main.svelte: occured -> occurred	6 months ago
Artyom Alekseevich	0c715afdab	fix: correct spelling errors in test files (#17630 ) Fix "wich" -> "which", "aswell" -> "as well" in CSS global-block test, and "occurence" -> "occurrence" in sourcemaps test type definition.	6 months ago
Artyom Alekseevich	989492f057	fix: use "set up" (verb) instead of "setup" (noun) in comments (#17632 ) "Setup" is a noun/adjective, while "set up" is the verb form.	6 months ago
Rich Harris	6e5f2b157a	fix: exit resolved async blocks on correct node when hydrating (#17640 ) * fix: exit resolved async blocks on correct node when hydrating * expand test + fix * tweak, add note to self --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>	6 months ago
Rich Harris	bc44975869	fix: properly hydrate already-resolved async blocks (alternative) (#17641 ) This is basically #17611, minus #17640, plus #17639. We need to add the $.next() call after render tags as well as components; rather than duplicating the logic, we can use is_standalone to determine when this is necessary (since this is what prevents $.append(...) from being used). Fixes #17261 Fixes #17608 --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>	6 months ago
Rich Harris	f5304ec8c9	chore: simplify SSR code (#17639 ) creates a few abstractions in the compiler code around common "if-else" scenarios, as well as introducing a new runtime render helper --------- Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com> Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>	6 months ago
Artyom Alekseevich	a75866f34d	fix: detect store in each block expression regardless of AST shape (#17636 ) The store invalidation detection in each blocks only checked for Identifier and MemberExpression AST node types. This caused bind: on iteration variables to silently fail when the expression used logical operators (e.g. `{#each $store.items ?? [] as item}`). Use expression metadata dependencies instead of AST type checking to find store_sub bindings, which correctly handles all expression shapes. Fixes #14625	6 months ago
Rich Harris	fcbd3e325a	feat: allow use of createContext when instantiating components programmatically (#17575 ) * feat: allow use of createContext when instantiating components programmatically * docs	6 months ago
Rich Harris	f05f946fea	fix: add vite-ignore comment inside dynamic crypto import (#17623 )	6 months ago
7nik	d7a8e3d130	fix: emit `each_key_duplicate` error in production (#16724 ) * fix: emit `each_key_duplicate` error in production * fix: preserve key * Update packages/svelte/src/internal/client/dom/blocks/each.js Co-authored-by: Rich Harris <rich.harris@vercel.com> * Update packages/svelte/src/internal/client/dom/blocks/each.js Co-authored-by: Rich Harris <rich.harris@vercel.com> * fix: ensure keys are validated * fix silly test name * fix: cover other case of duplicate keys * emit error on hydration * ensure the error is handled * drop useless tests * unused * finish merge * add lost check back * chore: bump playwright (#17565) * chore: bump playwright * maybe this will help somehow? * err whatever * fix * chore: allow testing in production env 2 (#17590) * Revert "chore: allow testing in production env (#16840)" This reverts commit `ffd65e90fe`. * new approach * fix: handle renderer.run rejections (#17591) * fix: handle renderer run rejections * add test * changeset * simplify * explanatory comment --------- Co-authored-by: Antonio Bennett <abennett@mabelslabels.com> Co-authored-by: Rich Harris <rich.harris@vercel.com> * fix: only create async functions in SSR output when necessary (#17593) * fix: only create async functions in SSR output when necessary * actually... * simplify generated code a bit more * simplify * fix: merge consecutive text nodes during hydration for large text content (#17587) * fix: merge consecutive text nodes during hydration for large text content Fixes #17582 Browsers automatically split text nodes exceeding 65536 characters into multiple consecutive text nodes during HTML parsing. This causes hydration mismatches when Svelte expects a single text node. The fix merges consecutive text nodes during hydration by: - Detecting when the current node is a text node - Finding all consecutive text node siblings - Merging their content into the first text node - Removing the extra text nodes This restores correct hydration behavior for large text content. * add test, fix * fix * fix * changeset --------- Co-authored-by: Miner <miner@example.com> Co-authored-by: Rich Harris <rich.harris@vercel.com> * Version Packages (#17585) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Revert "drop useless tests" This reverts commit `65f77ef840`. * update tests * fix test * we don't need to expose this function any more * figured it out... we cant have errors during reconcile * simplify * tweak * unused * revert no-longer-needed change * unused --------- Co-authored-by: Rich Harris <rich.harris@vercel.com> Co-authored-by: Antonio Bennett <31296212+Antonio-Bennett@users.noreply.github.com> Co-authored-by: Antonio Bennett <abennett@mabelslabels.com> Co-authored-by: FORMI <239411042+Richman018@users.noreply.github.com> Co-authored-by: Miner <miner@example.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	6 months ago
Rich Harris	4f41e816ba	fix: ensure infinite effect loops are cleared after flushing (#17601 ) * failing effect-loop-infinite test * fix	6 months ago
github-actions[bot]	eb63a6bbba	Version Packages (#17614 ) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	6 months ago
Tee Ming	05229d9682	chore: remove SvelteKit data attributes from elements.d.ts (#17613 ) * Remove SvelteKit data attributes from elements.d.ts Removed SvelteKit specific data attributes from elements.d.ts. * Remove SvelteKit data attributes from elements.d.ts Removed SvelteKit data attributes from elements.d.ts. --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>	6 months ago
Tee Ming	baba15ab98	fix: avoid 'node:crypto' cloudflare warnings (#17612 ) * fix: avoid 'node:crypto' cloudflare warnings * format * changeset * Apply suggestion from @teemingc	6 months ago
Simon H	bc4dc1d10d	fix: avoid erroneous async derived expressions for blocks (#17604 ) fixes #17595 When an if/key/etc block has an expression that depends on an async blocker (e.g., is inside a component with top level `await`), the compiler incorrectly treats the expression as async - even when the expression itself contains no `await`. This causes the expression to be added to `$.async`'s `expressions` array, which wraps it in an `async_derived`. This is not only unnecessary but also buggy: it breaks the direct reactive connection between the source and its dependent effects, causing inconsistent effect executions. The fix is to only add expressions to `$.async`'s `expressions` array when they actually contain an `await`. When a branch is speculatively marked for destruction (condition temporarily falsy), its child effects are reset to `CLEAN` to prevent them running in a doomed branch (as of #17581). However, if the branch survives (condition becomes truthy again), those effects remain `CLEAN` and never run - the source was already marked dirty before the reset, so no new dirty marking occurs. The fix is to change `skipped_effects` from a `Set` to a `Map` that tracks which child effects were dirty/maybe_dirty before being reset. When a branch is unskipped (survives), restore their status and reschedule them. --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	6 months ago
github-actions[bot]	92e6721c03	Version Packages (#17585 ) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	7 months ago
FORMI	8933653fbe	fix: merge consecutive text nodes during hydration for large text content (#17587 ) * fix: merge consecutive text nodes during hydration for large text content Fixes #17582 Browsers automatically split text nodes exceeding 65536 characters into multiple consecutive text nodes during HTML parsing. This causes hydration mismatches when Svelte expects a single text node. The fix merges consecutive text nodes during hydration by: - Detecting when the current node is a text node - Finding all consecutive text node siblings - Merging their content into the first text node - Removing the extra text nodes This restores correct hydration behavior for large text content. * add test, fix * fix * fix * changeset --------- Co-authored-by: Miner <miner@example.com> Co-authored-by: Rich Harris <rich.harris@vercel.com>	7 months ago
Rich Harris	ebe583f2bb	fix: only create async functions in SSR output when necessary (#17593 ) * fix: only create async functions in SSR output when necessary * actually... * simplify generated code a bit more * simplify	7 months ago
Antonio Bennett	5656dd569a	fix: handle renderer.run rejections (#17591 ) * fix: handle renderer run rejections * add test * changeset * simplify * explanatory comment --------- Co-authored-by: Antonio Bennett <abennett@mabelslabels.com> Co-authored-by: Rich Harris <rich.harris@vercel.com>	7 months ago
7nik	704d0cd765	chore: allow testing in production env 2 (#17590 ) * Revert "chore: allow testing in production env (#16840)" This reverts commit `ffd65e90fe`. * new approach	7 months ago
Rich Harris	26b09ec420	chore: bump playwright (#17565 ) * chore: bump playwright * maybe this will help somehow? * err whatever * fix	7 months ago
7nik	ffd65e90fe	chore: allow testing in production env (#16840 ) * allow testing in production env * oops	7 months ago
Manuel	82fde88780	fix: `print()` multiline behaviour (#17319 ) * way cleaner new line handling for base_elements * fix * more fixes * use esrap preview * changeset * bump `esrap` * update snapshot * update more snapshots * Update .changeset/rich-zoos-walk.md --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	7 months ago
github-actions[bot]	9d1dd2e199	Version Packages (#17564 ) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	7 months ago
Paolo Ricciuti	2d62ffee9c	fix: throw for unset `createContext` get on the server (#17580 ) * fix: throw for unset `createContext` get on the server * smol tweak --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	7 months ago
Rich Harris	1c131f11ca	fix: reset effects inside skipped branches (#17581 ) * fix: prevent reactivity loss during fork fixes #17197, fixes #17304, fixes #17301, fixes #17309 * add samples * add changeset * fix var casing in tests * don't remove reactions during fork * add sample for derived dep tracking in fork * fix sample type check error * set derived.v on first eval in fork * add sample for derived.v remaining UNINITIALIZED * lost current_batch import in runtime.js * Delete how * Update packages/svelte/src/internal/client/reactivity/deriveds.js * delete test in favour of #17577 * extract runtime.js changes into separate PR * alternative approach * revert * clear skipped branches when deferring * fix * fix * changeset * rename test * update test * unused test --------- Co-authored-by: David Roizenman <david@hmnd.io> Co-authored-by: Paolo Ricciuti <ricciutipaolo@gmail.com> Co-authored-by: Tee Ming <chewteeming01@gmail.com>	7 months ago
Rich Harris	3608b3c869	fix: preserve old dependencies when updating reaction inside fork (#17579 ) Co-authored-by: David Roizenman <hmnd@users.noreply.github.com>	7 months ago
Rich Harris	ece2e83eb9	fix: increment signal versions when discarding forks (#17577 ) * fix: always update an UNINITIALIZED derived on read Co-authored-by: David Roizenman <hmnd@users.noreply.github.com> * obsolete comments * rename test * add tests, fix * revert * Update .changeset/vast-hornets-draw.md --------- Co-authored-by: David Roizenman <hmnd@users.noreply.github.com>	7 months ago
Rich Harris	37cd40d2e5	fix: more conservative assignment_value_stale warnings (#17574 )	7 months ago
Razin Shafayet	3256a75b54	fix: ignore popover elements in a11y_consider_explicit_label check (#17367 ) * fix: ignore popover elements in a11y_consider_explicit_label check * chore: add changeset * Apply suggestions from code review * Apply suggestions from code review * fix --------- Co-authored-by: Rich Harris <hello@rich-harris.dev> Co-authored-by: Rich Harris <rich.harris@vercel.com>	7 months ago
PandaMan	16fec7207a	fix: make onintrostart respect delay parameter (#17567 ) * fix: make onintrostart respect delay parameter Fixes #14009 The onintrostart event now fires after the delay period completes, rather than immediately when the transition is initiated. This ensures that the event accurately reflects when the intro animation actually starts. Changes: - Added on_start callback parameter to animate() function - Dispatch introstart event after delay animation finishes - Handle edge case where duration is 0 but delay > 0 * fix: format code with prettier * add (failing) tests * fix * changeset * missed a spot * fix --------- Co-authored-by: Miner <miner@example.com> Co-authored-by: Rich Harris <rich.harris@vercel.com>	7 months ago
Rich Harris	06e6ef83b8	failing test (#12791 )	7 months ago
Dominik G.	975a5ec60a	fix invalid negative values in sourcemap column indexes (#17167 ) * add check for negative idx to sourcemaps test * fix: format * Update packages/svelte/tests/sourcemaps/test.ts --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	7 months ago

1 2 3 4 5 ...

3055 Commits (ssr-error-boundary-class)