fix: ignore popover elements in a11y_consider_explicit_label check (#17367)

* fix: ignore popover elements in a11y_consider_explicit_label check

* chore: add changeset

* Apply suggestions from code review

* Apply suggestions from code review

* fix

---------

Co-authored-by: Rich Harris <hello@rich-harris.dev>
Co-authored-by: Rich Harris <rich.harris@vercel.com>

.changeset/shaggy-phones-laugh.md

@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: disregard `popover` elements when determining whether an element has content

packages/svelte/src/compiler/phases/2-analyze/visitors/shared/a11y/index.js

@@ -824,6 +824,10 @@ function has_content(element) {
 		}
 
 		if (node.type === 'RegularElement' || node.type === 'SvelteElement') {
+			if (node.attributes.some((a) => a.type === 'Attribute' && a.name === 'popover')) {
+				continue;
+			}
+
 			if (
 				node.name === 'img' &&
 				node.attributes.some((node) => node.type === 'Attribute' && node.name === 'alt')

packages/svelte/tests/validator/samples/a11y-popover-label/input.svelte

@@ -0,0 +1,3 @@
+<button interestfor="my-hint">
+	<div id="my-hint" popover="hint">hello</div>
+</button>

packages/svelte/tests/validator/samples/a11y-popover-label/warnings.json

@@ -0,0 +1,14 @@
+[
+	{
+		"code": "a11y_consider_explicit_label",
+		"message": "Buttons and links should either contain text or have an `aria-label`, `aria-labelledby` or `title` attribute",
+		"start": {
+			"line": 1,
+			"column": 0
+		},
+		"end": {
+			"line": 3,
+			"column": 9
+		}
+	}
+]