svelte

Commit Graph

Author	SHA1	Message	Date
Simon Holthausen	57c2e7f457	Merge branch 'main' into portals	2 weeks ago
Nic Polumeyv	4d5139552d	fix: block declaration tags on async values read inside closures (#18533 ) Fixes #18469 Declaration tags collect blockers from `metadata.expression.dependencies`, which only sees eager reads, so a `$derived` reading an async declaration inside a closure gets no blocker and evaluates while the value is still `undefined`. Align with template expressions which already collect blockers from `references` --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>	2 weeks ago
Rich Harris	aadc97ce1b	fix: simplify boundary error handling and handle hydration errors correctly (#18539 ) remove the `catch` clause in `this.#run` - in two locations there's already a catch, and in the hydration-location we have to add special handling for hydration errors. --------- Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>	2 weeks ago
Sushanth012	bfc9b65b3d	docs: clarify mounting components with context (#18515 ) Closes #18462.	2 weeks ago
Bao Nguyen	0f458d5aba	fix: report `derived_invalid_export` for `export let x = $derived(...)` (#18692 ) Fixes #15842 Run the more targeted validations first --------- Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>	2 weeks ago
Khaled Waleed	955b701df2	fix: measure nested transitions before applying their starting styles (#18647 ) Fixes #18421 (regression from #16035, which re-broke the #4784 scenario). Since #16035 the dummy delay animation runs with `fill: 'forwards'`, so an intro's `t = 0` styles (for `slide`, `height: 0`) apply the moment the transition is created and stay applied until the real animation starts a frame later. Transition functions of other elements in the same batch run after that and measure a collapsed DOM. With nested intros (the TreeView from the issue), intro effects run deepest-first, so every ancestor's `slide` captures a height where its children are pinned at 0. On the issue's REPL every `<ul>` animates `0px -> 36px` (the height of a single row) and then jumps to its real size when the animation finishes, which is the "children pop out" behavior from #4784. The fix waits one microtask before applying the initial styles and creating the dummy, the same way deferred transitions (`crossfade`) already work in `animate()`. Everything in the batch measures the DOM first; the microtask still runs before the next paint, so elements never render unstyled and the #14732 behavior is preserved. Verified in a real browser that a delayed intro (`delay: 300`) stays held at `height: 0` for the whole delay, including the first painted frame. Most of the diff is the existing dummy/onfinish block moving into `queue_micro_task`; hiding whitespace shows the actual change.	2 weeks ago
svelte-triage-bot[bot]	c7d8233a5c	fix: apply ownership mutation ignores to bindings (#18718 ) Fixes #18715. Copy ignore comment info to the generated assignment so it's recognized later --------- Co-authored-by: svelte-triage-bot <team@svelte.com> Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>	2 weeks ago
Simon H	68e7c9b521	fix: transform derived assignments and select function bindings correctly during server-side rendering (#18669 ) follow-up to the fix in #18607 - there are a two more bugs related to writeable deriveds in that area	2 weeks ago
Mathias Picker	14ec75c5fe	perf: fold SSR block-open markers into the branch's first push (#18712 ) One fewer `$$renderer.push` per rendered branch	2 weeks ago
Ion	c575b07bca	feat: support `defaultValue` on `<select>` (#18591 ) Closes #18447 --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>	2 weeks ago
Bao Nguyen	b433f3cd87	fix: preserve line feed character references in attribute values (#18691 ) Fixes #15555 Pass on whether we're in an attribute to not replace the charcode with the whitespace charcode in that case	2 weeks ago
Mathias Picker	34489c10df	perf: emit `$.only_child` for elements with a single child (#18717 ) `<p>{text}</p>` and friends compile to `var x = $.child(p, true); $.reset(p);`. Across the 4,020 components in `packages/svelte/tests`, that exact pair occurs 1,885 times, more than any other adjacent statement pair. `$.only_child` does both, reducing the number of statements in the compiled output	2 weeks ago
Mathias Picker	6b99f9fb52	perf: reuse the cached value in the `<option>`/`<select>` value guard (#18713 ) One fewer evaluation of the value expression per update. --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>	2 weeks ago
Mathias Picker	8299cbf11b	perf: use `$.comment()` for single comment templates (#18714 ) Move the "single comment, we can make this faster" optimization into `transform_template` so all usage locations can benefit (e.g. select/option elements) --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>	2 weeks ago
Mathias Picker	359413f512	perf: treat `<img loading>` as a static element again (#18711 ) Emits less code and skips two live DOM traversals per instance. `is_static_element` treats `<img>` with a `loading` attribute as non-static. That was added in #14237 so `RegularElement` could emit `$.handle_lazy_img(node_id)`, which needed a reference to the element. #15272 deleted `handle_lazy_img` (replaced by `importNode`) and removed the call site, but left this check behind. --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>	2 weeks ago
Simon H	135f1ec004	fix: more robust rendering of Svelte custom element slots (#18710 ) Instead of checking the given nodes at startup and only injecting those into the inner Svelte component constructor, we are now detecting (via the `$$host` property) whether or not the component is rendered as a custom element, and in that case create all slots as real slots right away. Fixes #13638 Fixes #8997 (therefore closes #8999)	2 weeks ago
Jawad Ali	c894afd8c7	fix: sync SvelteURL port when protocol setter clears it (#18705 ) Per the WHATWG URL spec, assigning a new protocol can clear the URL's port when the current port equals the new scheme's default port. Therefore also `set` the port when the protocol is updated.	2 weeks ago
Nic Polumeyv	6b16b7f73f	fix: keep defaultChecked on hydrated radio inputs with spread attributes (#18701 ) radio buttons were missing in the type check - remove the check instead (aligns with how we do it in the compiler, see `has_default_value_attribute`). Strictly speaking not fully correct but pragmatic solution that doesn't have any impact in practise Needed by sveltejs/kit#16926.	2 weeks ago
Jawad Ali	1b02aa28c8	fix: decode uppercase-X hex numeric character references (#18708 ) uppercase X is also valid per the HTML spec	2 weeks ago
Nic Polumeyv	2b740e496e	fix: commit a reaction's dependencies even when it throws (#18703 ) Fixes #18414 and a second bug with the same cause. `update_reaction` in `runtime.js` commits a reaction's dependencies after `fn()` returns: it swaps in `new_deps`, removes stale reactions and registers the reaction into each new dep's `reactions`. When `fn()` throws, the whole block is skipped. Two things go wrong from that. A derived that the run read for the first time was already set `CONNECTED` in `get` and registered itself into its own deps' `reactions` during `update_derived`, but the throwing reaction never registers as its reader. It sits in its deps' `reactions` with `reactions === null` of its own, `remove_reaction`'s disconnect cascade can never reach it, and it retains its `ctx`, closures and DOM past component destruction and `unmount()`. A derived that throws during its own run ends up with no dependencies at all. It is not in its sources' `reactions`, so a later change to them never re-runs it, and for an unowned derived `update_derived` then marks the error value CLEAN because the derived has no deps. Anything reading it keeps getting the first error forever. The commit block is now `update_dependencies` and the `catch` calls it before `handle_error`, so a failing reaction keeps the deps it read up to the throw. That subscribes it to the inputs that produced the error, and lets the normal disconnect cascade clean up when it is destroyed (`Boundary.#handle_error` destroys the failed effect). Co-authored-by: Randy Murphy <randalmurphal@users.noreply.github.com>	2 weeks ago
Mathias Picker	fdb3aa8ba8	perf: store setters cache as Set instead of Array (#18251 ) --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>	2 weeks ago
JY Wey	b20b2ee85e	fix: avoid css tree-shaking for exported Snippet (#18540 ) fix #16404 Currently one file can have multiple exports but only one `cssScopeTo` variable, which is hard coded to `default` inside vite-plugin-svelte. Therefore set hasGlobal to `true` in case we export a snippet to not have this scoping enabled in v-p-s --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>	2 weeks ago
Ashok Kaushik	6f5dd04a00	fix: Fixes error thrown on use of select with no options (#18449 ) Fixes #18445.	2 weeks ago
Nic Polumeyv	f2648b3537	fix: end a restored reaction context at the end of its synchronous segment (#18694 ) When an async expression resumes after a pickled `await`, the thunk returned by `save()` in `reactivity/async.js` calls `restore()` to re-arm `active_reaction` for the rest of the expression, then disarms it with `queue_micro_task(unset_context)`. Any microtask already queued before that one runs inside the restored context. If it writes to a source, `set()` throws `state_unsafe_mutation` in production, since the guard is not dev-only. #18453 introduced the queued disarm and noted this case in review as unavoidable. SvelteKit hits it in practice: its fetch continuations write to internal `$state` (sveltejs/kit#16914), and a user's `$derived((await q()).length)` resuming in the same tick makes that write throw and drops the update signal. The context restored by a `save` thunk now ends with the synchronous segment it was restored in. A `restored` flag is set by the thunk and consumed on entry to `save` and `track_reactivity_loss`, so every suspension ends it; once an expression contains a pickled await, the analysis pickles every later await in it too (`has_pickled_await` on `ExpressionMetadata`), so a trailing await compiles to `$.save` rather than a bare `await`. At the end of the body, `async_thunk` in `3-transform/client/utils.js` wraps the return expression in `$.unsave(...)` when the metadata has a pickled await. If the body throws instead, the context is unset by `async_derived`'s existing `finally`, as before. The queued microtask in `save` is removed. Output is unchanged for expressions that pickle nothing (`$derived(await a)` compiles byte for byte the same). Expressions with a pickled await gain one `$.unsave(` call per body, and their trailing await becomes a `$.save`, 4 to 6 bytes gzipped in the added tests. At runtime a boolean write replaces a queued microtask per resume. `bench:compare` shows no difference outside run-to-run noise. Two runtime tests reproduce the throw without any library involved, one in dev and one with the prod `await` shape, and fail on `main`. --------- Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>	2 weeks ago
Bao Nguyen	1be496f0a6	fix: accept `onfocusin`/`onfocusout` in `a11y_mouse_events_have_key_events` (#18689 ) Fixes #8089 focusin/focusout are the bubble variants of focus/blur --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>	2 weeks ago
svelte-triage-bot[bot]	721244ad3b	fix: track SvelteDate snapshots in reactions (#18700 ) Read the Date value through `getTime()` before cloning it to get reactive updates from `SvelteDate`. Closes #18698 --------- Co-authored-by: svelte-triage-bot <team@svelte.com> Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>	2 weeks ago
svelte-triage-bot[bot]	4b61851ec8	fix: clean up svelte:head anchors on unmount (#18697 ) include client-created <svelte:head> anchors in the head effect’s DOM range remove anchors through the existing HEAD_EFFECT teardown add client and hydration regression coverage for repeated mount/unmount cycles Fixes #18695 --------- Co-authored-by: svelte-triage-bot <team@svelte.com> Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>	2 weeks ago
ChaseCopeland	15720b16a5	docs: Updated docs to include information on easing functions (#16070 ) closes #15992 This is a minor update to the easing documents. It adds an overview description for the module and short descriptions for each of the easing functions. --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> Co-authored-by: vercel[bot] <35613825+vercel[bot]@users.noreply.github.com> Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>	2 weeks ago
sliang-code	63b4c3652d	fix: don't apply scoped CSS class to elements inside <svelte:head> (#18160 ) skip elements inside head, they should not get hashes --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>	2 weeks ago
PD Shaheed Ali Khan	2ac7366391	perf: optimize simple object destructuring in @const tags (#18390 ) This PR resolves a `TODO` in `ConstTag.js` regarding the optimization of simple object pattern matching cases like `{@const { x } = y}`. --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>	2 weeks ago
Nic Polumeyv	a6560bbe08	fix: don't resurrect outroing elements when an ancestor block is paused and resumed (#18431 ) Fixes #15604 Given two nested blocks that both transition: ```svelte {#if fetching} <p>loading</p> {:else} <div transition:fade> {#if shown} <div class="red" transition:fade\|global>red square</div> {/if} </div> {/if} ``` and this sequence, where each step happens before the previous fade finished: ```js shown = false; // red square starts fading out fetching = true; // outer block starts fading out too fetching = false; // 50ms later ``` the red square should finish fading out and be removed, since `shown` is still false. Instead it fades back in and stays on screen: resuming the outer block walks the whole subtree, clears `INERT` on every effect and plays `in()` on every transition it finds — including the inner block's, so the square's outro is aborted and the removal callback waiting on it never runs. The inner block has no reason to re-run on its own, `shown` never changed again. The root issue is that `INERT` records no ownership — it can't distinguish "paused by the ancestor currently being resumed" (revive) from "paused by its own block for its own reasons" (leave alone). The pause side already has this restraint: `pause_children` refuses to touch a subtree that is already `INERT`. The resume side had nothing to check. This PR marks the one effect `pause_effect` was actually called on — the root of the paused subtree — with a `PAUSED` flag, and gives resume the same restraint: ```js function resume_children(effect, local) { if ((effect.f & PAUSED) !== 0) return; ``` so a resume can only ever undo its own pause; the flag is only cleared by `resume_effect` on that exact effect. If `shown` flips back to true while the outer block is paused, this still works: the inner block effect carries no `PAUSED` itself, so it is resumed and rescheduled, re-evaluates its condition and revives its own branch.	2 weeks ago
dependabot[bot]	78979c87c9	chore(deps-dev): bump vite from 7.3.2 to 7.3.5 (#18444 )	2 weeks ago
svelte-triage-bot[bot]	a6153f1d2a	fix: preserve whitespace after inline elements when printing (#18685 ) Fixes #18683. The printer previously trimmed leading whitespace after an inline element and failed to replace it when the fragment stayed on one line. Track that whitespace while grouping fragment nodes and emit a space for inline output, while retaining newline-based separation for multiline output. Adds regression coverage for whitespace following an inline element and updates existing print snapshots that exposed the same behavior.	2 weeks ago
Nic Polumeyv	3b559bbf96	fix: avoid NaN keyframe values in slide transition (#18430 ) Fixes #14205 When a `slide` transition runs on an element without a layout box, for example inside a `display: none` parent, `getComputedStyle` returns values like `auto` for the animated dimensions. These were passed through `parseFloat` unguarded, so the generated css contained `height: NaNpx` and the browser rejected the keyframe property with an "Invalid keyframe value" warning on every transition. Fix it by omitting properties if they have unparseable numbers - it's the same outcome but you don't see a warning. --------- Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>	2 weeks ago
adiGuba	3405b5e735	fix: distinct memoizer on style/class directives (#18466 ) Fix #18465 The style and classe directives are generated using an unique memoizer for all the class/style directive, which means if you have multiple of the same time on one element you have overly broad invalidation/reruns. This fixes it by having one memoizer call per directive instead of collecting them. --------- Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com> Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>	2 weeks ago
Giorgio Maria Federico Birnthaler	a1ec9c8eb7	chore: fix typo in read_version JSDoc (#18470 )	2 weeks ago
Rupankar Dutta	224fcadbd5	fix: route $derived teardown errors through invoke_error_boundary (#18486 ) Fixes #18485 Two parts to this: 1. explicitly invoke error boundary during teardown errors, else they go missing/bubble up outside the render tree 2. skip destroying/destroyed boundaries will searching a handler --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com> Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>	2 weeks ago
Barry	8bf9ec8700	docs: clarify $bindable fallback binding requirement (#18477 )	2 weeks ago
Paolo Ricciuti	06c9b7929a	fix: prevent `selectedcontent` mutation from changing the selected option (#18495 ) Basically, in a situation like this ```svelte <script lang="ts"> let value = $state('A'); </script> <input oninput={() => {}} /> <select bind:value> <button><selectedcontent></selectedcontent></button> <option>A</option> <option>B</option> <option>C</option> </select> <style> select,::picker(select){ appearance: base-select; } </style> ``` what happens is that the `oninput` is delegated and so it registers the global listener (which means it listen on every `oninput` not just the one from the input). When the select change, the `input` event is dispatched first, the listener runs, doesn't find an `__input` handler and returns. Now before the `change` event is emitted, the `MutationObserver` in `init_select` is triggered by the browser updating `selectedcontent` and invokes `select_option` with `select.__value`. However, since the `change` event has yet to fire, `select.__value` still has the old value, so we "reselect" that. When the change event runs, the selected option is effectively the old one and the whole thing breaks. I had to add the test in `runtime-browser` because JSDom doesn't support `selectedcontent`	2 weeks ago
Nic Polumeyv	b2a24b0426	fix: run `onDestroy` callbacks when a server render throws (#18585 ) Fixes #18584. There's multiple parts to this - abort signal was buggy. It wasn't scoped per render, so cross-talk was possible. Fix by scoping to renderer - onDestroy callbacks were skipped when something throws. Fix by carefully aborting the rest of the tree, waiting for settle, collect all callbacks and then call them --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>	2 weeks ago
Nic Polumeyv	6266debb21	docs: clarify when `$effect.pre` runs relative to DOM updates (#18534 ) Related to #16648 - describe the `$effect.pre` in more detail --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>	2 weeks ago
Nic Polumeyv	9d0062d607	fix: make template store subscriptions wait for the promise that assigns the store (#18582 ) Blockers didn't include analyzing implicit store subscriptions, which could also only happen in the template. Also needs to defer store unsubscribe until after the async template has settled in case the store value is read after an async blocker, in which case unsubscribe synchronously is too soon. Fixes https://github.com/sveltejs/kit/issues/15119	2 weeks ago
Khaled Waleed	2d2e5df26e	fix: don't turn component instances stored in $state into state proxies (#18646 ) Fixes #18416. We previously said that we don't want to handle component instances specifically when they're wrapped with state in #16747 - though the use case presented back then was much more arcane than the one in #18416. Therefore we now don't proxify component instances anymore, which also makes the dev time proxy warning obsolete. --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com> Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>	2 weeks ago
Alexander Kireyev	09a67efcfc	fix: warn on undeclared shorthand event handlers on svelte:window/document/body (#18480 ) Same as we already did on regular elements. Fixes #18275 --------- Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>	2 weeks ago
Hyunbin Seo	44bd73f3e5	docs: replace N-ary times `⨉` with multiplication sign `×` (#18418 ) Replaces the incorrect N-Ary Times Operator `⨉` (U+2A09) with the correct Multiplication Sign `×` (U+00D7) in the box dimension label. Former is intended for mathematical set theory and type theory contexts. For physical dimensions (width × height), `×` is the correct symbol.	2 weeks ago
john gravois	793e309d4e	docs: fix typo in basic markup doc (#18434 ) the current example in the docs conflates two different (commonly associated) words. https://www.reddit.com/r/namenerds/comments/1m6yiw6/what_do_we_think_of_the_name_aretha/	2 weeks ago
AminBouchareb	07dda4056b	docs: document rune_missing_parentheses compiler error (#18589 )	2 weeks ago
Kamil Jakubus	38ef714f1a	fix: scope SSR boundary failed snippets to their boundary (#18593 ) Each `<svelte:boundary>` with: ```svelte {#snippet failed(error)} ... {/snippet} ``` generated a function named failed. Sibling boundaries placed both functions in the same SSR scope: ```js { function failed() {} function failed() {} // Identifier `failed` has already been declared } ``` Resulting in a `[PARSE_ERROR] Identifier `failed` has already been declared` error during build time. A let declaration such as `{const x = 0}` can create a nested lexical block, exposing the collision. The fix gives each boundary its own scope: ```js { function failed() {} $$renderer.boundary({ failed }, ...); } { function failed() {} $$renderer.boundary({ failed }, ...); } ``	2 weeks ago
Jared Dunham	f4918d86f3	docs: added generic type parameter example for $state (#18494 )	2 weeks ago
Liam O'Dea	f5f70343df	perf: O(n²)→O(n) Map lookups for legacy reactive statements (#18602 )	2 weeks ago

1 2 3 4 5 ...

11389 Commits (portals) All Branches Search

11389 Commits (portals)

All Branches