svelte

Commit Graph

Author	SHA1	Message	Date
Simon Holthausen	8f7e8b936e	fix: ensure deferred effects can be rescheduled later on When deferring effects we didn't unmark the deriveds that lead to those effects. This means that they might not be reached in subsequent runs of `mark_reactions`. Fixes https://github.com/sveltejs/svelte/issues/17118#issuecomment-3521488865	24 hours ago
github-actions[bot]	e238e6611e	Version Packages (#17135 ) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	3 days ago
Simon H	14b0926008	fix: don't deactivate other batches (#17132 ) There's a possibility of a race condition where `batch.deactivate()` is called while `current_batch !== batch`, and so it would deactivate another batch, which can lead to zombie batches that are never flushed, subsequently leading to wrong `batch_values`. This fixes that by checking if the current batch is the own batch. Fixes #17109	3 days ago
github-actions[bot]	554202ecf4	Version Packages (#17127 ) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	5 days ago
Simon H	68d4f9c3b6	fix: wait on dependencies of async bindings (#17120 ) * fix: wait on dependencies of async bindings Correctly takes into account blockers for bindings. Also ensures it works for functional bindings. During that I also noticed a bug in our `nodes_end` assignment logic, which the added test also regresses against. Fixes #17092 Fixes #17090 * ensure async static props/attributes are awaited * wait on blockers in binding validation * await dependencies of style directives * tidy	6 days ago
github-actions[bot]	3a4dc7d83d	Version Packages (#17119 ) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	1 week ago
Rich Harris	46e9d2d357	chore: remove `UNOWNED` flag (#17105 ) Fixes #17024 Fixes #17049 (comment) (and therefore everything that was still buggy in that issue I think) * chore: remove unowned check when calling `e.effect_in_unowned_derived` * WIP * all non-unit tests passing * tidy * WIP * WIP * WIP * note to self * fix * fix * hmm maybe not * try this * simplify * remove skip_reaction * docs * add changeset, in case this results in changed behaviour * Update packages/svelte/src/internal/client/reactivity/effects.js Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> * fix #17024 * fix comment * revert * fix * dry * changeset * fix WAS_MARKED logic * failing test (that uncovered other unrelated bug) + fix * fix: delete from batch_values on updates (#17115) * fix: delete from batch_values on updates This fixes a bug where a derived would still show its old value even after it was indirectly updated again within the same batch. This can for example happen by reading a derived on an effect, then writing to a source in that same effect that makes the derived update, and then read the derived value in a sibling effect - it still shows the old value without the fix. The fix is to _delete_ the value from batch_values, as it's now the newest value across all batches. In order to not prevent breakage on other batches we have to leave the status of deriveds as-is, i.e. within is_dirty and update_derived we cannot update its status. That might be a bit more inefficient as you now have to traverse the graph for each `get` of that derived (it's a bit like they are all disconnected) but we can always optimize that later if need be. Another advantage of this fix is that we can get rid of duplicate logic we had to add about unmarking and reconnecting deriveds, because that logic was only needed for the case where deriveds are read after they are updated, which now no longer hits that if-branch * keep derived cache, but clear it in mark_reactions (#17116) --------- Co-authored-by: Rich Harris <rich.harris@vercel.com> Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>	1 week ago
github-actions[bot]	7a2435471c	Version Packages (#17087 ) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	1 week ago
Simon H	eea8a18cf2	fix: ensure fork always accesses correct values (#17098 ) Not all batches will flush right after being activated, some will be activated and then `get` is called on a signal. In that case the value was wrong because we did not apply the changes of that batch. By doing `this.apply()` during `activate()` we ensure we do, which fixes (among other things, likely) a forking bug where old values where sneaking in. Fixes #17079	1 week ago
7nik	b7625fd42c	fix: do not spread non-enumerable symbols (#17097 )	2 weeks ago
Rich Harris	8ebbb3c7bc	fix: preserve symbols when creating derived rest properties (#17096 ) fixes #17094	2 weeks ago
Simon H	0e709e3fec	fix: change title only after any pending work has completed (#17061 ) * fix: change title only after any pending work has completed We have to use an effect - not a render effect - for updating the title, and always. That way we change the title only after any pending work has completed. Fixes #17060 * fix	2 weeks ago
github-actions[bot]	723c421fbb	Version Packages (#17078 ) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	2 weeks ago
Rich Harris	a791e9178b	fix: treat each blocks with async dependencies as uncontrolled (#17077 )	2 weeks ago
github-actions[bot]	8ebc3b1337	Version Packages (#17076 ) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	2 weeks ago
Simon H	9477f18b77	fix: transform `$bindable` after `await` expressions (#17066 ) Fixes #17064	2 weeks ago
github-actions[bot]	70d020bd91	Version Packages (#17055 ) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	2 weeks ago
Alejandro Torres	83746adcf7	Fix spelling in code comments (#17059 )	2 weeks ago
Rich Harris	1126ef3186	feat: out of order rendering (#17038 ) * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * revert * note to self * unused * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * deprecate * update tests * lint * lint * WIP * WIP * fix * WIP * unused * deopt to ensure state is ready * fix * DRY * reduce diff * reduce diff * reduce diff * handle blocked attributes * WIP * pre-transform * tidy up * fix * WIP * WIP * fix: handle `<svelte:head>` rendered asynchronously * fix tests * fix * delay resolve * Revert "fix" This reverts commit `2e56cd7575`. * add error * simplify/fix hydration restoration * fix * use $state.eager mechanism for $effect.pending - way simpler and more robust * disable these warnings for now, too many false positives * fix * changeset was already merged * changeset * oops * lint * docs + tidy * prettier * robustify: logic inside memoizer and outside could get out of sync, introducing bugs. use equality comparison instead * oops * uncomment * use finally * use is_async --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>	2 weeks ago
Rich Harris	90a8a03988	fix: settle batch after DOM updates (#17054 )	2 weeks ago
github-actions[bot]	1b2f7b068e	Version Packages (#17053 ) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	2 weeks ago
Simon H	d2f453f8b0	fix: don't restore batch in `#await` (#17051 ) #16977 had one slight regression which might contribute to #16990: The batch from earlier was restored, but that doesn't make sense in this situations since this has nothing to do with our new async logic of batches suspending until pending work is done. As a result you could end up with a batch being created, and then the restore then instead reverting to an earlier batch that was already done, which means a ghost-batch ends up in the set of batches, subsequently triggering time traveling when it shouldn't. This may help with #16990 No test because basically impossible to do so	2 weeks ago
Rich Harris	cc0143c904	fix: handle `<svelte:head>` rendered asynchronously (#17052 ) * fix: handle `<svelte:head>` rendered asynchronously * fix tests	2 weeks ago
github-actions[bot]	da00abe116	Version Packages (#17037 ) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	3 weeks ago
Rich Harris	b5e23a6d13	chore: tweak memoizer logic (#17042 )	3 weeks ago
Rich Harris	fc181cf611	chore: move `$effect` visitors (#17041 )	3 weeks ago
Rich Harris	9096680c2e	chore: use ESTree namespace imports (#17040 )	3 weeks ago
Rich Harris	b01647455c	chore: create_expression_metadata -> ExpressionMetadata (#17039 ) * chore: create_expression_metadata -> ExpressionMetadata * err whatever	3 weeks ago
Paolo Ricciuti	8368a4beb9	fix: better error message for global variable assignments (#17036 )	3 weeks ago
github-actions[bot]	e33f774877	Version Packages (#17035 ) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	3 weeks ago
Rich Harris	657ec89caa	fix: ignore fork `discard()` after `commit()` (#17034 ) * fix: ignore fork `discard()` after `commit()` * fix message	3 weeks ago
github-actions[bot]	875a04170e	Version Packages (#17029 ) * Version Packages * minor not patch * Apply suggestions from code review --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Rich Harris <rich.harris@vercel.com>	3 weeks ago
Rich Harris	d8137b78a5	fix: less confusing names for inspect errors (#17026 ) * fix: less confusing names for inspect errors * fix * Update packages/svelte/src/internal/client/dev/inspect.js * fix	3 weeks ago
Simon H	b7f39b464a	fix: always allow `setContext` before first await in component (#17031 ) The previous check was flawed because EFFECT_RAN would be set by the time it is checked, since a promise in a parent component will cause a delay of the inner component being instantiated. Instead we have a new field on the component context checking if the component was already popped (if se we are indeed too late). Don't love it to have a field just for this but I don't see another way to reliably check it. Fixes #16629	3 weeks ago
Rich Harris	4eb432e941	chore: remove event hoisting (#17030 ) * chore: get rid of hoisted event handlers * remove unused stuff * simplify * wow we can delete so much more code. this makes me so happy * even more!	3 weeks ago
Rich Harris	c08ecba1b7	feat: forking (#17004 ) * chore: run boundary async effects in the context of the current batch * WIP * reinstate kludge * fix test * WIP * WIP * WIP * remove kludge * restore batch_values after commit * make private * tidy up * fix tests * update test * reset #dirty_effects and #maybe_dirty_effects * add test * WIP * add test, fix block resolution * bring async-effect-after-await test from defer-effects-in-pending-boundary branch * avoid reawakening committed batches * changeset * cheat * better API * regenerate * slightly better approach * lint * revert this whatever it is * add test * Update feature description for fork API * error if missing experimental flag * rename inspect effects to eager effects, run them in prod * regenerate * Apply suggestions from code review Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> * tidy up * add some minimal prose. probably don't need to go super deep here as it's not really meant for non-framework authors * bit more detail * add a fork_timing error, regenerate * unused * add note * add fork_discarded error * require users to discard forks * add docs * regenerate * tweak docs * fix leak * fix * preload on focusin as well * missed a spot * reduce nesting --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>	3 weeks ago
Rich Harris	7434f21ed4	chore: configurable sandbox output (#17028 )	3 weeks ago
github-actions[bot]	4a214f786f	Version Packages (#17019 ) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	3 weeks ago
Rich Harris	f45d9cfe2d	fix: better optimization of await expressions (#17025 )	3 weeks ago
Rich Harris	2e1dd489f6	fix: coordinate mount of snippets with await expressions (#17021 ) * fix: coordinate mount of snippets with await expressions * try this * deduplicate --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>	3 weeks ago
Rich Harris	523c85bd3d	merge	3 weeks ago
Rich Harris	4e847cfd14	merge main	3 weeks ago
Rich Harris	0b477871e8	fix: coordinate mount of snippets with await expressions	3 weeks ago
Simon H	bd697c12c6	fix: flush pending changes after rendering `failed` snippet (#16995 ) fixes #16730	3 weeks ago
Simon H	cd3a11edff	fix: take into account static blocks when determining transition locality (#17018 ) The "is this a transparent effect we can ignore" logic for determining whether or not to play a local transition didn't account for pruned block effects. This fix marks the child branch as transparent if the block effect was, and during traversal then checks if the branch is the child of a block - if not that means it's the child of a pruned block effect. fixes #16826	3 weeks ago
github-actions[bot]	86aedaecf9	Version Packages (#17009 ) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	3 weeks ago
Simon H	16117d9b69	perf: skip repeatedly traversing the same derived (#17016 ) * perf: skip repeatedly traversing the same derived We introduce a new flag which marks a derived during the mark_reaction phase and lift it during the execution phase. * fix This introduces a new flag which marks a derived as visited during the mark_reaction phase and lifts it during the dirty-check/execution phase (both are necessary because not all deriveds are necessarily executed, but they're always checked). We could've used a Set on mark_reactions which would've been simpler to reason about, alas it was performing consistenly worse on the kairo_mux_unowned / kairo_mux_owned benchmarks (it kinda makes sense generally, creating and filling a set is more expensive than juggling flags). Closes #16658, which showcases are particularly gnarly signal graph where many deriveds point to the same deriveds, where we would be traversing the same reactions over and over if we didn't do this. I also added a similar measure (this time a set/map is unavoidable/makes more sense) for mark_effects, hopefully this helps for #16990	3 weeks ago
dependabot[bot]	a28904c87a	chore(deps): bump vite from 5.4.20 to 7.1.11 (#17006 ) Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.4.20 to 7.1.11. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v7.1.11/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-version: 7.1.11 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	3 weeks ago
Rich Harris	851da4b629	chore: exclude vite optimized deps from stack traces (#17008 )	3 weeks ago
github-actions[bot]	3009a0208f	Version Packages (#16992 ) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	3 weeks ago

1 2 3 4 5 ...

10701 Commits (deferred-unmark-fix) All Branches Search

10701 Commits (deferred-unmark-fix)

All Branches