129 Commits (custom-condition)

Author	SHA1	Message	Date
paoloricciuti	e2aac6a6c2	Merge branch 'add-custom-renderer-flag' into custom-condition	7 hours ago
paoloricciuti	23856236f9	Merge branch 'svelte-custom-renderer' into fix-interleaving	7 hours ago
paoloricciuti	0af2ad75b1	Merge remote-tracking branch 'origin/main' into svelte-custom-renderer	7 hours ago
waltu	a956c2bd1f	fix: error when using `let:` directives on a component with a `children` snippet (#18873) ... Closes #13864 A `let:` directive on a component only applies to the default slot content. If the content is an explicit `{#snippet children()}` block, the value is never provided, so code like this compiles but fails at runtime with "value is not defined": ```svelte <Child let:value> {#snippet children()}Value is: {value}{/snippet} </Child> ``` This adds a compile error on the directive that points to snippet parameters instead (`{#snippet children({ value })}`, or `{ item: x }` for `let:item={x}`). Components with a `slot` attribute are not affected, since there the directive applies to the component itself. An unused `let:` next to a `children` snippet is also flagged now, but it never had any effect. ### Before submitting the PR, please make sure you do the following - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`. - [x] This message body should clearly illustrate what problems it solves. - [x] Ideally, include a test that fails without this PR but passes with it. - [x] If this PR changes code within `packages/svelte/src`, add a changeset (`npx changeset`). ### Tests and linting - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint` Co-authored-by: waltu <182410443+waltuov@users.noreply.github.com>	6 days ago
paoloricciuti	60e2eadccc	chore: force `custom-renderer` custom condition	1 week ago
paoloricciuti	2a6fe73855	chore: create error for missing foreign	1 week ago
paoloricciuti	b84a399d5b	chore: create error for missing foreign	4 weeks ago
paoloricciuti	17e37a51bc	Merge remote-tracking branch 'origin/main' into svelte-custom-renderer	4 weeks ago
Bao Nguyen	4bf15ae6f3	fix: throw when `setContext` is called after an `await` during SSR (#18739) ... Fixes #17233.	1 month ago
paoloricciuti	e20068fdbf	Merge remote-tracking branch 'origin/main' into svelte-custom-renderer	1 month ago
Adnane Taghi	4ae5eb3f23	feat: add has function to createContext (#18472) ... closes #18471. --------- Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>	1 month ago
paoloricciuti	eb7532dd70	Merge remote-tracking branch 'origin/main' into svelte-custom-renderer	1 month ago
Bao Nguyen	1be496f0a6	fix: accept `onfocusin`/`onfocusout` in `a11y_mouse_events_have_key_events` (#18689) ... Fixes #8089 focusin/focusout are the bubble variants of focus/blur --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>	1 month ago
paoloricciuti	54135abac9	Merge remote-tracking branch 'origin/main' into svelte-custom-renderer	1 month ago
ChaseCopeland	15720b16a5	docs: Updated docs to include information on easing functions (#16070) ... closes #15992 This is a minor update to the easing documents. It adds an overview description for the module and short descriptions for each of the easing functions. --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> Co-authored-by: vercel[bot] <35613825+vercel[bot]@users.noreply.github.com> Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>	1 month ago
Khaled Waleed	2d2e5df26e	fix: don't turn component instances stored in $state into state proxies (#18646) ... Fixes #18416. We previously said that we don't want to handle component instances specifically when they're wrapped with state in #16747 - though the use case presented back then was much more arcane than the one in #18416. Therefore we now don't proxify component instances anymore, which also makes the dev time proxy warning obsolete. --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com> Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>	1 month ago
AminBouchareb	07dda4056b	docs: document rune_missing_parentheses compiler error (#18589)	1 month ago
Nic Polumeyv	2f684fefd7	docs: clarify that context lookup includes the current component and all ancestors (#18581) ... Fixes #7916. Context lookup starts at the current component, not the closest parent. `setContext` followed by `getContext` with the same key in the same component returns the value. --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>	1 month ago
Paolo Ricciuti	56856f0b10	fix: `customRenderer` as a global option and remove `without_renderer` (#18359) ... Co-authored-by: Rich Harris <rich.harris@vercel.com> Co-authored-by: Rich Harris <hello@rich-harris.dev>	4 months ago
paoloricciuti	a72c3650c9	Merge remote-tracking branch 'origin/main' into svelte-custom-renderer	4 months ago
Simon H	59d3a36f82	feat: allow declarations in the template (#18282) ... Allows `{let/const ...}` declarations in all places (and more) where we already allow `{@const ...}` (which will eventually get deprecated in favor of this new feature). Closes: #16490 Companion PRs: - https://github.com/sveltejs/language-tools/pull/3033 - https://github.com/sveltejs/prettier-plugin-svelte/pull/533 - https://github.com/sveltejs/eslint-plugin-svelte/pull/1533 - https://github.com/sveltejs/svelte-eslint-parser/pull/891 --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	4 months ago
Paolo Ricciuti	91563f0b04	Merge branch 'main' into svelte-custom-renderer	4 months ago
Rich Harris	0da9f9e2ab	fix: disallow effect creation after `await` (#18299) ... We incorrectly restore effect context after an`$derived(await ...)` if it occurs inside an async function, but only for those, no other `await` expressions. This is buggy and wrong. We only want to restore context _inside_ an async derived expression (including template expressions)` so that `await a + b` works correctly. It's possible that this will be a breaking change (albeit not semver-violating, because `experimental`) for some people if they are creating effects after an `await` (other than at the top level of a component). This is regrettable, but it should never have worked in the first place.	4 months ago
Paolo Ricciuti	a8296352a1	Merge branch 'main' into svelte-custom-renderer	4 months ago
RonGamzu	d2c7fa3494	fix: use consistent spelling in script_unknown_attribute warning (#18281) ... ## Summary The `script_unknown_attribute` warning message used American English (`Unrecognized`) while every other user-facing error/warning in the compiler uses British English (`Unrecognised`): - `options_unrecognised` error: `Unrecognised compiler option…` - `unknown_code` warning: `is not a recognised code` This change updates `script_unknown_attribute` to match, then regenerates `warnings.js` and the reference documentation from the source message file via `node scripts/process-messages`. ## Test plan - Spelling change is isolated to the `script_unknown_attribute` warning message - `warnings.js` and generated docs were updated by running `node scripts/process-messages` - All three occurrences (source, generated JS, generated docs) are consistent	4 months ago
paoloricciuti	d8f94880fb	chore: merge	4 months ago
Karl Georgsen	f023e8d7c8	chore: add tag name to a11y_click_events_have_key_events warning (#18272) ... Ref: https://github.com/sveltejs/svelte/issues/15100 Adds the tag name to the `a11y_click_events_have_key_events` warning given when a non-interactive element has a click handler but no keyboard events. This already happens in `a11y_no_static_element_interactions`, and should probably happen in many more messages.	4 months ago
Paolo Ricciuti	20bd0cfc13	Merge branch 'main' into svelte-custom-renderer	6 months ago
Rich Harris	0e9e76f292	fix: freeze deriveds once their containing effects are destroyed (#17921) ... Per https://github.com/sveltejs/svelte/pull/17862#issuecomment-4049752548, this freezes the value of a derived if it was created inside a parent effect that is now destroyed. This prevents the sort of bug where a derived reads `foo.bar` even though `foo` is now `undefined`. If the derived is dirty, a warning will be printed. This PR also gets rid of some weirdness around `derived.parent` — it can only ever be an `Effect | null`, and there's no need for `get_derived_parent_effect`. Blocked on https://github.com/sveltejs/kit/pull/15533 and a follow-up that switches remote functions to use `$effect.root` (since this effectively undoes #17171), hence draft. ### Before submitting the PR, please make sure you do the following - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`. - [x] This message body should clearly illustrate what problems it solves. - [x] Ideally, include a test that fails without this PR but passes with it. - [x] If this PR changes code within `packages/svelte/src`, add a changeset (`npx changeset`). ### Tests and linting - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint` --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>	6 months ago
paoloricciuti	883611fd8b	chore: remove duplicate error	6 months ago
paoloricciuti	7d37884d38	fix: throw error if snippet is rendered in renderer different from compiler	6 months ago
Paolo Ricciuti	63d87445db	Merge branch 'main' into svelte-custom-renderer	6 months ago
Rich Harris	ff3495dc05	fix: disallow `--` in `idPrefix` (#18038) ... supersedes #17993	6 months ago
paoloricciuti	13ae09b861	fix: throw descriptive error if using `createRawSnippet` using custom renderer	6 months ago
paoloricciuti	df42e4babd	fix: add validations for `svelte:dom` elements	6 months ago
paoloricciuti	098cdebe95	fix: disallow css injected with custom renderer	6 months ago
Rohit Nair P	4879f9da99	fix: improve duplicate module import error message (#18016) ... ## Description **While investigating the compiler analysis phase for errors or missing lines, I located an explicit `TODO fix the message here` comment in the source code (`packages/svelte/src/compiler/phases/2-analyze/visitors/shared/utils.js`).** ### Triggering Code ```svelte <script module> import { foo } from './somewhere.js'; </script> <script> let foo = 'conflict'; // Triggers the duplicate module import error </script> ``` ## The Bug When a component author creates a local `let` declaration in the instance `<script>` block that shadows a variable imported in the `<script module>` block, the compiler emits a `declaration_duplicate_module_import` error. However, the error message text was misleading. It stated: ```diff - Cannot declare a variable with the same name as an import inside `<script module>` + Cannot declare a variable with the same name as an import from `<script module>` ``` This incorrectly implies that the duplicate declaration itself is happening *inside* the module script block, rather than colliding with an import *from* that block. ## Changes Made | Action | Target (File / Function) | Description | | :--- | :--- | :--- | | **Template Fix** | `packages/svelte/messages/compile-errors/script.md` | Changed "inside" to "from" to accurately reflect the nature of the shadow collision. | | **Regenerated Errors** | `packages/svelte/src/compiler/errors.js` | Ran `pnpm generate` to apply the updated markdown template into the dictionary list. | | **Removed TODO** | `ensure_no_module_import_conflict` function | Removed the original `// TODO fix the message here` notation from the validator. | | **Test Adjustments** | `illegal-variable-declaration/errors.json` | Updated the validator test suite snapshots to assert against the correct error message format. | ## Validation Results * The error correctly throws when a user replicates this component structure. * Vitest suite `tests/validator/test.ts` successfully asserts the new, clearer message. --- ### Before submitting the PR, please make sure you do the following - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`. - [x] This message body should clearly illustrate what problems it solves. - [x] Ideally, include a test that fails without this PR but passes with it. - [x] If this PR changes code within `packages/svelte/src`, add a changeset (`npx changeset`). ### Tests and linting - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint` # THANK YOU	6 months ago
Rich Harris	a513da0445	chore: add invariant utility (#17929) ... With this, we can add invariants to the codebase so we can identify problems like 'this batch already has roots scheduled', which indicate a bug somewhere, without a) needing tests for scenarios that are inherently hard to anticipate, or b) cluttering people's prod bundles	7 months ago
Rich Harris	04ba134d33	docs: flesh out `attribute_invalid_sequence_expression` message (#17789) ... closes #1404	7 months ago
Elliott Johnson	73098bb26c	Merge commit from fork ... * fix: check to make sure `svelte:element` tags are valid during SSR * fix: error instead of warn * better sharing * nit	7 months ago
Rich Harris	2287ad005a	fix: detect and error on non-idempotent each block keys in dev mode (#17732) ... ## Summary Fixes #17721 In dev mode, detect when a keyed each block has a key function that returns different values when called multiple times for the same item (non-idempotent). This catches the common mistake of using array literals like `[thing.group, thing.id]` as keys, which creates a new array object each time and will never match by reference. - Adds new `each_key_volatile` error with helpful message explaining the issue - Checks key idempotency in the each block loop during dev mode - Provides a clear error instead of the cryptic "Cannot read properties of undefined" that occurred previously --------- Co-authored-by: 7nik <kifiranet@gmail.com>	8 months ago
Rich Harris	f09785424b	docs: add crosslinks (#17663)	8 months ago
Bladesheng	0cbf718aef	feat: allow passing `ShadowRootInit` to custom element `shadow` options (#17088) ... * feat: allow passing ShadowRootInit to custom element shadow options * tests * add changeset * update docs * allow passing functions * remove newline * update docs * fix test * update docs * simplify options reading * remove the option to pass function to `shadow` * fix whitespace * fix whitespace * fix generated types --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	8 months ago
Pooh	7ab62a5878	docs: fix <svelte:boundary> tag in const_tag_invalid_placement message (#17501) ... Co-authored-by: Thanadol Chitthamlerd <tchitthamlerd@smartertravel.com>	8 months ago
Elliott Johnson	c86c4fdca1	feat: Add CSP support for `hydratable` (#17338)	10 months ago
ComputerGuy	bec7ca7918	fix: throw on invalid `{@tag}`s (#17256) ... * fix: throw on invalid `{@tag}`s * fix	10 months ago
Alejandro Torres	3c63b12ccd	chore: fix typos in code comments and documentation (#17187) ... * chore: fix typos in code comments and documentation * regenerate --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	10 months ago
Elliott Johnson	c2a110cd81	feat: `hydratable` (#17154) ... * feat: * doc comments * types * types * changeset * tests * docs * hopefully * lint * finally figured out test issues * get docs building * the easy stuff * prune errors * feat: capture clobbering better, capture unused keys, don't block on unused keys * progress on serializing nested promises * fix * idk man but the tests are passing so i'ma checkpoint this * fix tests * compare resolved serialized values * robustify * thunkify * fixes * ajsldkfjalsdfkjasd * tests * docs * ugh * ugh ugh ugh * Update documentation/docs/06-runtime/05-hydratable.md Co-authored-by: kaysef <25851116+kaysef@users.noreply.github.com> * make errors better * tweak * remove context restoration * fix * trim * simplify hydratable (#17230) * simplify hydratable * tidy up * unused --------- Co-authored-by: Elliott Johnson <sejohnson@torchcloudconsulting.com> * improve errors * include all non-internal frames, handle identical stacks * tweak example * tweak message — setTimeout is covered by ALS * cut out the middleman * unused * tidy * Apply suggestions from code review --------- Co-authored-by: Rich Harris <rich.harris@vercel.com> Co-authored-by: kaysef <25851116+kaysef@users.noreply.github.com>	10 months ago
Simon H	84b261886b	chore: lift "flushSync cannot be called in effects" restriction (#17139) ... Since async-await was introduced into the code base a lot has changed. This lifts the restriction. Closes #17131 (though I still wonder why Skeleton does that)	10 months ago
Simon H	91486fa807	fix: take async into account for bindings/transitions/animations/attachments (#17198) ... * fix: take async into account for bindings/transitions/animations/attachments - block on async work - error at compile time on await expressions. Right now it gives confusing errors later at compile time or at runtime Fixes #17194 * this was weird	10 months ago