svelte

Commit Graph

Author	SHA1	Message	Date
Rich Harris	e5e2d16f17	Merge branch 'main' into async-another-try	2 days ago
Simon H	98e547535d	fix: flush anything pending before invoking flushSync callback function (#18878 ) no new test here but it's necessary for #18861 to work, and we might as well extract it	2 days ago
Simon H	da2f83343b	fix: read batch-local array on each-block commit (#18879 ) Another extraction from #18861 which I'm pretty sure you can also construct a buggy reproduction for today, but with #18861 it's strictly necessary so we don't need to come up with one now	2 days ago
Simon Holthausen	894f376b37	Merge branch 'main' into async-another-try	2 days ago
Simon Holthausen	48100417b5	simplify	2 days ago
Simon Holthausen	54d8c3d843	set deriveds to clean when it's latest value (avoids overfiring); save maybe_dirty deriveds in deferred batches (avoids underfiring that would otherwise happen as a result of the first fix)	2 days ago
Rich Harris	58297c5a73	chore: extract some minor changes from #18861 (#18866 ) doing my usual thing of extracting no-brainer changes from a giant PR to try and make it slightly less giant	2 days ago
Simon Holthausen	06cfc31f8d	fix jsdoc	2 days ago
Simon Holthausen	11b95fe1e8	we don't need the callback anymore	2 days ago
Simon Holthausen	08a17b9839	another fork fix	3 days ago
Simon Holthausen	df50aa8384	eager batches don't need to run inside forks and don't need to notify them	3 days ago
Simon Holthausen	7509485eca	oops	3 days ago
Simon Holthausen	957330c89c	feedback	3 days ago
Mariana Castro	38098a9311	fix: don't overwrite an unchanged spread `value` (#18864 ) Fixes #18862 When a `value` is applied through a spread (`<input {...props} />`), `set_attributes` always writes `element.value`, even if the element already has that value. Writing `value` on a number input clears any incomplete text: typing `250.` makes `input.value` `''` (the text is still visible, but `validity.badInput` is `true`). If the spread `value` then becomes `''` too, writing `''` erases what the user typed. This is what happens with SvelteKit remote forms: `fields.quantity.as('number')` coerces `''` to `undefined`, the spread `value` becomes `''`, and Svelte writes it back to the input. When `.` is typed: - Chromium clears the input in every locale, because `250.` is always incomplete input there. - WebKit/Safari clears it in locales where `.` is not the decimal separator (e.g. `fr-CH`), which is where the reporter saw it. A plain `<input type="number">` never clears. Neither does the same `value` in Svelte without a spread (`value={...}`), because `set_value` already skips writing when `element.value === value`. This PR adds the same check to the spread path. Svelte 3 had this check too (#3426, #3495); it was lost in Svelte 5. The first write still always happens. Writing `value` sets the input's dirty value flag, and without that flag a `defaultValue` applied afterwards would change the current value (covered by `form-default-value-spread`). This also likely affects sveltejs/kit#16270 (same symptom, plus a cursor jump caused by redundant writes). That issue is handled on the kit side in sveltejs/kit#16320; this PR is independent of it. The test runs in a real browser (`runtime-browser`). It types with `document.execCommand('insertText')`, which goes through Chromium's own editing, so `250.` is real incomplete input. The locale is not mocked. The test fails without this change and passes with it. ### Before submitting the PR, please make sure you do the following - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`. - [x] This message body should clearly illustrate what problems it solves. - [x] Ideally, include a test that fails without this PR but passes with it. - [x] If this PR changes code within `packages/svelte/src`, add a changeset (`npx changeset`). ### Tests and linting - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint` --------- Co-authored-by: Paolo Ricciuti <ricciutipaolo@gmail.com>	3 days ago
Tee Ming	325620ba63	fix: bypass error boundaries for hydration recovery (#18841 ) Fixes #18840 This PR rethrows the hydration error rather than catching it at the boundaries so that the svelte hydration warning can surface ### Before submitting the PR, please make sure you do the following - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`. - [x] This message body should clearly illustrate what problems it solves. - [x] Ideally, include a test that fails without this PR but passes with it. - [x] If this PR changes code within `packages/svelte/src`, add a changeset (`npx changeset`). ### Tests and linting - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint` --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>	3 days ago
Simon Holthausen	87a061a73f	consolidate (maybe_)dirty_effects and dirty_deriveds	4 days ago
Simon Holthausen	4d8f4410f7	perf	4 days ago
Kunpeng Xie	803f59b171	fix: avoid reinserting dynamic elements during hydration (#18855 ) Hydrating a `<svelte:element>` currently removes and reinserts the DOM node that was already claimed from the server-rendered HTML. This can restart CSS animations and disconnect/reconnect custom elements inside it. Keep claimed elements in place while preserving insertion for client-created elements and later tag changes. Capture the hydration state before rendering children, since empty or void elements can temporarily turn hydration off. Fixes #18852. ### Before submitting the PR, please make sure you do the following - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`. - [x] This message body should clearly illustrate what problems it solves. - [x] Ideally, include a test that fails without this PR but passes with it. - [x] If this PR changes code within `packages/svelte/src`, add a changeset (`npx changeset`). ### Tests and linting - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint` Validation: - The real Chromium regression fails on unchanged `636eaaaa`: hydration removes all four server-rendered dynamic elements. Client mounting and server rendering pass. - The regression checks node removals and custom-element connection callbacks for ordinary, empty, void, and custom dynamic elements, then changes the tags and removes/recreates an element. - A hydration mismatch regression verifies that different client/server child branches recover while retaining the outer element and its following sibling. - `pnpm test hydration runtime-browser`: 219 passed. - Full `CI=true pnpm test`: 34 test files passed, 7,790 tests passed, 55 existing skips. The real-browser suite ran with Chromium. - `pnpm check`: passed, including build, generated type checks, and treeshakeability checks. - `pnpm lint`: passed. AI assistance: This change and its tests were prepared with OpenAI Codex. The PR description is also AI-assisted. --------- Co-authored-by: paoloricciuti <ricciutipaolo@gmail.com>	4 days ago
Simon Holthausen	9fd77d22a5	another	4 days ago
Simon Holthausen	408d51b362	tuple->object	4 days ago
Simon Holthausen	bd0faecdaa	explanatory comment, remove obsolete deletion	4 days ago
Simon Holthausen	494c8b9f08	another	4 days ago
Simon Holthausen	3b92502f00	codegolf	4 days ago
Simon Holthausen	b08aeee3cf	fix more edge cases	4 days ago
Simon Holthausen	7005aae212	more edge case fixes	5 days ago
Simon Holthausen	ba4d37a4b4	belts and braces	5 days ago
Simon Holthausen	32f4451f2e	fix flushSync (should drain queue before calling the function)	5 days ago
Simon Holthausen	31524c792e	e prop for sources	5 days ago
Simon Holthausen	91d215664f	resolve some todos	6 days ago
Simon Holthausen	15ccee8e0f	cleanup	6 days ago
Simon Holthausen	ddffe3efe2	align	6 days ago
Simon Holthausen	62fafd63ab	align	6 days ago
Simon Holthausen	5de9201dc2	tweak	6 days ago
Simon Holthausen	64bd3a18f1	tweak test for new behavior	6 days ago
Simon Holthausen	d592d8aebd	original test obsolete, refactor into a new test	6 days ago
Simon Holthausen	387995cd63	remove some dead weight	6 days ago
Simon Holthausen	ab75873a57	more fixes	6 days ago
Simon Holthausen	33e3540bb9	fork fix	6 days ago
Simon Holthausen	e5e45aa11b	getting close	7 days ago
github-actions[bot]	636eaaaa6f	Version Packages (#18750 ) This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## svelte@5.57.1 ### Patch Changes - fix: cancel deferred event listeners during cleanup ([#18749](https://github.com/sveltejs/svelte/pull/18749)) - fix: preserve global CSS in components without scopable elements ([#18793](https://github.com/sveltejs/svelte/pull/18793)) - fix: reduce SSR render result garbage collection ([#18798](https://github.com/sveltejs/svelte/pull/18798)) - fix: resolve the fallback of an each block in the enclosing scope ([#18803](https://github.com/sveltejs/svelte/pull/18803)) - perf: speed up parser interactions with Acorn or avoid them where possible ([#18740](https://github.com/sveltejs/svelte/pull/18740)) - fix: prevent effect tree of batches from interfering with each other ([#18508](https://github.com/sveltejs/svelte/pull/18508)) - fix: serialize input default values during server rendering ([#18733](https://github.com/sveltejs/svelte/pull/18733)) - fix: remove `WAS_MARKED` flag in favor of `Set` ([#18127](https://github.com/sveltejs/svelte/pull/18127)) - fix: throw `set_context_after_init` when `setContext` is called after an `await` during SSR ([#18739](https://github.com/sveltejs/svelte/pull/18739)) - fix: make Object.hasOwn reactive for state proxy ownership changes ([#18838](https://github.com/sveltejs/svelte/pull/18838)) - fix: keep `$state.eager` when used as a variable initializer ([#18809](https://github.com/sveltejs/svelte/pull/18809)) - perf: avoid regex matching in parser where possible ([#18736](https://github.com/sveltejs/svelte/pull/18736)) - fix: in non-async mode, only push variable to current_sources when active_reaction is updating ([#18550](https://github.com/sveltejs/svelte/pull/18550)) - fix: recognise `aria-braillelabel` and `aria-brailleroledescription` as known ARIA attributes ([#18765](https://github.com/sveltejs/svelte/pull/18765)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	1 week ago
Simon Holthausen	230b829384	oops	1 week ago
Rich Harris	8030ff2a2c	fix: remove incorrect special handling of :export pseudo-selectors (#18839 ) #18793 added special handling for `:export` selectors, but this is incorrect. `:export` is (apparently) part of [Interoperable CSS](https://github.com/css-modules/icss) but Svelte doesn't (and shouldn't) know what that is. No changeset because #18793 is unreleased, and the changeset in that PR didn't mention ICSS	1 week ago
Simon Holthausen	6cb26772d3	another	1 week ago
Simon Holthausen	2cfc5819d0	fucking hell forks are hard	1 week ago
svelte-triage-bot[bot]	a72dc8eadb	fix: make Object.hasOwn reactive for state proxies (#18838 ) Fixes #18837 ### What changed State proxies now establish a per-property reactive dependency when `Object.hasOwn(proxy, prop)` invokes the `getOwnPropertyDescriptor` trap. Property additions and deletions therefore invalidate the expression, consistently with the `prop in proxy` operator. The source creation uses the same eligibility constraints as the existing `has` trap so inherited properties retain their existing semantics. A runtime-runes regression sample covers both adding and deleting the observed property in DOM and hydration modes. ### Tests and linting - `FILTER=object-has-own-reactive pnpm test runtime-runes --reporter=dot` — 4 passed - `pnpm exec vitest run packages/svelte/src/internal/client/proxy.test.ts --reporter=dot` — 8 passed - `pnpm test runtime-runes --reporter=dot` — 2707 passed, 34 skipped - `pnpm test --reporter=dot` — 7786 passed, 55 skipped - `cd packages/svelte && pnpm check` — passed - `pnpm format` — passed - `pnpm lint` — passed Includes a patch changeset for `svelte`. <!-- svelte-triage-bot:feedback-baseline:81ef2357a99a2592312d5483e38be3f6ddeb4be5 --> --------- Co-authored-by: svelte-triage-bot <team@svelte.com> Co-authored-by: Rich Harris <rich.harris@vercel.com>	1 week ago
Simon Holthausen	a7c16935a5	equality check against what the batch sees to update its value	1 week ago
Simon Holthausen	bf0ecc0578	more	1 week ago
Simon Holthausen	9143c90b04	more messy experimentation	1 week ago
Simon Holthausen	e017878175	messy wip	1 week ago
Simon Holthausen	762e5cb6d8	bring over some tests from entangle batch PR	1 week ago

1 2 3 4 5 ...

11452 Commits (async-another-try) All Branches Search

11452 Commits (async-another-try)

All Branches