svelte

Commit Graph

Author	SHA1	Message	Date
Simon Holthausen	91d215664f	resolve some todos	10 hours ago
Simon Holthausen	15ccee8e0f	cleanup	11 hours ago
Simon Holthausen	ddffe3efe2	align	12 hours ago
Simon Holthausen	62fafd63ab	align	12 hours ago
Simon Holthausen	5de9201dc2	tweak	12 hours ago
Simon Holthausen	64bd3a18f1	tweak test for new behavior	12 hours ago
Simon Holthausen	d592d8aebd	original test obsolete, refactor into a new test	12 hours ago
Simon Holthausen	387995cd63	remove some dead weight	12 hours ago
Simon Holthausen	ab75873a57	more fixes	12 hours ago
Simon Holthausen	33e3540bb9	fork fix	21 hours ago
Simon Holthausen	e5e45aa11b	getting close	1 day ago
Simon Holthausen	230b829384	oops	2 days ago
Simon Holthausen	6cb26772d3	another	2 days ago
Simon Holthausen	2cfc5819d0	fucking hell forks are hard	2 days ago
Simon Holthausen	a7c16935a5	equality check against what the batch sees to update its value	3 days ago
Simon Holthausen	bf0ecc0578	more	3 days ago
Simon Holthausen	9143c90b04	more messy experimentation	3 days ago
Simon Holthausen	e017878175	messy wip	4 days ago
Simon Holthausen	762e5cb6d8	bring over some tests from entangle batch PR	5 days ago
Simon Holthausen	4bdf9e3db4	apply needs to happen before commit callbacks because they can create new batches, causing bugs	5 days ago
Simon Holthausen	70bb532c0d	more	5 days ago
Simon Holthausen	e82d7494f7	wip	6 days ago
Nic Polumeyv	6eb720a1b7	chore: scope.js stops importing from the analysis visitors (#18787 ) `phases/scope.js` imported `validate_identifier_name` from `2-analyze/visitors/shared/utils.js`, which imports `get_rune` back from `scope.js`. The check reads a `Binding` and `Scope.declare` is its main caller, so it now lives in `scope.js`. No behaviour change.	1 week ago
Nic Polumeyv	e6ae460caa	chore: analysis and transform stop importing each other (#18786 ) Analysis imported `should_proxy` from `3-transform/client/utils.js` and transform imported `check_graph_for_cycles` from `2-analyze/utils`. The graph search now lives in `compiler/utils`, `should_proxy` in `phases/scope.js` next to the bindings it reads. No behaviour change.	1 week ago
Nic Polumeyv	5981c060d2	chore: move parser helpers next to their users (#18785 ) Phase 1 imported `disallow_children` from phase 2, `fuzzymatch` sat in the parser's utils while only analysis and `extract_svelte_ignore` used it, `create_fragment` had a file to itself although `create_attribute` lives in `phases/nodes.js`, and `push_array` had a single caller. Each now sits next to its users: `create_fragment` and `disallow_children` in `phases/nodes.js`, `fuzzymatch` in `compiler/utils`, `push_array` inside `mapped_code.js`. Four files fewer, no behaviour change.	1 week ago
svelte-triage-bot[bot]	f2ad10ecd2	fix: preserve global CSS without scopable elements (#18793 ) ## Summary - mark fully global selectors as used without requiring a scopable component element - preserve exact ICSS `:export` rules under the same conditions - keep elements inside `<svelte:head>` excluded from CSS hash injection - add a regression test covering both reported selector forms Fixes #18792	1 week ago
svelte-triage-bot[bot]	a8a9b02e38	fix: reduce SSR render result garbage collection (#18798 ) Fixes #18797. ### Problem SSR `render()` is lazy, but the wrapper benchmark discarded its result and therefore measured almost no rendering work. When `.body` was consumed, each render result's own accessor properties caused substantial garbage-collection overhead. ### Fix - Consume `render(App).body` in both the warmup and measured SSR benchmark loops. - Move lazy render-result properties onto a shared `RenderResult` prototype. - Memoize synchronous output and the asynchronous render promise while preserving lazy sync/async API behavior. - Add a regression test ensuring exposed render-result properties are inherited. - Add a patch changeset for `svelte`. The benchmark now deliberately selects the synchronous lazy-render path by reading `.body`, so the process-wide async flag imported by the reactivity benchmarks does not determine this benchmark's render mode. ### Performance on this host \| Case \| Time \| GC time \| \| --- \| ---: \| ---: \| \| main, output discarded \| 0.20 ms \| 0.00 ms \| \| main, `.body` consumed before fix \| 163.04 ms \| 62.68 ms \| \| `svelte@5.38.10` \| 110.05 ms \| 1.39 ms \| \| fixed, `.body` consumed \| 104.79 ms \| 2.43 ms \| ### Tests - `pnpm test packages/svelte/src/internal/server/renderer.test.ts` — 53 passed - `pnpm test server-side-rendering` — 234 passed, 2 skipped - `pnpm test` — 7,771 passed, 55 skipped - `pnpm lint` - `pnpm check` - `pnpm format` - `git diff --check` <!-- svelte-triage-bot:feedback-baseline:116724e3b641c84ed56b2a60d494b6cb2298bbb3 --> Co-authored-by: svelte-triage-bot <team@svelte.com>	1 week ago
Nic Polumeyv	6be176df2f	fix: resolve the fallback of an each block in the enclosing scope (#18803 ) In `phases/scope.js`, `EachBlock` visits `node.fallback` with the block's own scope, so `{:else}` resolves the loop's name to the each context. With `let item = $state('outer')` outside and `{#each items as item}…{:else}<button onclick={() => (item = 'changed')}>` the compiler reports "Cannot reassign or bind to each block argument" for a variable that is not the block's argument. The fallback renders when there is nothing to iterate, so it is visited in the enclosing scope, as an await block's `pending` is.	1 week ago
Xia Chao	34b13ac3e4	fix: keep `$state.eager` when used as a variable initializer (#18809 ) fixes #18808 If you write `let x = $state.eager(...)`, the client compiler used to delete that line and then still read `x`. The page crashed with `x is not defined`. Server rendering kept the binding. Using `$state.eager(...)` directly in the markup already worked. This puts the `let` / `const` form on the same path as `$state.snapshot`. Added a runtime-runes sample that fails without this change. Co-authored-by: Xia Chao <236466140+bun-unsafe@users.noreply.github.com>	1 week ago
Simon H	ce89035ecb	fix: prevent effect tree of batches from interfering with each other (#18508 ) While working on another Svelte feature I noticed a bug that boils down to batches interfering with each other through the effect tree: If batch A schedules an effect, it is walked up to the root (possibly). Now if in the meantime batch B also wants to schedule effects, it can have unintended consequences. Normally this does not happen, since it's extremely hard to run into this situation. There's basically two cases: Either an unfortunate timing of microtasks, or during flushing effects are scheduling new effects which messes with a `#commit()` right after (the test case does this). To fix this we now defer walking up the tree until the batch is actually processed. That way we set + unset the markers on the branches synchronously so there's no chance of another batch interfering.	2 weeks ago
Simon H	d16099ef0f	fix: remove `WAS_MARKED` flag in favor of `Set` (#18127 ) Removes the `WAS_MARKED` logic in favor of a simple `Set` heuristic: If `mark_reactions` goes beyond a certain count, initialize it, otherwise keep it `null`. Balances the common case of not having many transitive dependencies with the edge case of cyclic dependencies as was seen in #16658 (I rechecked that reproduction and it remains fast with this change). I ran the benchmark against this and it doesn't hit the `Seen` heuristic once (i.e. even the benchmark doesn't have this extreme level of dependencies where it becomes noticeable). Fixes #18123, supersedes #18124 --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	2 weeks ago
Bao Nguyen	5895c637b0	fix: recognise `aria-braillelabel` and `aria-brailleroledescription` as known ARIA attributes (#18765 )	3 weeks ago
JY Wey	9e69544238	fix: in non-async mode, only push variable to current_sources when active_reaction is updating (#18550 ) fix: #16814 in non-async mode, when the derived inside `SvelteDate` is created and evaluated, the `#reaction` is from the `active_reaction` when the `SvelteDate` instance is created, which could possible in NON_UPDATING state, so the derived should not be added to `current_sources` to prevent re-run. --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>	3 weeks ago
Simon H	6f7857af59	chore: compiler profiling + parser bench (#18767 ) Used these to speed up parsing/find compilation bottlenecks. Useful for later analysis therefore committing it.	3 weeks ago
Bao Nguyen	4bf15ae6f3	fix: throw when `setContext` is called after an `await` during SSR (#18739 ) Fixes #17233.	3 weeks ago
Simon H	9d91a40faf	chore: bump packages (#18752 ) esrap bump ensures a bugfix, devalue silences vulnerability reports	3 weeks ago
Simon H	b580455c9c	fix: serialize input default values during SSR (#18733 ) Alternative to #18452 --------- Co-authored-by: svelte-triage-bot <team@svelte.com>	3 weeks ago
Simon H	b2c22ab66d	chore: add regression test for teardown value behavior (#18751 ) #18746 would've introduced a bug that makes this test fail. Add it now so we don't regress in the future	3 weeks ago
Simon H	b1142efe96	perf: speed up parser a little bit (#18736 ) ~5% in local benchmarks by avoiding regex in some places	3 weeks ago
Nic Polumeyv	34142af3a1	perf: build identifier and member chain expressions without acorn (#18740 ) After #18738 the biggest thing left in the parser profile was acorn's constructor, `getOptions` and `wordsRegexp` alone were around 12% of parse time. `parseExpressionAt` is `new Parser()` followed by `parseExpression()`, and we call it for every expression in the template. For something like `{name}` the constructor (normalizing options, four keyword regexes, scope state) is about 2 µs while the actual parse is under 1 µs, and components have dozens of these. The fix seemed to belong in acorn, cache the options and regexes so repeated `parseExpressionAt` calls stop redoing them. I lasted about twenty minutes in acorn's constructor... I was way in over my head. The Svelte alternative was one parser per component, reset between expressions, but that means re-initializing acorn's and acorn-typescript's internals by hand and breaking whenever either adds a field. I realized most of the expressions in the test corpus are an identifier or an `a.b.c` chain, and you don't need a JS parser for those. So that's this fix. `read_expression` now scans for that shape, builds the nodes itself in the form acorn would, and hands everything else to acorn like before.No behavior change, verified byte-for-byte against acorn on the test corpus. About 18% faster parsing on typical components on top of #18738. I guess this should be a fix for acorn, rather than here, so I'm not against closing this. --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>	3 weeks ago
Nic Polumeyv	504a7536c6	perf: stop scanning the whole template for every expression (#18738 ) Parsing a 90 KB component drops from 460 ms to 35 ms; typical components parse ~30% faster. `read_pattern` blanked out the entire template before the pattern with `replace(/[^\n]/g, ' ')` to keep positions aligned, and `acorn.parseExpressionAt` re-counted lines from the top of the file on every call. Acorn never looks before `pos`, so the real template can be the prefix, and acorn 8.18's `startLocation` takes the line we already have from the locator. The blanking also had `loc.column` off by one for every node inside a destructured pattern (noted in #18087), hence the snapshot updates.	3 weeks ago
svelte-triage-bot[bot]	214dd3d005	fix: cancel deferred event listener attachment (#18749 ) Fixes #18748	3 weeks ago
github-actions[bot]	7bc0a70fe6	Version Packages (#18682 ) This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## svelte@5.57.0 ### Minor Changes - feat: export `RenderOutput`, `SyncRenderOutput`, `Csp` and `Sha256Source` from `svelte/server` ([#18648](https://github.com/sveltejs/svelte/pull/18648)) - feat: add `has` function to `createContext` ([#18472](https://github.com/sveltejs/svelte/pull/18472)) - feat: support `defaultValue` on `<select>` ([#18591](https://github.com/sveltejs/svelte/pull/18591)) - feat: add getOrInsert/getOrInsertComputed to SvelteMap ([#18728](https://github.com/sveltejs/svelte/pull/18728)) ### Patch Changes - fix: block template store subscriptions on the promise that assigns the store ([#18582](https://github.com/sveltejs/svelte/pull/18582)) - fix: route $derived teardown errors through invoke_error_boundary ([#18486](https://github.com/sveltejs/svelte/pull/18486)) - fix: track SvelteDate snapshots in reactions ([#18700](https://github.com/sveltejs/svelte/pull/18700)) - fix: remove `<svelte:head>` anchors on unmount ([#18697](https://github.com/sveltejs/svelte/pull/18697)) - fix: warn on undeclared shorthand event handlers on `<svelte:window>`, `<svelte:document>` and `<svelte:body>` ([#18480](https://github.com/sveltejs/svelte/pull/18480)) - perf: reuse the cached value in the `<option>`/`<select>` value guard ([#18713](https://github.com/sveltejs/svelte/pull/18713)) - fix: prevent malformed AST output for `<select>` with static `value` attribute ([#18449](https://github.com/sveltejs/svelte/pull/18449)) - fix: apply ownership mutation ignores to binding assignments ([#18718](https://github.com/sveltejs/svelte/pull/18718)) - fix: prevent onoutroend from firing twice when compilerOptions.hmr is true ([#18655](https://github.com/sveltejs/svelte/pull/18655)) - fix: preserve whitespace after inline elements when printing ([#18685](https://github.com/sveltejs/svelte/pull/18685)) - perf: fold SSR block-open markers into the branch's first push ([#18712](https://github.com/sveltejs/svelte/pull/18712)) - fix: run `onDestroy` callbacks when a server render throws ([#18585](https://github.com/sveltejs/svelte/pull/18585)) - fix: report `derived_invalid_export` for `export let x = $derived(...)` in runes mode ([#18692](https://github.com/sveltejs/svelte/pull/18692)) - fix: never apply class hash to elements inside `<svelte:head>` ([#18160](https://github.com/sveltejs/svelte/pull/18160)) - fix: keep `defaultChecked` on hydrated radio inputs with spread attributes ([#18701](https://github.com/sveltejs/svelte/pull/18701)) - fix: accept `onfocusin`/`onfocusout` in `a11y_mouse_events_have_key_events` ([#18689](https://github.com/sveltejs/svelte/pull/18689)) - perf: O(n²)→O(n) Map lookups for legacy `$:` reactive statement ordering ([#18602](https://github.com/sveltejs/svelte/pull/18602)) - fix: distinct memoizer on style/class directives ([#18466](https://github.com/sveltejs/svelte/pull/18466)) - fix: measure nested transitions before applying their starting styles ([#18647](https://github.com/sveltejs/svelte/pull/18647)) - fix: don't turn component instances stored in `$state` into state proxies ([#18646](https://github.com/sveltejs/svelte/pull/18646)) - perf: emit `$.only_child` for elements with a single child ([#18717](https://github.com/sveltejs/svelte/pull/18717)) - fix: omit `bind:focused` from SSR output (it has no HTML attribute) ([#18724](https://github.com/sveltejs/svelte/pull/18724)) - fix: more robust rendering of Svelte custom element slots ([#18710](https://github.com/sveltejs/svelte/pull/18710)) - perf: optimize simple object destructuring in `@const` tags ([#18390](https://github.com/sveltejs/svelte/pull/18390)) - fix: properly apply static textarea value attribute during CSR ([#18727](https://github.com/sveltejs/svelte/pull/18727)) - fix: end a restored reaction context at the end of its synchronous segment ([#18694](https://github.com/sveltejs/svelte/pull/18694)) - fix: keep the dependencies of a reaction that throws, so deriveds it read are neither leaked nor stuck in their error ([#18703](https://github.com/sveltejs/svelte/pull/18703)) - fix: don't resurrect outroing elements when an ancestor block is paused and resumed ([#18431](https://github.com/sveltejs/svelte/pull/18431)) - perf: use `$.comment()` for single-comment templates ([#18714](https://github.com/sveltejs/svelte/pull/18714)) - chore: move `@types/trusted-types` to devDependencies ([#18730](https://github.com/sveltejs/svelte/pull/18730)) - perf: store setters cache as `Set` instead of `Array` ([#18251](https://github.com/sveltejs/svelte/pull/18251)) - fix: transform derived assignments and select function bindings correctly during server-side rendering ([#18669](https://github.com/sveltejs/svelte/pull/18669)) - fix: keep boolean attributes with an empty string value when rendering attribute objects on the server ([#18721](https://github.com/sveltejs/svelte/pull/18721)) - fix: sync `SvelteURL` port signal when the protocol setter clears the port ([#18705](https://github.com/sveltejs/svelte/pull/18705)) - fix: block declaration tags and `{@const}` on async values read inside closures ([#18533](https://github.com/sveltejs/svelte/pull/18533)) - fix: avoid css tree-shaking for exported Snippet ([#18540](https://github.com/sveltejs/svelte/pull/18540)) - perf: treat `<img loading>` as a static element again ([#18711](https://github.com/sveltejs/svelte/pull/18711)) - fix: prevent `selectedcontent` mutation from changing the selected option ([#18495](https://github.com/sveltejs/svelte/pull/18495)) - fix: avoid `NaN` keyframe values in `slide` transition for elements without a layout box ([#18430](https://github.com/sveltejs/svelte/pull/18430)) - fix: preserve line feed character references in attribute values ([#18691](https://github.com/sveltejs/svelte/pull/18691)) - fix: decode uppercase-`X` hex numeric character references (`&#X...;`) ([#18708](https://github.com/sveltejs/svelte/pull/18708)) - chore: clarify when `$effect.pre` runs relative to DOM updates ([#18534](https://github.com/sveltejs/svelte/pull/18534)) - fix: scope SSR boundary failed snippets to their boundary ([#18593](https://github.com/sveltejs/svelte/pull/18593)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	3 weeks ago
Nic Polumeyv	6374a2a0db	chore: move `@types/trusted-types` to devDependencies (#18730 ) Only referenced by a JSDoc `@import` in `src/internal/client/dom/blocks/html.js`; nothing in the published `types/index.d.ts` uses it, so consumers do not need it installed.	3 weeks ago
Adnane Taghi	4ae5eb3f23	feat: add has function to createContext (#18472 ) closes #18471. --------- Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>	3 weeks ago
Simon H	5034b59e9e	chore: bump playwright (#18729 ) supports later ubuntu versions	3 weeks ago
Simon H	74197ccbe1	feat: add getOrInsert/getOrInsertComputed to SvelteMap (#18728 ) Closes #18014	4 weeks ago
Simon H	edbe11ebc9	fix: properly apply static textarea value attribute during CSR (#18727 ) Fixes #18574 Simpler alternative to #18627 - we just special-case this in the "should this be treated as a dynamic attribute" branches so `$.set_value(...)` is always generated. Given how edge-case-y this is (why would you not just write it into the body of the textarea?) this is fine.	4 weeks ago
Xia Chao	05b69164d1	fix: omit bind:focused from SSR output (#18724 ) --------- Co-authored-by: Xia Chao <236466140+bun-unsafe@users.noreply.github.com> Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>	4 weeks ago
Simon H	08c2a72907	chore: set Vitest reporter for github actions (#18722 ) test failures show up really bad now, minimal is way better for github actions	4 weeks ago

1 2 3 4 5 ...

11421 Commits (async-another-try) All Branches Search

11421 Commits (async-another-try)

All Branches