mirror of https://github.com/sveltejs/svelte
fix: resume inert effects when they come from offscreen (#17942)
The offscreen branch was missing the "resume inert effects" logic that was just below; it never reached that because of the early continue. Fixes #17851pull/17936/head
parent
1cd06451af
commit
f081a6c3b1
@ -0,0 +1,5 @@
|
|||||||
|
---
|
||||||
|
'svelte': patch
|
||||||
|
---
|
||||||
|
|
||||||
|
fix: resume inert effects when they come from offscreen
|
||||||
@ -0,0 +1,32 @@
|
|||||||
|
import { tick } from 'svelte';
|
||||||
|
import { test } from '../../test';
|
||||||
|
|
||||||
|
export default test({
|
||||||
|
async test({ assert, target }) {
|
||||||
|
const spam = /** @type {HTMLButtonElement} */ (target.querySelector('button.spam'));
|
||||||
|
const resolve = /** @type {HTMLButtonElement} */ (target.querySelector('button.resolve'));
|
||||||
|
|
||||||
|
resolve.click();
|
||||||
|
await tick();
|
||||||
|
|
||||||
|
for (let i = 0; i < 5; i += 1) {
|
||||||
|
spam.click();
|
||||||
|
await tick();
|
||||||
|
}
|
||||||
|
|
||||||
|
for (let i = 0; i < 5; i += 1) {
|
||||||
|
resolve.click();
|
||||||
|
await tick();
|
||||||
|
}
|
||||||
|
|
||||||
|
assert.equal(target.querySelectorAll('div').length, 1);
|
||||||
|
assert.htmlEqual(
|
||||||
|
target.innerHTML,
|
||||||
|
`
|
||||||
|
<button class="spam">Spam</button>
|
||||||
|
<button class="resolve">Resolve</button>
|
||||||
|
<div>5</div>
|
||||||
|
`
|
||||||
|
);
|
||||||
|
}
|
||||||
|
});
|
||||||
@ -0,0 +1,28 @@
|
|||||||
|
<script>
|
||||||
|
let value = $state({ id: '0' });
|
||||||
|
const resolvers = [];
|
||||||
|
|
||||||
|
function wait() {
|
||||||
|
const promise = Promise.withResolvers();
|
||||||
|
resolvers.push(promise.resolve);
|
||||||
|
return promise.promise;
|
||||||
|
}
|
||||||
|
|
||||||
|
function spam() {
|
||||||
|
value.id = `${Number(value.id) + 1}`;
|
||||||
|
}
|
||||||
|
</script>
|
||||||
|
|
||||||
|
<button class="spam" onclick={spam}>Spam</button>
|
||||||
|
<button class="resolve" onclick={() => resolvers.shift()?.()}>Resolve</button>
|
||||||
|
|
||||||
|
<svelte:boundary>
|
||||||
|
{#each [value.id] as s (s)}
|
||||||
|
{await wait()}
|
||||||
|
<div>{s}</div>
|
||||||
|
{/each}
|
||||||
|
|
||||||
|
{#snippet pending()}
|
||||||
|
<p>pending</p>
|
||||||
|
{/snippet}
|
||||||
|
</svelte:boundary>
|
||||||
Loading…
Reference in new issue