Merge pull request #1402 from sveltejs/gh-1397

evaluate each block key in child scope

src/compile/nodes/EachBlock.ts

@@ -31,10 +31,6 @@ export default class EachBlock extends Node {
 		this.context = info.context.name || 'each'; // TODO this is used to facilitate binding; currently fails with destructuring
 		this.index = info.index;
 
-		this.key = info.key
-			? new Expression(compiler, this, scope, info.key)
-			: null;
-
 		this.scope = scope.child();
 
 		this.contexts = [];
@@ -44,6 +40,10 @@ export default class EachBlock extends Node {
 			this.scope.add(context.key.name, this.expression.dependencies);
 		});
 
+		this.key = info.key
+			? new Expression(compiler, this, this.scope, info.key)
+			: null;
+
 		if (this.index) {
 			// index can only change if this is a keyed each block
 			const dependencies = this.key ? this.expression.dependencies : [];

test/runtime/samples/dev-warning-missing-data-each/_config.js

@@ -0,0 +1,22 @@
+export default {
+	dev: true,
+
+	data: {
+		letters: [
+			{
+				id: 1,
+				char: 'a',
+			},
+			{
+				id: 2,
+				char: 'b',
+			},
+			{
+				id: 3,
+				char: 'c',
+			},
+		],
+	},
+
+	warnings: [],
+};

test/runtime/samples/dev-warning-missing-data-each/main.html

@@ -0,0 +1,3 @@
+{#each letters as letter (letter.id)}
+  <div>{letter.char}</div>
+{/each}