fix: improve each block index handling (#9644)

* fix: improve each block index handling

* format

.changeset/thirty-wombats-relax.md

@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: improve each block index handling

packages/svelte/src/compiler/phases/3-transform/client/visitors/template.js

@@ -2491,7 +2491,7 @@ export const template_visitors = {
 		next();
 	},
 	BindDirective(node, context) {
-		const { state, path } = context;
+		const { state, path, visit } = context;
 
 		/** @type {import('estree').Expression[]} */
 		const properties = [];
@@ -2621,10 +2621,18 @@ export const template_visitors = {
 					break;
 				}
 
-				case 'this':
+				case 'this': {
-					call_expr = b.call(`$.bind_this`, state.node, setter, node.expression);
+					const expression = node.expression;
+					call_expr = b.call(
+						`$.bind_this`,
+						state.node,
+						setter,
+						expression.type === 'Identifier'
+							? expression
+							: /** @type {import('estree').Expression} */ (visit(expression))
+					);
 					break;
-
+				}
 				case 'textContent':
 				case 'innerHTML':
 				case 'innerText':

packages/svelte/src/compiler/phases/scope.js

@@ -495,12 +495,10 @@ export function create_scopes(ast, root, allow_reactive_declarations, parent) {
 			}
 
 			if (node.index) {
-				scope.declare(
+				const is_keyed =
-					b.id(node.index),
+					node.key &&
-					// TODO see logic in EachBlock in dom.ts
+					(node.key.type !== 'Identifier' || !node.index || node.key.name !== node.index);
-					node.key ? 'derived' : 'normal',
+				scope.declare(b.id(node.index), is_keyed ? 'derived' : 'normal', 'const');
-					'const'
-				);
 			}
 			if (node.key) visit(node.key, { scope });
 

packages/svelte/tests/runtime-legacy/samples/keyed-each-index-same-2/_config.js

@@ -0,0 +1,5 @@
+import { test } from '../../test';
+
+export default test({
+	html: '<div>0</div><div>1</div>'
+});

packages/svelte/tests/runtime-legacy/samples/keyed-each-index-same-2/main.svelte

@@ -0,0 +1,3 @@
+{#each ["a", "b"] as result, i (i)}
+  <div>{i}</div>
+{/each}