Fix: Regression on contenteditable

Fixes: https://github.com/sveltejs/svelte/issues/5018
Fixes: https://github.com/sveltejs/svelte/issues/5931

Issue caused because of setting the updated value to
the data property of moustache text node, use innerText if
parent have contenteditable attribute
pull/6853/head
raivaibhav 5 years ago
parent 883c47b45d
commit d4965fe4db

@ -83,11 +83,15 @@ export function dataset_dev(node: HTMLElement, property: string, value?: any) {
export function set_data_dev(text, data) { export function set_data_dev(text, data) {
data = '' + data; data = '' + data;
if (text.wholeText === data) return; if (text.data === data) return;
dispatch_dev('SvelteDOMSetData', { node: text, data }); console.log(text.parentNode.hasAttribute('contenteditable'));
if (text.parentNode && text.parentNode.hasAttribute('contenteditable')) {
text.innerText = data;
} else {
text.data = data; text.data = data;
} }
}
export function validate_each_argument(arg) { export function validate_each_argument(arg) {
if (typeof arg !== 'string' && !(arg && typeof arg === 'object' && 'length' in arg)) { if (typeof arg !== 'string' && !(arg && typeof arg === 'object' && 'length' in arg)) {

@ -514,7 +514,13 @@ export function claim_html_tag(nodes) {
export function set_data(text, data) { export function set_data(text, data) {
data = '' + data; data = '' + data;
if (text.wholeText !== data) text.data = data; if (text.data === data) return;
if (text.parentNode && text.parentNode.hasAttribute('contenteditable')) {
text.innerText = data;
} else {
text.data = data;
}
} }
export function set_input_value(input, value) { export function set_input_value(input, value) {

Loading…
Cancel
Save