single underscore for component private properties

pull/212/head
Rich-Harris 8 years ago
parent 7dd129a357
commit c1e82f69e3

@ -235,18 +235,18 @@ export default function dom ( parsed, source, options, names ) {
} }
if ( generator.hasComponents ) { if ( generator.hasComponents ) {
builders.init.addLine( `this.__renderHooks = [];` ); builders.init.addLine( `this._renderHooks = [];` );
} }
if ( generator.hasComplexBindings ) { if ( generator.hasComplexBindings ) {
builders.init.addBlock( deindent` builders.init.addBlock( deindent`
this.__bindings = []; this._bindings = [];
this._fragment = renderMainFragment( this._state, this ); this._fragment = renderMainFragment( this._state, this );
if ( options.target ) this._fragment.mount( options.target, null ); if ( options.target ) this._fragment.mount( options.target, null );
while ( this.__bindings.length ) this.__bindings.pop()(); while ( this._bindings.length ) this._bindings.pop()();
` ); ` );
builders.set.addLine( `while ( this.__bindings.length ) this.__bindings.pop()();` ); builders.set.addLine( `while ( this._bindings.length ) this._bindings.pop()();` );
} else { } else {
builders.init.addBlock( deindent` builders.init.addBlock( deindent`
this._fragment = renderMainFragment( this._state, this ); this._fragment = renderMainFragment( this._state, this );
@ -256,8 +256,8 @@ export default function dom ( parsed, source, options, names ) {
if ( generator.hasComponents ) { if ( generator.hasComponents ) {
const statement = deindent` const statement = deindent`
while ( this.__renderHooks.length ) { while ( this._renderHooks.length ) {
var hook = this.__renderHooks.pop(); var hook = this._renderHooks.pop();
hook.fn.call( hook.context ); hook.fn.call( hook.context );
} }
`; `;
@ -269,7 +269,7 @@ export default function dom ( parsed, source, options, names ) {
if ( templateProperties.onrender ) { if ( templateProperties.onrender ) {
builders.init.addBlock( deindent` builders.init.addBlock( deindent`
if ( options._root ) { if ( options._root ) {
options._root.__renderHooks.push({ fn: template.onrender, context: this }); options._root._renderHooks.push({ fn: template.onrender, context: this });
} else { } else {
template.onrender.call( this ); template.onrender.call( this );
} }

@ -87,7 +87,7 @@ export default function createBinding ( generator, node, attribute, current, loc
local.init.addBlock( deindent` local.init.addBlock( deindent`
var ${local.name}_updating = false; var ${local.name}_updating = false;
component.__bindings.push( function () { component._bindings.push( function () {
${local.name}.observe( '${attribute.name}', function ( value ) { ${local.name}.observe( '${attribute.name}', function ( value ) {
${local.name}_updating = true; ${local.name}_updating = true;
${setter} ${setter}
@ -128,6 +128,6 @@ export default function createBinding ( generator, node, attribute, current, loc
if ( node.name === 'select' ) { if ( node.name === 'select' ) {
generator.hasComplexBindings = true; generator.hasComplexBindings = true;
local.init.addLine( `component.__bindings.push( ${handler} )` ); local.init.addLine( `component._bindings.push( ${handler} )` );
} }
} }

Loading…
Cancel
Save