msb-public
/
svelte
mirror of https://github.com/sveltejs/svelte
1
0
Code Issues Projects Releases Wiki Activity

fix: improve error message for migration errors when slot would be renamed (#15841)

Browse Source 
Co-authored-by: Paolo Ricciuti <ricciutipaolo@gmail.com>
pull/15861/head
Lars Francke 4 months ago committed by GitHub
parent 1c2fc21023
commit c051a6eb1e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
5 changed files with 13 additions and 8 deletions
Show Stats Download Patch File Download Diff File

5
.changeset/strong-coins-peel.md
Unescape View File

@ -0,0 +1,5 @@
---
'svelte': patch
---
fix: improve error message for migration errors when slot would be renamed

4
packages/svelte/src/compiler/migrate/index.js
Unescape View File

@ -1307,7 +1307,7 @@ const template = {
name = state.scope.generate(slot_name); name = state.scope.generate(slot_name);
if (name !== slot_name) { if (name !== slot_name) {
throw new MigrationError( throw new MigrationError(
'This migration would change the name of a slot making the component unusable' `This migration would change the name of a slot (${slot_name} to ${name}) making the component unusable`
); );
} }
} }
@ -1880,7 +1880,7 @@ function handle_identifier(node, state, path) {
let new_name = state.scope.generate(name); let new_name = state.scope.generate(name);
if (new_name !== name) { if (new_name !== name) {
throw new MigrationError( throw new MigrationError(
'This migration would change the name of a slot making the component unusable' `This migration would change the name of a slot (${name} to ${new_name}) making the component unusable`
); );
} }
} }

4
packages/svelte/tests/migrate/samples/impossible-migrate-$derived-derived-var-3/output.svelte
Unescape View File

@ -1,7 +1,7 @@
<!-- @migration-task Error while migrating Svelte code: This migration would change the name of a slot making the component unusable --> <!-- @migration-task Error while migrating Svelte code: This migration would change the name of a slot (derived to derived_1) making the component unusable -->
<script> <script>
let derived; let derived;
</script> </script>
<Component> <Component>
<slot name="derived" slot="derived" /> <slot name="derived" slot="derived" />
</Component> </Component>

4
packages/svelte/tests/migrate/samples/impossible-migrate-slot-change-name/output.svelte
Unescape View File

@ -1,6 +1,6 @@
<!-- @migration-task Error while migrating Svelte code: This migration would change the name of a slot making the component unusable --> <!-- @migration-task Error while migrating Svelte code: This migration would change the name of a slot (body to body_1) making the component unusable -->
<script> <script>
let body; let body;
</script> </script>
<slot name="body"></slot> <slot name="body"></slot>

4
packages/svelte/tests/migrate/samples/impossible-migrate-slot-non-identifier/output.svelte
Unescape View File

@ -1,2 +1,2 @@
<!-- @migration-task Error while migrating Svelte code: This migration would change the name of a slot making the component unusable --> <!-- @migration-task Error while migrating Svelte code: This migration would change the name of a slot (dashed-name to dashed_name) making the component unusable -->
<slot name="dashed-name"></slot> <slot name="dashed-name"></slot>

Write Preview
Loading…
Cancel
Save