Merge 8171c1935c into ae25641f8b

src/generators/dom/index.ts

@@ -166,7 +166,7 @@ export default function dom(
 		? `@proto`
 		: deindent`
 		{
-			${['destroy', 'get', 'fire', 'observe', 'on', 'set', 'teardown', '_set', '_mount', '_unmount', '_differs']
+			${['destroy', 'get', 'fire', 'observe', 'on', 'set', 'teardown', '_set', '_mount', '_unmount', '_differs', '_flush']
 				.map(n => `${n}: @${n === 'teardown' ? 'destroy' : n}`)
 				.join(',\n')}
 		}`;
@@ -278,11 +278,7 @@ export default function dom(
 				this._mount(options.target, options.anchor);
 
 				${(generator.hasComponents || generator.hasComplexBindings || templateProperties.oncreate || generator.hasIntroTransitions) && deindent`
-					${generator.hasComponents && `this._lock = true;`}
+					this._flush();
-					${(generator.hasComponents || generator.hasComplexBindings) && `@callAll(this._beforecreate);`}
-					${(generator.hasComponents || templateProperties.oncreate) && `@callAll(this._oncreate);`}
-					${(generator.hasComponents || generator.hasIntroTransitions) && `@callAll(this._aftercreate);`}
-					${generator.hasComponents && `this._lock = false;`}
 				`}
 			}
 		`}

src/generators/nodes/Component.ts

@@ -210,7 +210,7 @@ export default class Component extends Node {
 					);
 
 					builder.addConditional(
-						`!${name_updating}.${binding.name} && changed.${binding.name}`,
+						`changed.${binding.name}`,
 						setFromChild
 					);
 

src/shared/index.js

@@ -146,6 +146,10 @@ export function run(fn) {
 export function set(newState) {
 	this._set(assign({}, newState));
 	if (this.root._lock) return;
+	this.root._flush();
+}
+
+export function _flush() {
 	this.root._lock = true;
 	callAll(this.root._beforecreate);
 	callAll(this.root._oncreate);
@@ -221,7 +225,8 @@ export var proto = {
 	_set: _set,
 	_mount: _mount,
 	_unmount: _unmount,
-	_differs: _differs
+	_differs: _differs,
+	_flush: _flush
 };
 
 export var protoDev = {
@@ -236,5 +241,6 @@ export var protoDev = {
 	_set: _set,
 	_mount: _mount,
 	_unmount: _unmount,
-	_differs: _differs
+	_differs: _differs,
+	_flush: _flush
 };

test/runtime/samples/dynamic-component-changed-in-oncreate/Nested.html

@@ -0,0 +1,7 @@
+<script>
+	export default {
+		oncreate() {
+			this.set({text: 'correct'});
+		}
+	};
+</script>

test/runtime/samples/dynamic-component-changed-in-oncreate/_config.js

@@ -0,0 +1,7 @@
+export default {
+	'skip-ssr': true,
+
+	html: `
+		<p>Text: correct</p>
+	`
+};

test/runtime/samples/dynamic-component-changed-in-oncreate/main.html

@@ -0,0 +1,20 @@
+<:Component {Child} bind:text=text />
+<p>Text: {{text}}</p>
+
+
+<script>
+	import Nested from './Nested.html';
+
+	export default {
+		data: () => ({
+			text: 'incorrect',
+			Child: null,
+		}),
+
+		oncreate() {
+			this.set({
+				Child: Nested
+			});
+		},
+	};
+</script>