simplify render_effect signature (#10925)

* simplify render_effect signature

* lint
pull/10927/head
Rich Harris 6 months ago committed by GitHub
parent 59ff650ccb
commit b7a0d80bfc
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

@ -36,19 +36,15 @@ export function key_block(anchor, get_key, render_fn) {
});
}
effect = render_effect(
() => {
const dom = render_fn(anchor);
return () => {
if (dom !== undefined) {
remove(dom);
}
};
},
true,
true
);
effect = render_effect(() => {
const dom = render_fn(anchor);
return () => {
if (dom !== undefined) {
remove(dom);
}
};
}, true);
effects.add(effect);
}

@ -1,5 +1,5 @@
import { hydrating } from '../hydration.js';
import { render_effect } from '../../reactivity/effects.js';
import { user_effect } from '../../reactivity/effects.js';
/**
* @param {HTMLElement} dom
@ -10,15 +10,12 @@ export function autofocus(dom, value) {
if (value) {
const body = document.body;
dom.autofocus = true;
render_effect(
() => {
if (document.activeElement === body) {
dom.focus();
}
},
true,
false
);
user_effect(() => {
if (document.activeElement === body) {
dom.focus();
}
});
}
}

@ -216,14 +216,13 @@ export function invalidate_effect(fn) {
/**
* @param {(() => void)} fn
* @param {boolean} managed
* @param {boolean} sync
* @returns {import('#client').Effect}
*/
export function render_effect(fn, managed = false, sync = true) {
export function render_effect(fn, managed = false) {
let flags = RENDER_EFFECT;
if (managed) flags |= MANAGED;
return create_effect(flags, /** @type {any} */ (fn), sync);
return create_effect(flags, /** @type {any} */ (fn), true);
}
/**

@ -22,13 +22,9 @@ function run_test(runes: boolean, fn: (runes: boolean) => () => void) {
$.push({}, runes);
// Create a render context so that effect validations etc don't fail
let execute: any;
const signal = render_effect(
() => {
execute = fn(runes);
},
true,
true
);
const signal = render_effect(() => {
execute = fn(runes);
}, true);
$.pop();
execute();
destroy_effect(signal);

Loading…
Cancel
Save