Merge pull request #647 from sveltejs/gh-643

#643 redux

src/generators/dom/visitors/IfBlock.ts

@@ -271,11 +271,12 @@ function compound(
 		`);
 	}
 
+	block.builders.unmount.addLine(
+		`${if_name}${name}.unmount();`
+	);
+
 	block.builders.destroy.addLine(
-		`${if_name}{
-			${name}.unmount();
-			${name}.destroy();
-		}`
+		`${if_name}${name}.destroy();`
 	);
 }
 

test/js/samples/if-block-no-update/expected-bundle.js

@@ -164,15 +164,13 @@ function create_main_fragment ( state, component ) {
 		},
 
 		unmount: function () {
+			if_block.unmount();
 			detachNode( if_block_anchor );
 		},
 
 		destroy: function () {
-			{
-						if_block.unmount();
 			if_block.destroy();
 		}
-		}
 	};
 }
 

test/js/samples/if-block-no-update/expected.js

@@ -29,15 +29,13 @@ function create_main_fragment ( state, component ) {
 		},
 
 		unmount: function () {
+			if_block.unmount();
 			detachNode( if_block_anchor );
 		},
 
 		destroy: function () {
-			{
-						if_block.unmount();
 			if_block.destroy();
 		}
-		}
 	};
 }
 

test/runtime/samples/component-nested-deeper/Level1.html

@@ -0,0 +1,22 @@
+<div class="level1">
+	{{#each values as value}}
+		<h4>level 1 #{{value}}</h4>
+		<Level2 condition="{{value % 2}}">
+			<Level3>
+				<span>And more stuff goes in here</span>
+			</Level3>
+		</Level2>
+	{{/each}}
+</div>
+
+<script>
+	import Level2 from './Level2.html';
+	import Level3 from './Level3.html';
+	
+	export default {
+		components: {
+			Level2,
+			Level3
+		}
+	};
+</script>

test/runtime/samples/component-nested-deeper/Level2.html

@@ -0,0 +1,8 @@
+<div class="level2" ref:wat>
+	<h4>level 2</h4>
+	{{#if condition}}
+		<span>TRUE! {{yield}}</span>
+	{{else}}
+		<span>FALSE! {{yield}}</span>
+	{{/if}}
+</div>

test/runtime/samples/component-nested-deeper/Level3.html

@@ -0,0 +1,4 @@
+<div class="level3" ref:thingy>
+	<h4>level 3</h4>
+	{{yield}}
+</div>

test/runtime/samples/component-nested-deeper/_config.js

@@ -0,0 +1,9 @@
+export default {
+	data: {
+		values: [1, 2, 3, 4]
+	},
+
+	test(assert, component) {
+		component.set({ values: [2, 3] });
+	}
+};

test/runtime/samples/component-nested-deeper/main.html

@@ -0,0 +1,11 @@
+<Level1 :values/>
+
+<script>
+	import Level1 from './Level1.html';
+	
+	export default {
+		components: {
+			Level1
+		}
+	}
+</script>