WIP: resize listener destruct ordering

- Destroy the resize listener <iframe> before the parent element.
- Unsubscribe from the event listener before detaching the <iframe>
pull/4753/head
Pat Cavit 5 years ago
parent b3364424d7
commit acf9c1291c

@ -585,7 +585,7 @@ export default class ElementWrapper extends Wrapper {
b`${resize_listener} = @add_resize_listener(${this.var}, ${callee}.bind(${this.var}));` b`${resize_listener} = @add_resize_listener(${this.var}, ${callee}.bind(${this.var}));`
); );
block.chunks.destroy.push( block.chunks.destroy.unshift(
b`${resize_listener}();` b`${resize_listener}();`
); );
} else { } else {

@ -287,8 +287,8 @@ export function add_resize_listener(node: HTMLElement, fn: () => void) {
append(node, iframe); append(node, iframe);
return () => { return () => {
detach(iframe);
if (unsubscribe) unsubscribe(); if (unsubscribe) unsubscribe();
detach(iframe);
}; };
} }

Loading…
Cancel
Save