Merge pull request #1186 from sveltejs/gh-1181

allow observing $foo in dev mode

src/shared/index.js

@@ -100,7 +100,7 @@ export function observe(key, callback, options) {
 }
 
 export function observeDev(key, callback, options) {
-	var c = (key = '' + key).search(/[^\w]/);
+	var c = (key = '' + key).search(/[.[]/);
 	if (c > -1) {
 		var message =
 			'The first argument to component.observe(...) must be the name of a top-level property';

test/js/samples/legacy-default/expected-bundle.js

@@ -204,7 +204,7 @@ var proto = {
 };
 
 /* generated by Svelte vX.Y.Z */
-function create_main_fragment(state, component) {
+function create_main_fragment(component, state) {
 	var text, p, text_1, text_2, text_3, slot_content_default = component._slotted["default"], slot_content_default_before, slot_content_default_after;
 
 	var foo = new Foo({
@@ -270,7 +270,7 @@ function SvelteComponent(options) {
 
 	this.slots = {};
 
-	this._fragment = create_main_fragment(this._state, this);
+	this._fragment = create_main_fragment(this, this._state);
 
 	if (options.target) {
 		this._fragment.c();

test/js/samples/legacy-default/expected.js

@@ -1,7 +1,7 @@
 /* generated by Svelte vX.Y.Z */
 import { appendNode, assign, callAll, createComment, createElement, createFragment, createText, detachNode, init, insertNode, noop, proto, reinsertBetween } from "svelte/shared.js";
 
-function create_main_fragment(state, component) {
+function create_main_fragment(component, state) {
 	var text, p, text_1, text_2, text_3, slot_content_default = component._slotted["default"], slot_content_default_before, slot_content_default_after;
 
 	var foo = new Foo({
@@ -67,7 +67,7 @@ function SvelteComponent(options) {
 
 	this.slots = {};
 
-	this._fragment = create_main_fragment(this._state, this);
+	this._fragment = create_main_fragment(this, this._state);
 
 	if (options.target) {
 		this._fragment.c();

test/runtime/samples/store-observe-dollar/_config.js

@@ -0,0 +1,25 @@
+import { Store } from '../../../../store.js';
+
+const store = new Store({
+	name: 'world'
+});
+
+export default {
+	store,
+
+	html: `<h1>Hello world!</h1>`,
+
+	dev: true,
+
+	test(assert, component) {
+		const names = [];
+
+		component.observe('$name', name => {
+			names.push(name);
+		});
+
+		store.set({ name: 'everybody' });
+
+		assert.deepEqual(names, ['world', 'everybody']);
+	}
+};

test/runtime/samples/store-observe-dollar/main.html

@@ -0,0 +1 @@
+<h1>Hello {{$name}}!</h1>