docs/tests: use event.key instead of event.which (#4758)

pull/4761/head
Daniel Imfeld 5 years ago committed by GitHub
parent b3364424d7
commit a658fedb83
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -20,7 +20,7 @@
]; ];
function handleKeydown(event) { function handleKeydown(event) {
if (event.which === 13) { if (event.key === 'Enter') {
const text = event.target.value; const text = event.target.value;
if (!text) return; if (!text) return;

@ -4,7 +4,7 @@
let text = `Select some text and hit the tab key to toggle uppercase`; let text = `Select some text and hit the tab key to toggle uppercase`;
async function handleKeydown(event) { async function handleKeydown(event) {
if (event.which !== 9) return; if (event.key !== 'Tab') return;
event.preventDefault(); event.preventDefault();

@ -112,7 +112,7 @@
<input <input
class="new-todo" class="new-todo"
placeholder="what needs to be done?" placeholder="what needs to be done?"
on:keydown="{event => event.which === 13 && add(event.target)}" on:keydown="{event => event.key === 'Enter' && add(event.target)}"
> >
<div class='left'> <div class='left'>

@ -20,7 +20,7 @@
]; ];
function handleKeydown(event) { function handleKeydown(event) {
if (event.which === 13) { if (event.key === 'Enter') {
const text = event.target.value; const text = event.target.value;
if (!text) return; if (!text) return;

@ -20,7 +20,7 @@
]; ];
function handleKeydown(event) { function handleKeydown(event) {
if (event.which === 13) { if (event.key === 'Enter') {
const text = event.target.value; const text = event.target.value;
if (!text) return; if (!text) return;

@ -2,7 +2,7 @@
let text = `Select some text and hit the tab key to toggle uppercase`; let text = `Select some text and hit the tab key to toggle uppercase`;
async function handleKeydown(event) { async function handleKeydown(event) {
if (event.which !== 9) return; if (event.key !== 'Tab') return;
event.preventDefault(); event.preventDefault();

@ -4,7 +4,7 @@
let text = `Select some text and hit the tab key to toggle uppercase`; let text = `Select some text and hit the tab key to toggle uppercase`;
async function handleKeydown(event) { async function handleKeydown(event) {
if (event.which !== 9) return; if (event.key !== 'Tab') return;
event.preventDefault(); event.preventDefault();

@ -56,7 +56,7 @@
<div class='board'> <div class='board'>
<input <input
placeholder="what needs to be done?" placeholder="what needs to be done?"
on:keydown={e => e.which === 13 && add(e.target)} on:keydown={e => e.key === 'Enter' && add(e.target)}
> >
<div class='left'> <div class='left'>

@ -56,7 +56,7 @@
<div class='board'> <div class='board'>
<input <input
placeholder="what needs to be done?" placeholder="what needs to be done?"
on:keydown={e => e.which === 13 && add(e.target)} on:keydown={e => e.key === 'Enter' && add(e.target)}
> >
<div class='left'> <div class='left'>

@ -56,7 +56,7 @@
<div class='board'> <div class='board'>
<input <input
placeholder="what needs to be done?" placeholder="what needs to be done?"
on:keydown={e => e.which === 13 && add(e.target)} on:keydown={e => e.key === 'Enter' && add(e.target)}
> >
<div class='left'> <div class='left'>

@ -57,7 +57,7 @@
<div class='board'> <div class='board'>
<input <input
placeholder="what needs to be done?" placeholder="what needs to be done?"
on:keydown={e => e.which === 13 && add(e.target)} on:keydown={e => e.key === 'Enter' && add(e.target)}
> >
<div class='left'> <div class='left'>

@ -30,7 +30,7 @@
$: canSave = $session.user && gist && gist.owner === $session.user.uid; $: canSave = $session.user && gist && gist.owner === $session.user.uid;
function handleKeydown(event) { function handleKeydown(event) {
if (event.which === 83 && (isMac ? event.metaKey : event.ctrlKey)) { if (event.key === 's' && (isMac ? event.metaKey : event.ctrlKey)) {
event.preventDefault(); event.preventDefault();
save(); save();
} }

@ -4,7 +4,7 @@ export default {
test({ assert, component, target, window }) { test({ assert, component, target, window }) {
const input = target.querySelector('input'); const input = target.querySelector('input');
const event = new window.KeyboardEvent('keydown', { const event = new window.KeyboardEvent('keydown', {
which: 13 key: 'Enter'
}); });
let blurred = false; let blurred = false;

@ -1,7 +1,7 @@
<script> <script>
function enter(node, callback) { function enter(node, callback) {
function handleKeydown(event) { function handleKeydown(event) {
if (event.which === 13) { if (event.key === 'Enter') {
callback(event); callback(event);
} }
} }

@ -3,7 +3,7 @@ export default {
async test({ assert, component, target, window }) { async test({ assert, component, target, window }) {
const event = new window.KeyboardEvent('keydown', { const event = new window.KeyboardEvent('keydown', {
which: 27 key: 'Escape'
}); });
await window.dispatchEvent(event); await window.dispatchEvent(event);

@ -3,7 +3,7 @@
function esc(node, callback) { function esc(node, callback) {
function onKeyDown(event) { function onKeyDown(event) {
if (event.which === 27) callback(event); if (event.key === 'Escape') callback(event);
} }
node.addEventListener('keydown', onKeyDown); node.addEventListener('keydown', onKeyDown);
return { return {

Loading…
Cancel
Save