simplify updateKeyedEach

src/shared/keyed-each.js

@@ -1,92 +1,78 @@
 import { assign } from './utils.js';
 
-export function updateKeyedEach(component, key, changed, block_key, dynamic, each_block_value, head, lookup, updateMountNode, hasOutroMethod, create_each_block, get_context) {
+export function destroyIteration(iteration, lookup) {
-	var last = null;
+	var first = iteration.first
-	var expected = head;
+	if (first && first.parentNode) {
+		iteration.u();
+	}
+	iteration.d();
+	lookup[iteration.key] = null;
+}
+
+export function outroAndDestroyIteration(iteration, lookup) {
+	iteration.o(function() {
+		iteration.u();
+		iteration.d();
+		lookup[iteration.key] = null;
+	});
+}
 
+export function updateKeyedEach(component, key, changed, key_prop, dynamic, list, head, lookup, updateMountNode, hasOutroMethod, create_each_block, get_context) {
 	var keep = {};
-	var mounts = {};
-	var next_iteration = null;
 
-	for (i = 0; i < each_block_value.length; i += 1) {
+	var i = list.length;
-		var key = each_block_value[i][block_key];
+	while (i--) {
+		var key = list[i][key_prop];
 		var iteration = lookup[key];
-		var next_data = each_block_value[i+1];
-		var next = next_data && lookup[next_data[block_key]];
 
-		if (dynamic && iteration) iteration.p(changed, get_context(i)); // TODO should this be deferred? could it be redundant?
+		if (iteration) {
-
+			if (dynamic) iteration.p(changed, get_context(i));
-		if (expected && (key === expected.key)) {
-			var first = iteration && iteration.first;
-			var parentNode = first && first.parentNode
-			if (!parentNode || (iteration && iteration.next) != next) mounts[key] = iteration;
-			expected = iteration.next;
-		} else if (iteration) {
-			mounts[key] = iteration;
-			expected = iteration.next;
 		} else {
-			// key is being inserted
 			iteration = lookup[key] = create_each_block(component, key, get_context(i));
 			iteration.c();
-			mounts[key] = iteration;
 		}
+
 		lookup[key] = iteration;
-		keep[iteration.key] = iteration;
+		keep[key] = 1;
-		last = iteration;
 	}
 
 	var destroy = hasOutroMethod
-		? function(iteration) {
+		? outroAndDestroyIteration
-			iteration.o(function() {
+		: destroyIteration;
-				iteration.u();
-				iteration.d();
-				lookup[iteration.key] = null;
-			});
-		}
-		: function(iteration) {
-			var first = iteration.first
-			if (first && first.parentNode) {
-				iteration.u();
-			}
-			iteration.d();
-			lookup[iteration.key] = null;
-		}
 
 	iteration = head;
 	while (iteration) {
-		if (!keep[iteration.key]) {
+		if (!keep[iteration.key]) destroy(iteration, lookup);
-			destroy(iteration);
-		}
 		iteration = iteration.next;
 	}
 
-	// Work backwards due to DOM api having insertBefore
+	var next = null;
-	for (i = each_block_value.length - 1; i >= 0; i -= 1) {
+
-		var data = each_block_value[i];
+	i = list.length;
-		var key = data[block_key];
+	while (i--) {
+		key = list[i][key_prop];
 		iteration = lookup[key];
 
-		var block = mounts[key];
-		if (block) {
 		var anchor;
 
 		if (hasOutroMethod) {
-				var key_next_iteration = next_iteration && next_iteration.key;
+			var next_key = next && next.key;
-				var iteration_anchor = iteration.next;
+			var neighbour = iteration.next;
-				var key_anchor;
+			var anchor_key;
-				do {
+
-					anchor = iteration_anchor && iteration_anchor.first;
+			while (neighbour && anchor_key != next_key && !keep[anchor_key]) {
-					iteration_anchor = iteration_anchor && iteration_anchor.next;
+				anchor = neighbour && neighbour.first;
-					key_anchor = iteration_anchor && iteration_anchor.key;
+				neighbour = neighbour.next;
-				} while(iteration_anchor && key_anchor != key_next_iteration && !keep[key_anchor])
+				anchor_key = neighbour && neighbour.key;
+			}
 		} else {
-				anchor = next_iteration && next_iteration.first;
+			anchor = next && next.first;
 		}
 
-			block[block.i ? 'i' : 'm'](updateMountNode, anchor);
+		iteration[iteration.i ? 'i' : 'm'](updateMountNode, anchor);
-		}
+
-		iteration.next = next_iteration;
+		iteration.next = next;
-		if (next_iteration) next_iteration.last = iteration;
+		if (next) next.last = iteration;
-		next_iteration = iteration;
+		next = iteration;
 	}
 }

test/runtime/samples/each-block-keyed-random-permute/_config.js

@@ -9,7 +9,9 @@ function permute () {
 	const number = Math.floor(Math.random() * VALUES.length);
 	const permuted = [];
 	for (let i = 0; i < number; i++) {
-		permuted.push( ...values.splice( Math.floor( Math.random() * ( number - i ) ), 1 ) );
+		permuted.push(
+			...values.splice(Math.floor(Math.random() * (number - i)), 1)
+		);
 	}
 
 	return permuted.join('');
@@ -17,15 +19,21 @@ function permute () {
 
 export default {
 	data: {
-		values: toObjects( 'abc' )
+		values: toObjects('abc'),
 	},
 
 	html: `(a)(b)(c)`,
 
 	test(assert, component, target) {
 		function test(sequence) {
+			const previous = target.textContent;
+			const expected = sequence.split('').map(x => `(${x})`).join('');
 			component.set({ values: toObjects(sequence) });
-			assert.htmlEqual( target.innerHTML, sequence.split( '' ).map( x => `(${x})` ).join( '' ) );
+			assert.htmlEqual(
+				target.innerHTML,
+				expected,
+				`\n${previous} -> ${expected}\n${target.textContent}`
+			);
 		}
 
 		// first, some fixed tests so that we can debug them
@@ -43,6 +51,8 @@ export default {
 		test('abc');
 		test('duqbmineapjhtlofrskcg');
 		test('hdnkjougmrvftewsqpailcb');
+		test('bidhfacge');
+		test('kgjnempcboaflidh');
 
 		// then, we party
 		for (let i = 0; i < 100; i += 1) test(permute());