chore: squelch test console output (#15807)

* squelch some console spam

* another

* more

* more

* more

* last one
pull/15809/head
Rich Harris 5 months ago committed by GitHub
parent e40e9eb1a4
commit a1adf2be6b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

@ -36,8 +36,6 @@ export default test({
btn1.click(); btn1.click();
}); });
console.warn(logs);
// the five components guarded by `count < 2` unmount and log // the five components guarded by `count < 2` unmount and log
assert.deepEqual(logs, [1, true, 1, true, 1, true, 1, true, 1, true]); assert.deepEqual(logs, [1, true, 1, true, 1, true, 1, true, 1, true]);

@ -351,7 +351,7 @@ async function run_test_variant(
// @ts-expect-error // @ts-expect-error
globalThis.__svelte.uid = 1; globalThis.__svelte.uid = 1;
if (manual_hydrate) { if (manual_hydrate && variant === 'hydrate') {
hydrate_fn = () => { hydrate_fn = () => {
instance = hydrate(mod.default, { instance = hydrate(mod.default, {
target, target,
@ -469,10 +469,6 @@ async function run_test_variant(
throw err; throw err;
} }
} finally { } finally {
console.log = console_log;
console.warn = console_warn;
console.error = console_error;
config.after_test?.(); config.after_test?.();
// Free up the microtask queue // Free up the microtask queue
@ -486,6 +482,10 @@ async function run_test_variant(
process.on('unhandledRejection', listener); process.on('unhandledRejection', listener);
}); });
} }
console.log = console_log;
console.warn = console_warn;
console.error = console_error;
} }
} }

@ -7,12 +7,8 @@ export default test({
dev: true dev: true
}, },
test({ assert, target, warnings }) { test({ assert, target, warnings, errors }) {
/** @type {any} */
let error;
const handler = (/** @type {any}} */ e) => { const handler = (/** @type {any}} */ e) => {
error = e.error;
e.stopImmediatePropagation(); e.stopImmediatePropagation();
}; };
@ -20,9 +16,7 @@ export default test({
target.querySelector('button')?.click(); target.querySelector('button')?.click();
assert.throws(() => { assert.include(errors[0], 'state_unsafe_mutation');
throw error;
}, /state_unsafe_mutation/);
window.removeEventListener('error', handler, true); window.removeEventListener('error', handler, true);

@ -1,4 +1,3 @@
import { assertType } from 'vitest';
import { test } from '../../test'; import { test } from '../../test';
export default test({ export default test({
@ -8,12 +7,8 @@ export default test({
dev: true dev: true
}, },
test({ assert, target, warnings, logs }) { test({ assert, target, warnings, logs, errors }) {
/** @type {any} */
let error = null;
const handler = (/** @type {any} */ e) => { const handler = (/** @type {any} */ e) => {
error = e.error;
e.stopImmediatePropagation(); e.stopImmediatePropagation();
}; };
@ -23,16 +18,12 @@ export default test({
b1.click(); b1.click();
assert.deepEqual(logs, []); assert.deepEqual(logs, []);
assert.equal(error, null); assert.deepEqual(errors, []);
error = null;
logs.length = 0;
b2.click(); b2.click();
assert.deepEqual(logs, ['clicked']); assert.deepEqual(logs, ['clicked']);
assert.equal(error, null); assert.deepEqual(errors, []);
error = null;
logs.length = 0; logs.length = 0;
b3.click(); b3.click();
@ -40,8 +31,7 @@ export default test({
assert.deepEqual(warnings, [ assert.deepEqual(warnings, [
'`click` handler at main.svelte:10:17 should be a function. Did you mean to add a leading `() =>`?' '`click` handler at main.svelte:10:17 should be a function. Did you mean to add a leading `() =>`?'
]); ]);
assert.isNotNull(error); assert.include(errors[0], 'is not a function');
assert.match(error.message, /is not a function/);
window.removeEventListener('error', handler, true); window.removeEventListener('error', handler, true);
} }

@ -7,12 +7,8 @@ export default test({
dev: true dev: true
}, },
test({ assert, target, warnings }) { test({ assert, target, warnings, errors }) {
/** @type {any} */
let error;
const handler = (/** @type {any} */ e) => { const handler = (/** @type {any} */ e) => {
error = e.error;
e.stopImmediatePropagation(); e.stopImmediatePropagation();
}; };
@ -20,9 +16,7 @@ export default test({
target.querySelector('button')?.click(); target.querySelector('button')?.click();
assert.throws(() => { assert.include(errors[0], 'state_unsafe_mutation');
throw error;
}, /state_unsafe_mutation/);
window.removeEventListener('error', handler, true); window.removeEventListener('error', handler, true);

@ -6,11 +6,12 @@ export default test({
dev: true dev: true
}, },
async test({ assert, target, logs }) { async test({ assert, target, logs, errors }) {
const b1 = target.querySelector('button'); const b1 = target.querySelector('button');
b1?.click(); b1?.click();
flushSync(); flushSync();
assert.ok(errors.length > 0);
assert.deepEqual(logs, ['init', 'a', 'init', 'b']); assert.deepEqual(logs, ['init', 'a', 'init', 'b']);
} }
}); });

@ -1,8 +1,12 @@
import { assert } from 'vitest';
import { test } from '../../test'; import { test } from '../../test';
export default test({ export default test({
compileOptions: { compileOptions: {
dev: true dev: true
}, },
test() {}
test({ logs }) {
assert.ok(logs.length > 0);
}
}); });

@ -1,6 +1,6 @@
<script> <script>
const log = () => { const log = () => {
console.log(snip); if (!snip) throw new Error('oops');
} }
let x = $state(0); let x = $state(0);
</script> </script>
@ -9,4 +9,4 @@
{#snippet snip()} {#snippet snip()}
snippet {x} snippet {x}
{/snippet} {/snippet}

@ -15,6 +15,7 @@ import { derived } from '../../src/internal/client/reactivity/deriveds';
import { snapshot } from '../../src/internal/shared/clone.js'; import { snapshot } from '../../src/internal/shared/clone.js';
import { SvelteSet } from '../../src/reactivity/set'; import { SvelteSet } from '../../src/reactivity/set';
import { DESTROYED } from '../../src/internal/client/constants'; import { DESTROYED } from '../../src/internal/client/constants';
import { noop } from 'svelte/internal/client';
/** /**
* @param runes runes mode * @param runes runes mode
@ -469,6 +470,9 @@ describe('signals', () => {
test('schedules rerun when writing to signal before reading it', (runes) => { test('schedules rerun when writing to signal before reading it', (runes) => {
if (!runes) return () => {}; if (!runes) return () => {};
const error = console.error;
console.error = noop;
const value = state({ count: 0 }); const value = state({ count: 0 });
user_effect(() => { user_effect(() => {
set(value, { count: 0 }); set(value, { count: 0 });
@ -482,14 +486,19 @@ describe('signals', () => {
} catch (e: any) { } catch (e: any) {
assert.include(e.message, 'effect_update_depth_exceeded'); assert.include(e.message, 'effect_update_depth_exceeded');
errored = true; errored = true;
} finally {
assert.equal(errored, true);
console.error = error;
} }
assert.equal(errored, true);
}; };
}); });
test('schedules rerun when updating deeply nested value', (runes) => { test('schedules rerun when updating deeply nested value', (runes) => {
if (!runes) return () => {}; if (!runes) return () => {};
const error = console.error;
console.error = noop;
const value = proxy({ a: { b: { c: 0 } } }); const value = proxy({ a: { b: { c: 0 } } });
user_effect(() => { user_effect(() => {
value.a.b.c += 1; value.a.b.c += 1;
@ -502,14 +511,19 @@ describe('signals', () => {
} catch (e: any) { } catch (e: any) {
assert.include(e.message, 'effect_update_depth_exceeded'); assert.include(e.message, 'effect_update_depth_exceeded');
errored = true; errored = true;
} finally {
assert.equal(errored, true);
console.error = error;
} }
assert.equal(errored, true);
}; };
}); });
test('schedules rerun when writing to signal before reading it', (runes) => { test('schedules rerun when writing to signal before reading it', (runes) => {
if (!runes) return () => {}; if (!runes) return () => {};
const error = console.error;
console.error = noop;
const value = proxy({ arr: [] }); const value = proxy({ arr: [] });
user_effect(() => { user_effect(() => {
value.arr = []; value.arr = [];
@ -523,8 +537,10 @@ describe('signals', () => {
} catch (e: any) { } catch (e: any) {
assert.include(e.message, 'effect_update_depth_exceeded'); assert.include(e.message, 'effect_update_depth_exceeded');
errored = true; errored = true;
} finally {
assert.equal(errored, true);
console.error = error;
} }
assert.equal(errored, true);
}; };
}); });

Loading…
Cancel
Save