fix: throw error when auto-subscribed store variable shadow by local variable (#11170)

.changeset/afraid-kids-hide.md

@@ -0,0 +1,5 @@
+---
+"svelte": patch
+---
+
+fix: throw error when auto-subscribed store variable shadow by local variable

packages/svelte/src/compiler/phases/2-analyze/index.js

@@ -302,8 +302,8 @@ export function analyze_component(root, source, options) {
 					declaration.initial.source.value === 'svelte/store'
 				))
 		) {
-			let is_nested_store_subscription = false;
+			let is_nested_store_subscription_node = undefined;
-			for (const reference of references) {
+			search: for (const reference of references) {
 				for (let i = reference.path.length - 1; i >= 0; i--) {
 					const scope =
 						scopes.get(reference.path[i]) ||
@@ -311,14 +311,17 @@ export function analyze_component(root, source, options) {
 						instance.scopes.get(reference.path[i]);
 					if (scope) {
 						const owner = scope?.owner(store_name);
-						is_nested_store_subscription =
+						if (!!owner && owner !== module.scope && owner !== instance.scope) {
-							!!owner && owner !== module.scope && owner !== instance.scope;
+							is_nested_store_subscription_node = reference.node;
+							break search;
+						}
 						break;
 					}
 				}
 			}
-			if (is_nested_store_subscription) {
+
-				error(references[0].node, 'illegal-store-subscription');
+			if (is_nested_store_subscription_node) {
+				error(is_nested_store_subscription_node, 'illegal-store-subscription');
 			}
 
 			if (options.runes !== false) {

packages/svelte/tests/compiler-errors/samples/store-shadow-scope-2/_config.js

@@ -0,0 +1,9 @@
+import { test } from '../../test';
+
+export default test({
+	error: {
+		code: 'illegal-store-subscription',
+		message: 'Cannot subscribe to stores that are not declared at the top level of the component',
+		position: [142, 147]
+	}
+});

packages/svelte/tests/compiler-errors/samples/store-shadow-scope-2/main.svelte

@@ -0,0 +1,8 @@
+<script>
+	import { writable } from 'svelte/store';
+	const user = writable(0);
+	const users = [];
+	$: selected = users.find(user => user.id == $user);
+
+	$: console.log($user);
+</script>

packages/svelte/tests/compiler-errors/samples/store-shadow-scope-3/_config.js

@@ -0,0 +1,9 @@
+import { test } from '../../test';
+
+export default test({
+	error: {
+		code: 'illegal-store-subscription',
+		message: 'Cannot subscribe to stores that are not declared at the top level of the component',
+		position: [167, 172]
+	}
+});

packages/svelte/tests/compiler-errors/samples/store-shadow-scope-3/main.svelte

@@ -0,0 +1,8 @@
+<script>
+	import { writable } from 'svelte/store';
+	const user = writable(0);
+	const users = [];
+
+	$: console.log($user);
+	$: selected = users.find(user => user.id == $user);
+</script>