Merge pull request #255 from msteitle/dontThrowParseErrorOnDoctypeDeclaration

Dont throw parse error on doctype declaration
8 years ago · 9a2b8275f8
parent d5411f43d6 522f293766
commit 9a2b8275f8
4 changed files with 26 additions and 2 deletions
--- a/src/parse/state/tag.js
+++ b/src/parse/state/tag.js
@ -6,7 +6,7 @@ import { trimStart, trimEnd } from '../utils/trim.js';
 import { decodeCharacterReferences } from '../utils/html.js';
 import voidElementNames from '../../utils/voidElementNames.js';

-const validTagName = /^[a-zA-Z]{1,}:?[a-zA-Z0-9\-]*/;
+const validTagName = /^\!?[a-zA-Z]{1,}:?[a-zA-Z0-9\-]*/;
 const invalidUnquotedAttributeCharacters = /[\s"'=<>\/`]/;

 const specials = {
--- a/src/utils/voidElementNames.js
+++ b/src/utils/voidElementNames.js
@ -1 +1 @@
-export default /^(?:area|base|br|col|command|doctype|embed|hr|img|input|keygen|link|meta|param|source|track|wbr)$/;
+export default /^(?:area|base|br|col|command|\!doctype|embed|hr|img|input|keygen|link|meta|param|source|track|wbr)$/;
--- a/test/parser/elements/input.html
+++ b/test/parser/elements/input.html
@ -0,0 +1 @@
+<!doctype html>
--- a/test/parser/elements/output.json
+++ b/test/parser/elements/output.json
@ -0,0 +1,23 @@
+{
+    "html": {
+        "start": 0,
+        "end": 15,
+        "type": "Fragment",
+        "children": [{
+            "attributes": [{
+                "end": 14,
+                "name": "html",
+                "start": 10,
+                "type": "Attribute",
+                "value": true
+            }],
+            "children": [],
+            "end": 15,
+            "name": "!doctype",
+            "start": 0,
+            "type": "Element"
+        }]
+    },
+    "css": null,
+    "js": null
+}