fix: replace span with button (a11y) (#10763)

* fix(site): console line button a11y fixup

* make log.label part of button
pull/10789/head
Antonio Sarcevic 4 months ago committed by GitHub
parent 3f7fcf9aec
commit 9223032a2a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

@ -15,26 +15,18 @@
<ConsoleTable data={log.args[0]} columns={log.args[1]} /> <ConsoleTable data={log.args[0]} columns={log.args[1]} />
{/if} {/if}
<button <span class="log console-{log.level}" style="padding-left: {level * 15}px">
class="log console-{log.level}"
style="padding-left: {level * 15}px"
on:click={log.level === 'group' ? toggle_group_collapse : undefined}
>
{#if log.count && log.count > 1} {#if log.count && log.count > 1}
<span class="count">{log.count}x</span> <span class="count">{log.count}x</span>
{/if} {/if}
{#if log.level === 'trace' || log.level === 'assert'} {#if log.level === 'trace' || log.level === 'assert' || log.level === 'group'}
<span <button on:click={toggle_group_collapse}>
class="arrow" <span class="arrow" class:expand={!log.collapsed}> ▶️ </span>
role="button" {#if log.level === 'group'}
tabindex="0" <span class="title">{log.label}</span>
class:expand={!log.collapsed} {/if}
on:keyup={toggle_group_collapse} </button>
on:click={toggle_group_collapse}
>
</span>
{/if} {/if}
{#if log.level === 'assert'} {#if log.level === 'assert'}
@ -45,9 +37,6 @@
<span class="info">Console was cleared</span> <span class="info">Console was cleared</span>
{:else if log.level === 'unclonable'} {:else if log.level === 'unclonable'}
<span class="info error">Message could not be cloned. Open devtools to see it</span> <span class="info error">Message could not be cloned. Open devtools to see it</span>
{:else if log.level === 'group'}
<div class="arrow" class:expand={!log.collapsed}>▶</div>
<span class="title">{log.label}</span>
{:else if log.level.startsWith('system')} {:else if log.level.startsWith('system')}
{#each log.args ?? [] as arg} {#each log.args ?? [] as arg}
{arg} {arg}
@ -62,7 +51,7 @@
{#each new Array(level - 1) as _, idx} {#each new Array(level - 1) as _, idx}
<div class="outline" style="left: {idx * 15 + 15}px" /> <div class="outline" style="left: {idx * 15 + 15}px" />
{/each} {/each}
</button> </span>
{#if log.level === 'group' && !log.collapsed} {#if log.level === 'group' && !log.collapsed}
{#each log.logs ?? [] as childLog} {#each log.logs ?? [] as childLog}

Loading…
Cancel
Save