[fix] set selectedIndex to -1 when no option matches bound <select> value (#6170)

pull/6671/head
Theodore Brown 3 years ago committed by GitHub
parent ca096b7560
commit 8cb72d9716
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -542,6 +542,8 @@ export function select_option(select, value) {
return;
}
}
select.selectedIndex = -1; // no option should be selected
}
export function select_options(select, value) {

@ -14,6 +14,7 @@ export default {
`,
test({ assert, component, target }) {
assert.equal(component.selected, 'a');
const select = target.querySelector('select');
const options = [...target.querySelectorAll('option')];

@ -0,0 +1,60 @@
export default {
html: `
<p>selected: null</p>
<select>
<option value='a'>a</option>
<option value='b'>b</option>
<option value='c'>c</option>
</select>
<p>selected: null</p>
`,
async test({ assert, component, target }) {
const select = target.querySelector('select');
const options = [...target.querySelectorAll('option')];
assert.equal(component.selected, null);
// no option should be selected since none of the options matches the bound value
assert.equal(select.value, '');
assert.equal(select.selectedIndex, -1);
assert.ok(!options[0].selected);
component.selected = 'a'; // first option should now be selected
assert.equal(select.value, 'a');
assert.ok(options[0].selected);
assert.htmlEqual(target.innerHTML, `
<p>selected: a</p>
<select>
<option value='a'>a</option>
<option value='b'>b</option>
<option value='c'>c</option>
</select>
<p>selected: a</p>
`);
component.selected = 'd'; // doesn't match an option
// now no option should be selected again
assert.equal(select.value, '');
assert.equal(select.selectedIndex, -1);
assert.ok(!options[0].selected);
assert.htmlEqual(target.innerHTML, `
<p>selected: d</p>
<select>
<option value='a'>a</option>
<option value='b'>b</option>
<option value='c'>c</option>
</select>
<p>selected: d</p>
`);
}
};

@ -0,0 +1,14 @@
<script>
// set as null so no option will be selected by default
export let selected = null;
</script>
<p>selected: {selected}</p>
<select bind:value={selected}>
<option>a</option>
<option>b</option>
<option>c</option>
</select>
<p>selected: {selected}</p>
Loading…
Cancel
Save